diff options
| author | Florian Barbin | 2016-03-25 16:52:04 +0000 |
|---|---|---|
| committer | Laurent Redor | 2016-04-25 16:10:13 +0000 |
| commit | b3953194b7606d240ece76eca8a31e18f0e112e3 (patch) | |
| tree | 4ec4f747021d9054894b21782fdd4e440701df57 | |
| parent | d5f32547b60d19b08be6b68ff45fd5206712f6cd (diff) | |
| download | org.eclipse.sirius-b3953194b7606d240ece76eca8a31e18f0e112e3.tar.gz org.eclipse.sirius-b3953194b7606d240ece76eca8a31e18f0e112e3.tar.xz org.eclipse.sirius-b3953194b7606d240ece76eca8a31e18f0e112e3.zip | |
[490444] Feature Specification
Bug: 490444
Change-Id: Idef9a8a822d4450204628e862ddd80b9d8fdce0f
Signed-off-by: Florian Barbin <florian.barbin@obeo.fr>
| -rw-r--r-- | plugins/org.eclipse.sirius.doc/specs/proposal/490444/490444.html | 84 | ||||
| -rw-r--r-- | plugins/org.eclipse.sirius.doc/specs/proposal/490444/490444.textile | 54 | ||||
| -rw-r--r-- | plugins/org.eclipse.sirius.doc/specs/proposal/490444/copyAppearance.png | bin | 0 -> 6330 bytes | |||
| -rw-r--r-- | plugins/org.eclipse.sirius.doc/specs/proposal/490444/selectionBefore.png | bin | 0 -> 6495 bytes | |||
| -rw-r--r-- | plugins/org.eclipse.sirius.doc/specs/proposal/490444/sizeBoth.png | bin | 0 -> 6338 bytes |
5 files changed, 138 insertions, 0 deletions
diff --git a/plugins/org.eclipse.sirius.doc/specs/proposal/490444/490444.html b/plugins/org.eclipse.sirius.doc/specs/proposal/490444/490444.html new file mode 100644 index 0000000000..f52481098a --- /dev/null +++ b/plugins/org.eclipse.sirius.doc/specs/proposal/490444/490444.html @@ -0,0 +1,84 @@ +<?xml version='1.0' encoding='utf-8' ?><!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> +<html xmlns="http://www.w3.org/1999/xhtml"> + <head> + <meta http-equiv="Content-Type" content="text/html; charset=utf-8"/> + <title>490444</title> + <link type="text/css" rel="stylesheet" href="../../../doc/resources/bootstrap.css"/> + <link type="text/css" rel="stylesheet" href="../../../doc/resources/custom.css"/> + </head> + <body> + <h1 id="SiriusEvolutionSpecificationMaketheCopyAppearanceActionusethelastselection">Sirius Evolution Specification: Make the Copy Appearance Action use the last selection</h1> + <h2 id="Preamble">Preamble</h2> + <p> + <em>Summary</em>: The Copy Appearance Action should consider the last selected element as base style instead of the first one. + </p> + <table> + <tr> + <th>Version </th> + <th>Status </th> + <th>Date </th> + <th>Authors </th> + <th>Changes </th> + </tr> + <tr> + <td>v0.1 </td> + <td>DRAFT </td> + <td>2016-03-25 </td> + <td>fbarbin </td> + <td>Initial version. </td> + </tr> + <tr> + <td>v0.2 </td> + <td>DRAFT </td> + <td>2016-04-20 </td> + <td>fbarbin </td> + <td>Corrections after team review. </td> + </tr> + </table> + <p> + <em>Relevant tickets</em>: + </p> + <ul> + <li> + <a href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=490444">Bug 490444 – The Copy Appearance Action should consider the last selected element as base style</a> + </li> + </ul> + <h2 id="Introduction">Introduction</h2> + <p>Currently, the + <em>Copy Appearance Properties</em> action is not consistent with the + <em>Size Both</em> action which uses the last selected element as base size. The + <em>Copy Appearance Properties</em> action uses the first selected element as base style. Furthermore, the last selected element is highlighted in a way that suggests this one is the reference to copy the style or the size. + </p> + <h2 id="DetailedSpecification">Detailed Specification</h2> + <p>Taking the following selection: + <br/> + <img border="0" src="selectionBefore.png"/> + <br/>The last selected element is the dark border node. We can also notice that the last selection is highlighted with black handles. When applying the + <em>Size Both</em> action the two other selected elements take the last selection size: + <br/> + <img border="0" src="sizeBoth.png"/> + <br/>However, when applying the + <em>Copy Appearance Properties</em> action, its the first selection which is taken into account: + <br/> + <img border="0" src="copyAppearance.png"/> + </p> + <p>This enhancement aims to modify this action to have a similar behavior to the Size Both Action.</p> + <h2 id="BackwardCompatibilityandMigrationPaths">Backward Compatibility and Migration Paths</h2> + <h3 id="MetamodelChanges">Metamodel Changes</h3> + <p>There is no metamodel changes for this feature.</p> + <h3 id="APIChanges">API Changes</h3> + <p>We do not intend to change any API.</p> + <h3 id="UserInterfaceChanges">User Interface Changes</h3> + <p>The end-user will see the new behavior of the + <em>Copy Appearance Properties</em> action. The tooltip of the action will also be changed. + </p> + <h3 id="DocumentationChanges">Documentation Changes</h3> + <p>The release note and the end user documentation will be updated.</p> + <h2 id="TestsandNonregressionstrategy">Tests and Non-regression strategy</h2> + <p>We will add a new SWTBot that checks the result of applying the + <em>Copy Appearance Properties</em> Action. This test will check with two and several selected elements if at the end, all the elements have the appearance of the last selection. + </p> + <h2 id="Implementationchoicesandtradeoffs">Implementation choices and tradeoffs</h2> + <p>Since this action is defined in GMF we need to duplicate it. A patch will be suggested in GMF to modify this behavior.</p> + </body> +</html>
\ No newline at end of file diff --git a/plugins/org.eclipse.sirius.doc/specs/proposal/490444/490444.textile b/plugins/org.eclipse.sirius.doc/specs/proposal/490444/490444.textile new file mode 100644 index 0000000000..2a1333e045 --- /dev/null +++ b/plugins/org.eclipse.sirius.doc/specs/proposal/490444/490444.textile @@ -0,0 +1,54 @@ +h1. Sirius Evolution Specification: Make the Copy Appearance Action use the last selection + +h2. Preamble + +_Summary_: The Copy Appearance Action should consider the last selected element as base style instead of the first one. + +|_. Version |_. Status |_. Date |_. Authors |_. Changes | +| v0.1 | DRAFT | 2016-03-25 | fbarbin | Initial version. | +| v0.2 | DRAFT | 2016-04-20 | fbarbin | Corrections after team review. | + +_Relevant tickets_: +* "Bug 490444 - The Copy Appearance Action should consider the last selected element as base style":https://bugs.eclipse.org/bugs/show_bug.cgi?id=490444 + +h2. Introduction + +Currently, the _Copy Appearance Properties_ action is not consistent with the _Size Both_ action which uses the last selected element as base size. The _Copy Appearance Properties_ action uses the first selected element as base style. Furthermore, the last selected element is highlighted in a way that suggests this one is the reference to copy the style or the size. + +h2. Detailed Specification + +Taking the following selection: +!selectionBefore.png! +The last selected element is the dark border node. We can also notice that the last selection is highlighted with black handles. When applying the _Size Both_ action the two other selected elements take the last selection size: +!sizeBoth.png! +However, when applying the _Copy Appearance Properties_ action, its the first selection which is taken into account: +!copyAppearance.png! + +This enhancement aims to modify this action to have a similar behavior to the Size Both Action. + +h2. Backward Compatibility and Migration Paths + + +h3. Metamodel Changes + +There is no metamodel changes for this feature. + +h3. API Changes + +We do not intend to change any API. + +h3. User Interface Changes + +The end-user will see the new behavior of the _Copy Appearance Properties_ action. The tooltip of the action will also be changed. + +h3. Documentation Changes + +The release note and the end user documentation will be updated. + +h2. Tests and Non-regression strategy + +We will add a new SWTBot that checks the result of applying the _Copy Appearance Properties_ Action. This test will check with two and several selected elements if at the end, all the elements have the appearance of the last selection. + +h2. Implementation choices and tradeoffs + +Since this action is defined in GMF we need to duplicate it. A patch will be suggested in GMF to modify this behavior. diff --git a/plugins/org.eclipse.sirius.doc/specs/proposal/490444/copyAppearance.png b/plugins/org.eclipse.sirius.doc/specs/proposal/490444/copyAppearance.png Binary files differnew file mode 100644 index 0000000000..06d15bf4bd --- /dev/null +++ b/plugins/org.eclipse.sirius.doc/specs/proposal/490444/copyAppearance.png diff --git a/plugins/org.eclipse.sirius.doc/specs/proposal/490444/selectionBefore.png b/plugins/org.eclipse.sirius.doc/specs/proposal/490444/selectionBefore.png Binary files differnew file mode 100644 index 0000000000..5f8f486316 --- /dev/null +++ b/plugins/org.eclipse.sirius.doc/specs/proposal/490444/selectionBefore.png diff --git a/plugins/org.eclipse.sirius.doc/specs/proposal/490444/sizeBoth.png b/plugins/org.eclipse.sirius.doc/specs/proposal/490444/sizeBoth.png Binary files differnew file mode 100644 index 0000000000..152b88c610 --- /dev/null +++ b/plugins/org.eclipse.sirius.doc/specs/proposal/490444/sizeBoth.png |
