diff options
| author | Pierre-Charles David | 2017-08-31 07:46:59 +0000 |
|---|---|---|
| committer | Pierre-Charles David | 2017-08-31 07:47:04 +0000 |
| commit | 7a13d1bdb44e11b9d96cce887867791c6f456c81 (patch) | |
| tree | c4d7909e2abfc10b97134cba8d36fcbe5646ab03 | |
| parent | 559096c18f1f76dd27fe287139586049cf6e40fe (diff) | |
| download | org.eclipse.sirius-7a13d1bdb44e11b9d96cce887867791c6f456c81.tar.gz org.eclipse.sirius-7a13d1bdb44e11b9d96cce887867791c6f456c81.tar.xz org.eclipse.sirius-7a13d1bdb44e11b9d96cce887867791c6f456c81.zip | |
[518524] Fix potential leak in PluginPageProviderRegistry
The lookup in extensionToPageProvider was using the "IExtension[]
extensions" argument as key instead of the individual "extension"
we're iterating on, so it would always fail and never call
pageRegistry.removePageProvider().
Bug: 518524
Change-Id: Ia1a99bc764a73067b4f9282c8b4e0e084fbd596b
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
| -rw-r--r-- | plugins/org.eclipse.sirius.ui.editor/src/org/eclipse/sirius/ui/editor/internal/pages/PluginPageProviderRegistry.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/plugins/org.eclipse.sirius.ui.editor/src/org/eclipse/sirius/ui/editor/internal/pages/PluginPageProviderRegistry.java b/plugins/org.eclipse.sirius.ui.editor/src/org/eclipse/sirius/ui/editor/internal/pages/PluginPageProviderRegistry.java index 27f06b2130..4a7f3187de 100644 --- a/plugins/org.eclipse.sirius.ui.editor/src/org/eclipse/sirius/ui/editor/internal/pages/PluginPageProviderRegistry.java +++ b/plugins/org.eclipse.sirius.ui.editor/src/org/eclipse/sirius/ui/editor/internal/pages/PluginPageProviderRegistry.java @@ -125,7 +125,7 @@ public class PluginPageProviderRegistry implements IRegistryEventListener { @Override public void removed(IExtension[] extensions) { for (IExtension extension : extensions) { - List<PageProvider> pageProviders = extensionToPageProvider.get(extensions); + List<PageProvider> pageProviders = extensionToPageProvider.get(extension); if (pageProviders != null) { for (PageProvider pageProvider : pageProviders) { |