Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEsteban Dugueperoux2015-05-07 08:28:20 +0000
committerEsteban DUGUEPEROUX2015-05-07 12:55:18 +0000
commit4c6eb7c4c416e89b57439811e1a8fb14e12631b0 (patch)
tree11892db43076aae7e9c2ab81f4b52b45a8925635
parent48b97eb172523e763440623d1535e21b0700876c (diff)
downloadorg.eclipse.sirius-4c6eb7c4c416e89b57439811e1a8fb14e12631b0.tar.gz
org.eclipse.sirius-4c6eb7c4c416e89b57439811e1a8fb14e12631b0.tar.xz
org.eclipse.sirius-4c6eb7c4c416e89b57439811e1a8fb14e12631b0.zip
[465955] Deprecate useless IUndoableCommand
- Deprecate IUndoableCommand interface. - Deprecate TaskExecutor.undo()/redo() methods. - Deprecate ICommandTask.undo()/redo() methods. - Updated Release Notes. Bug: 465955 Change-Id: I61b02a283e66270275180e6e67705268b4612fb6 Signed-off-by: Esteban Dugueperoux <esteban.dugueperoux@obeo.fr>
-rw-r--r--plugins/org.eclipse.sirius.doc/doc/Release Notes.html11
-rw-r--r--plugins/org.eclipse.sirius.doc/doc/Release Notes.textile3
-rw-r--r--plugins/org.eclipse.sirius/src/org/eclipse/sirius/business/api/helper/task/ICommandTask.java8
-rw-r--r--plugins/org.eclipse.sirius/src/org/eclipse/sirius/business/api/helper/task/TaskExecutor.java8
-rw-r--r--plugins/org.eclipse.sirius/src/org/eclipse/sirius/tools/api/command/IUndoableCommand.java2
5 files changed, 31 insertions, 1 deletions
diff --git a/plugins/org.eclipse.sirius.doc/doc/Release Notes.html b/plugins/org.eclipse.sirius.doc/doc/Release Notes.html
index 72cfeac8ec..019d9afb90 100644
--- a/plugins/org.eclipse.sirius.doc/doc/Release Notes.html
+++ b/plugins/org.eclipse.sirius.doc/doc/Release Notes.html
@@ -183,6 +183,15 @@
<code>org.eclipse.sirius.viewpoint.DAnalysis</code> returns a non-modifiable list. Use
<code>getSemanticResources()</code> instead.
</li>
+ <li>
+ <code>org.eclipse.sirius.business.api.helper.task.ICommandTask.undo()/redo()</code> methods are deprecated because they are useless since undo/redo is managed by EMF Transaction.
+ </li>
+ <li>
+ <code>org.eclipse.sirius.tools.api.command.IUndoableCommand</code> interface are deprecated because it is useless since undo/redo is managed by EMF Transaction.
+ </li>
+ <li>
+ <code>org.eclipse.sirius.business.api.helper.task.TaskExecutor.undo()/redo()</code> methods are deprecated because they are useless since undo/redo is managed by EMF Transaction.
+ </li>
</ul>
<h4 id="Changesinorg.eclipse.sirius.ui">Changes in
<code>org.eclipse.sirius.ui</code>
@@ -2644,4 +2653,4 @@ void removeSelectedView(DView view);
<li>The ability to print table representations has been disabled for the 0.9 release due to an external dependency issue (see <a href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=422223" target="_blank">bug #422223</a>: for the details). It should be re-introduced in 1.0.</li>
</ul>
</body>
-</html> \ No newline at end of file
+</html>
diff --git a/plugins/org.eclipse.sirius.doc/doc/Release Notes.textile b/plugins/org.eclipse.sirius.doc/doc/Release Notes.textile
index 19622b38a7..46396a2acd 100644
--- a/plugins/org.eclipse.sirius.doc/doc/Release Notes.textile
+++ b/plugins/org.eclipse.sirius.doc/doc/Release Notes.textile
@@ -55,6 +55,9 @@ h4. Changes in @org.eclipse.sirius@
* The API @org.eclipse.sirius.viewpoint.DContainer@ has been removed.
* A new method has been added in @org.eclipse.sirius.viewpoint.DAnalysis@ named @getSemanticResources()@. This method returns a list of @org.eclipse.sirius.business.api.resource.ResourceDescriptor@ which is a descriptor of the semantic resource.
* The @getModels()@ method in @org.eclipse.sirius.viewpoint.DAnalysis@ returns a non-modifiable list. Use @getSemanticResources()@ instead.
+* @org.eclipse.sirius.business.api.helper.task.ICommandTask.undo()/redo()@ methods are deprecated because they are useless since undo/redo is managed by EMF Transaction.
+* @org.eclipse.sirius.tools.api.command.IUndoableCommand@ interface are deprecated because it is useless since undo/redo is managed by EMF Transaction.
+* @org.eclipse.sirius.business.api.helper.task.TaskExecutor.undo()/redo()@ methods are deprecated because they are useless since undo/redo is managed by EMF Transaction.
h4. Changes in @org.eclipse.sirius.ui@
diff --git a/plugins/org.eclipse.sirius/src/org/eclipse/sirius/business/api/helper/task/ICommandTask.java b/plugins/org.eclipse.sirius/src/org/eclipse/sirius/business/api/helper/task/ICommandTask.java
index 78953c7b97..06b1052384 100644
--- a/plugins/org.eclipse.sirius/src/org/eclipse/sirius/business/api/helper/task/ICommandTask.java
+++ b/plugins/org.eclipse.sirius/src/org/eclipse/sirius/business/api/helper/task/ICommandTask.java
@@ -64,11 +64,19 @@ public interface ICommandTask {
/**
* Undo the task. By default it will not undo the children tasks.
+ *
+ * @deprecated is no more useful since undo/redo is managed by EMF
+ * Transaction.
*/
+ @Deprecated
void undo();
/**
* Redo the task. By default it will not redo the children tasks.
+ *
+ * @deprecated is no more useful since undo/redo is managed by EMF
+ * Transaction.
*/
+ @Deprecated
void redo();
}
diff --git a/plugins/org.eclipse.sirius/src/org/eclipse/sirius/business/api/helper/task/TaskExecutor.java b/plugins/org.eclipse.sirius/src/org/eclipse/sirius/business/api/helper/task/TaskExecutor.java
index 8f7a91d26c..15e5f68864 100644
--- a/plugins/org.eclipse.sirius/src/org/eclipse/sirius/business/api/helper/task/TaskExecutor.java
+++ b/plugins/org.eclipse.sirius/src/org/eclipse/sirius/business/api/helper/task/TaskExecutor.java
@@ -70,7 +70,11 @@ public final class TaskExecutor {
*
* @param tasks
* the tasks list to undo
+ *
+ * @deprecated is no more useful since undo/redo is managed by EMF
+ * Transaction.
*/
+ @Deprecated
public static void undo(final List<ICommandTask> tasks) {
TaskExecutor.operation(tasks, KIND_UNDO);
}
@@ -80,7 +84,11 @@ public final class TaskExecutor {
*
* @param tasks
* the tasks list to redo
+ *
+ * @deprecated is no more useful since undo/redo is managed by EMF
+ * Transaction.
*/
+ @Deprecated
public static void redo(final List<ICommandTask> tasks) {
TaskExecutor.operation(tasks, KIND_REDO);
}
diff --git a/plugins/org.eclipse.sirius/src/org/eclipse/sirius/tools/api/command/IUndoableCommand.java b/plugins/org.eclipse.sirius/src/org/eclipse/sirius/tools/api/command/IUndoableCommand.java
index ce70a14c60..2391acefe4 100644
--- a/plugins/org.eclipse.sirius/src/org/eclipse/sirius/tools/api/command/IUndoableCommand.java
+++ b/plugins/org.eclipse.sirius/src/org/eclipse/sirius/tools/api/command/IUndoableCommand.java
@@ -13,8 +13,10 @@ package org.eclipse.sirius.tools.api.command;
/**
* An Undoable command.
*
+ * @deprecated is no more useful since undo/redo is managed by EMF Transaction.
* @author mchauvin
*/
+@Deprecated
public interface IUndoableCommand {
/**

Back to the top