Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMaxime PORHEL2014-03-10 10:51:07 +0000
committerMaxime PORHEL2014-03-10 10:51:07 +0000
commit1e93390dd92da2fb0cb0f4bd253fc788a180620b (patch)
treec39241a8062c6afcf1b225a4953ad1526b842d28
parent09d9986ee2be0b0870bf419ff631380cc7018154 (diff)
downloadorg.eclipse.sirius-1e93390dd92da2fb0cb0f4bd253fc788a180620b.tar.gz
org.eclipse.sirius-1e93390dd92da2fb0cb0f4bd253fc788a180620b.tar.xz
org.eclipse.sirius-1e93390dd92da2fb0cb0f4bd253fc788a180620b.zip
[426806] Remove non initialized viewPointPreferenceChangeListener field
This should have been removed during command factories setAutoRefreshDXXX() methods removal. The listener was used to report the preference change in those non implemented methodes, the preference initalization has been removed but not the field, and listener installation/removal. Change-Id: Iaeb32634edf604cefc5b75bff3701e8f64f3aecc Signed-off-by: Maxime PORHEL <maxime.porhel@obeo.fr>
-rw-r--r--plugins/org.eclipse.sirius.table.ui/src/org/eclipse/sirius/table/ui/tools/internal/editor/AbstractDTableEditor.java11
-rw-r--r--plugins/org.eclipse.sirius.tree.ui/src/org/eclipse/sirius/tree/ui/tools/internal/editor/DTreeEditor.java10
2 files changed, 0 insertions, 21 deletions
diff --git a/plugins/org.eclipse.sirius.table.ui/src/org/eclipse/sirius/table/ui/tools/internal/editor/AbstractDTableEditor.java b/plugins/org.eclipse.sirius.table.ui/src/org/eclipse/sirius/table/ui/tools/internal/editor/AbstractDTableEditor.java
index e369fe86c6..6fd48c22f7 100644
--- a/plugins/org.eclipse.sirius.table.ui/src/org/eclipse/sirius/table/ui/tools/internal/editor/AbstractDTableEditor.java
+++ b/plugins/org.eclipse.sirius.table.ui/src/org/eclipse/sirius/table/ui/tools/internal/editor/AbstractDTableEditor.java
@@ -28,8 +28,6 @@ import org.eclipse.core.runtime.IProgressMonitor;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.NullProgressMonitor;
import org.eclipse.core.runtime.Status;
-import org.eclipse.core.runtime.preferences.IEclipsePreferences.IPreferenceChangeListener;
-import org.eclipse.core.runtime.preferences.InstanceScope;
import org.eclipse.emf.common.notify.AdapterFactory;
import org.eclipse.emf.common.util.TreeIterator;
import org.eclipse.emf.common.util.URI;
@@ -122,8 +120,6 @@ public abstract class AbstractDTableEditor extends AbstractDTreeEditor implement
private IPartListener refreshAtOpeningActivator;
- private IPreferenceChangeListener viewPointPreferenceChangeListener;
-
private IInterpreter getInterpreter() {
return SiriusPlugin.getDefault().getInterpreterRegistry().getInterpreter(getTableModel().getTarget());
}
@@ -293,9 +289,6 @@ public abstract class AbstractDTableEditor extends AbstractDTreeEditor implement
/* Update title. Semantic table could have been renamed */
notify(PROP_TITLE);
- /* handle preferences */
- InstanceScope.INSTANCE.getNode(SiriusPlugin.ID).addPreferenceChangeListener(viewPointPreferenceChangeListener);
-
// Launch the refresh if needed
if (DialectManager.INSTANCE.isRefreshActivatedOnRepresentationOpening()) {
launchRefresh();
@@ -634,9 +627,5 @@ public abstract class AbstractDTableEditor extends AbstractDTreeEditor implement
getSite().getPage().removePartListener(refreshAtOpeningActivator);
refreshAtOpeningActivator = null;
}
-
- InstanceScope.INSTANCE.getNode(SiriusPlugin.ID).removePreferenceChangeListener(viewPointPreferenceChangeListener);
- viewPointPreferenceChangeListener = null;
-
}
}
diff --git a/plugins/org.eclipse.sirius.tree.ui/src/org/eclipse/sirius/tree/ui/tools/internal/editor/DTreeEditor.java b/plugins/org.eclipse.sirius.tree.ui/src/org/eclipse/sirius/tree/ui/tools/internal/editor/DTreeEditor.java
index c0e5e3bb67..10caf4a01f 100644
--- a/plugins/org.eclipse.sirius.tree.ui/src/org/eclipse/sirius/tree/ui/tools/internal/editor/DTreeEditor.java
+++ b/plugins/org.eclipse.sirius.tree.ui/src/org/eclipse/sirius/tree/ui/tools/internal/editor/DTreeEditor.java
@@ -24,8 +24,6 @@ import org.eclipse.core.runtime.Assert;
import org.eclipse.core.runtime.IPath;
import org.eclipse.core.runtime.IProgressMonitor;
import org.eclipse.core.runtime.NullProgressMonitor;
-import org.eclipse.core.runtime.preferences.IEclipsePreferences.IPreferenceChangeListener;
-import org.eclipse.core.runtime.preferences.InstanceScope;
import org.eclipse.emf.common.notify.AdapterFactory;
import org.eclipse.emf.common.ui.URIEditorInput;
import org.eclipse.emf.common.util.TreeIterator;
@@ -110,8 +108,6 @@ public class DTreeEditor extends AbstractDTreeEditor implements org.eclipse.siri
private DTree treeModel;
- private IPreferenceChangeListener viewPointPreferenceChangeListener;
-
/**
* {@inheritDoc}
*/
@@ -197,9 +193,6 @@ public class DTreeEditor extends AbstractDTreeEditor implements org.eclipse.siri
/* Update title. Semantic tree could have been renamed */
notify(PROP_TITLE);
- /* handle preferences */
- InstanceScope.INSTANCE.getNode(SiriusPlugin.ID).addPreferenceChangeListener(viewPointPreferenceChangeListener);
-
// Launch the refresh if needed
if (DialectManager.INSTANCE.isRefreshActivatedOnRepresentationOpening()) {
launchRefresh(true);
@@ -574,9 +567,6 @@ public class DTreeEditor extends AbstractDTreeEditor implements org.eclipse.siri
if (getAdapterFactory() instanceof IDisposable) {
((IDisposable) getAdapterFactory()).dispose();
}
-
- InstanceScope.INSTANCE.getNode(SiriusPlugin.ID).removePreferenceChangeListener(viewPointPreferenceChangeListener);
- viewPointPreferenceChangeListener = null;
}
/**

Back to the top