Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLaurent Redor2016-04-19 09:32:05 +0000
committerLaurent Redor2016-04-22 14:28:50 +0000
commit1aa0866554e951523c77e681c5cd18177bc668a6 (patch)
tree8161f691561521a888a57cb2829a88aff269605b
parentfc272903173652c4eba722c26aaecbe25198a610 (diff)
downloadorg.eclipse.sirius-1aa0866554e951523c77e681c5cd18177bc668a6.tar.gz
org.eclipse.sirius-1aa0866554e951523c77e681c5cd18177bc668a6.tar.xz
org.eclipse.sirius-1aa0866554e951523c77e681c5cd18177bc668a6.zip
[491913] Improve gradient quality for export with BMP format
Fix is done only by modifying DiagramEditPartService.saveToOutputStream(OutputStream, Image, ImageFileFormat, IProgressMonitor). Bug: 491913 Change-Id: Ic3084ca66836a3b3b0ac22ee03982ff205513c78 Signed-off-by: Laurent Redor <laurent.redor@obeo.fr>
-rw-r--r--plugins/org.eclipse.sirius.diagram.ui/src-diag/org/eclipse/sirius/diagram/ui/tools/api/part/DiagramEditPartService.java10
1 files changed, 8 insertions, 2 deletions
diff --git a/plugins/org.eclipse.sirius.diagram.ui/src-diag/org/eclipse/sirius/diagram/ui/tools/api/part/DiagramEditPartService.java b/plugins/org.eclipse.sirius.diagram.ui/src-diag/org/eclipse/sirius/diagram/ui/tools/api/part/DiagramEditPartService.java
index f6f3d4c2cf..fddcccf3ba 100644
--- a/plugins/org.eclipse.sirius.diagram.ui/src-diag/org/eclipse/sirius/diagram/ui/tools/api/part/DiagramEditPartService.java
+++ b/plugins/org.eclipse.sirius.diagram.ui/src-diag/org/eclipse/sirius/diagram/ui/tools/api/part/DiagramEditPartService.java
@@ -206,8 +206,14 @@ public class DiagramEditPartService extends org.eclipse.gmf.runtime.diagram.ui.r
monitor.worked(1);
ImageData imageData = image.getImageData();
-
- if (imageFormat.equals(ImageFileFormat.GIF) || imageFormat.equals(ImageFileFormat.BMP)) {
+ // In original CopyToImageUtil class, the reduction to a "8BitPalette"
+ // or a "WebSafePallette" is for GIF and BMP. For GIF file, it is
+ // explicitly constraint by the format characteristic and by an
+ // SWT.ERROR_UNSUPPORTED_DEPTH in
+ // org.eclipse.swt.internal.image.GIFFileFormat.unloadIntoByteStream(ImageLoader).
+ // But for BMP, there is no apparent reason so it is remove for this
+ // format.
+ if (imageFormat.equals(ImageFileFormat.GIF)) {
imageData = createImageData(image);
}

Back to the top