[472033] Do not draw the drop shadow of a detached figure

If a figure is removed from its parent, it will not be drawn so do not 
draw the drop shadow borders referencing it. 

Bug: 472033
Change-Id: Icd0cfb944e0374547cdf2b9e865913f2af7d7e58
Signed-off-by: Maxime Porhel <maxime.porhel@obeo.fr>

1 files changed, 4 insertions, 2 deletions

diff --git a/plugins/org.eclipse.sirius.diagram.ui/src-diag/org/eclipse/sirius/diagram/ui/tools/api/figure/AlphaDropShadowBorder.java b/plugins/org.eclipse.sirius.diagram.ui/src-diag/org/eclipse/sirius/diagram/ui/tools/api/figure/AlphaDropShadowBorder.java
index f61786c6aa..f0ca718c4b 100644
--- a/plugins/org.eclipse.sirius.diagram.ui/src-diag/org/eclipse/sirius/diagram/ui/tools/api/figure/AlphaDropShadowBorder.java
+++ b/plugins/org.eclipse.sirius.diagram.ui/src-diag/org/eclipse/sirius/diagram/ui/tools/api/figure/AlphaDropShadowBorder.java
@@ -56,10 +56,12 @@ public class AlphaDropShadowBorder extends AbstractBackground implements DropSha
         this.shape = shape;
     }
 
+    @Override
     public void setShouldDrawDropShadow(boolean drawDropShadow) {
         shouldDrawShadow = drawDropShadow;
     }
 
+    @Override
     public boolean shouldDrawDropShadow() {
         return shouldDrawShadow;
     }
@@ -81,6 +83,7 @@ public class AlphaDropShadowBorder extends AbstractBackground implements DropSha
         return insetsNew;
     }
 
+    @Override
     public Insets getTransparentInsets(IFigure figure) {
         Insets insetsNew = new Insets();
         insetsNew.top = 0;
@@ -92,7 +95,7 @@ public class AlphaDropShadowBorder extends AbstractBackground implements DropSha
 
     @Override
     public void paintBackground(IFigure figure, Graphics graphics, Insets insets) {
-        if (shouldDrawDropShadow()) {
+        if (shouldDrawDropShadow() && shape != null && shape.getParent() != null) {
             int ORIGINALALPHA = graphics.getAlpha();
             graphics.pushState();
             graphics.setBackgroundColor(SHADOW_COLOR);
@@ -121,7 +124,6 @@ public class AlphaDropShadowBorder extends AbstractBackground implements DropSha
             }
             graphics.setAlpha(ORIGINALALPHA);
             graphics.popState();
-
         }
     }
 }