Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorClaudio Guglielmo2021-04-19 11:21:20 +0000
committerClaudio Guglielmo2021-05-04 14:23:18 +0000
commitdf575c3e6e0d999f6d9bbbefaf8a896f3847cd81 (patch)
tree6c4d54c539d9d2d7de78e814fed66f7e4d3c9fb5
parent3dc2941eb733a538bd1dec070f7a0d537e4e6d1c (diff)
downloadorg.eclipse.scout.rt-df575c3e6e0d999f6d9bbbefaf8a896f3847cd81.tar.gz
org.eclipse.scout.rt-df575c3e6e0d999f6d9bbbefaf8a896f3847cd81.tar.xz
org.eclipse.scout.rt-df575c3e6e0d999f6d9bbbefaf8a896f3847cd81.zip
Icon.js: properties are not applied
Setting visible to false should hide the icon. This does not happen because the properties are rendered before the $container is created.
-rw-r--r--eclipse-scout-core/src/image/Icon.js9
1 files changed, 5 insertions, 4 deletions
diff --git a/eclipse-scout-core/src/image/Icon.js b/eclipse-scout-core/src/image/Icon.js
index ad38202a61..5ebe04c378 100644
--- a/eclipse-scout-core/src/image/Icon.js
+++ b/eclipse-scout-core/src/image/Icon.js
@@ -37,9 +37,8 @@ export default class Icon extends Widget {
this._setIconDesc(this.iconDesc);
}
- _renderProperties() {
- super._renderProperties();
- this._renderIconDesc();
+ _render() {
+ this._renderIconDesc(); // Must not be in _renderProperties because it creates $container -> properties like visible etc. need to be rendered afterwards
}
/**
@@ -64,7 +63,9 @@ export default class Icon extends Widget {
} else {
this._renderImageIcon();
}
-
+ if (!this.rendering) {
+ this._renderProperties();
+ }
this.invalidateLayoutTree();
}

Back to the top