Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorClaudio Guglielmo2021-05-07 14:13:57 +0000
committerClaudio Guglielmo2021-05-07 14:52:45 +0000
commit7f3ba8ba9ecd0e17b89cd00545a7b860040e3a5f (patch)
treeb00a47346ee93d449e409021cb14b0fab0e84e5f
parentbe7d822aad7f6295a1f43bb5eec0b043d3c8d86d (diff)
downloadorg.eclipse.scout.rt-7f3ba8ba9ecd0e17b89cd00545a7b860040e3a5f.tar.gz
org.eclipse.scout.rt-7f3ba8ba9ecd0e17b89cd00545a7b860040e3a5f.tar.xz
org.eclipse.scout.rt-7f3ba8ba9ecd0e17b89cd00545a7b860040e3a5f.zip
Table: pressing up/down in the filter should move the selection up/down
If the filter is empty, it works. If it is not empty, it has the class has-text which breaks the equals check. This functionality broke some versions ago (7.0).
-rw-r--r--eclipse-scout-core/src/table/keystrokes/AbstractTableNavigationKeyStroke.js6
-rw-r--r--eclipse-scout-core/src/table/keystrokes/TableFocusFilterFieldKeyStroke.js8
2 files changed, 7 insertions, 7 deletions
diff --git a/eclipse-scout-core/src/table/keystrokes/AbstractTableNavigationKeyStroke.js b/eclipse-scout-core/src/table/keystrokes/AbstractTableNavigationKeyStroke.js
index 01389b0435..25cd65dcef 100644
--- a/eclipse-scout-core/src/table/keystrokes/AbstractTableNavigationKeyStroke.js
+++ b/eclipse-scout-core/src/table/keystrokes/AbstractTableNavigationKeyStroke.js
@@ -31,9 +31,9 @@ export default class AbstractTableNavigationKeyStroke extends KeyStroke {
return false;
}
- var activeElement = this.field.$container.activeElement(true),
- elementType = activeElement.tagName.toLowerCase();
- if (activeElement.className !== 'table-text-filter' &&
+ var $activeElement = this.field.$container.activeElement();
+ var elementType = $activeElement[0].tagName.toLowerCase();
+ if (!$activeElement.hasClass('table-text-filter') &&
(elementType === 'textarea' || elementType === 'input') &&
(!event.originalEvent || (event.originalEvent && !event.originalEvent.smartFieldEvent))) {
return false;
diff --git a/eclipse-scout-core/src/table/keystrokes/TableFocusFilterFieldKeyStroke.js b/eclipse-scout-core/src/table/keystrokes/TableFocusFilterFieldKeyStroke.js
index d5aee4128d..db006a24c2 100644
--- a/eclipse-scout-core/src/table/keystrokes/TableFocusFilterFieldKeyStroke.js
+++ b/eclipse-scout-core/src/table/keystrokes/TableFocusFilterFieldKeyStroke.js
@@ -47,10 +47,10 @@ export default class TableFocusFilterFieldKeyStroke extends KeyStroke {
return false;
}
- var activeElement = this.field.$container.activeElement(true),
- activeElementType = activeElement.tagName.toLowerCase(),
- focusOnInputField = (activeElementType === 'textarea' || activeElementType === 'input');
- if (activeElement.className !== 'table-text-filter' || !focusOnInputField) {
+ var $activeElement = this.field.$container.activeElement();
+ var activeElementType = $activeElement[0].tagName.toLowerCase();
+ var focusOnInputField = (activeElementType === 'textarea' || activeElementType === 'input');
+ if (!$activeElement.hasClass('table-text-filter') || !focusOnInputField) {
event._$filterInput = $filterInput;
this._isKeyStrokeInRange(event);
return true;

Back to the top