Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBeat Schwarzentrub2018-11-23 12:58:24 +0000
committerBeat Schwarzentrub2018-11-23 13:08:05 +0000
commit06b7b93cbaa1d2bbc6b2d52a5f63f987c5c66e3c (patch)
tree5672eb79985c7313bf4010af36dd1b909108cdca
parentf00a310e9d24ec8ce246a69ad3f4c066c2f42f0f (diff)
downloadorg.eclipse.scout.rt-06b7b93cbaa1d2bbc6b2d52a5f63f987c5c66e3c.tar.gz
org.eclipse.scout.rt-06b7b93cbaa1d2bbc6b2d52a5f63f987c5c66e3c.tar.xz
org.eclipse.scout.rt-06b7b93cbaa1d2bbc6b2d52a5f63f987c5c66e3c.zip
JsonTileGrid: fix NPE in optTile()
Change-Id: Ia7a9e668dbe185b19d233d6d04f832403a4c6e39 Reviewed-on: https://git.eclipse.org/r/132966 Tested-by: CI Bot Reviewed-by: Beat Schwarzentrub <bsh@bsiag.com>
-rw-r--r--org.eclipse.scout.rt.ui.html/src/main/java/org/eclipse/scout/rt/ui/html/json/tile/JsonTileGrid.java10
1 files changed, 7 insertions, 3 deletions
diff --git a/org.eclipse.scout.rt.ui.html/src/main/java/org/eclipse/scout/rt/ui/html/json/tile/JsonTileGrid.java b/org.eclipse.scout.rt.ui.html/src/main/java/org/eclipse/scout/rt/ui/html/json/tile/JsonTileGrid.java
index b6ec3ff2ee..9bbc239d1d 100644
--- a/org.eclipse.scout.rt.ui.html/src/main/java/org/eclipse/scout/rt/ui/html/json/tile/JsonTileGrid.java
+++ b/org.eclipse.scout.rt.ui.html/src/main/java/org/eclipse/scout/rt/ui/html/json/tile/JsonTileGrid.java
@@ -241,7 +241,7 @@ public class JsonTileGrid<T extends ITileGrid<? extends ITile>> extends Abstract
return optTile(json.getString("tile"));
}
- private ITile getTile(String tileId) {
+ protected ITile getTile(String tileId) {
Object model = getUiSession().getJsonAdapter(tileId).getModel();
if (!(model instanceof ITile)) {
throw new IllegalStateException("Id does not belong to a tile. Id: " + tileId);
@@ -249,8 +249,12 @@ public class JsonTileGrid<T extends ITileGrid<? extends ITile>> extends Abstract
return (ITile) model;
}
- private ITile optTile(String tileId) {
- Object model = getUiSession().getJsonAdapter(tileId).getModel();
+ protected ITile optTile(String tileId) {
+ IJsonAdapter<?> adapter = getUiSession().getJsonAdapter(tileId);
+ if (adapter == null) {
+ return null;
+ }
+ Object model = adapter.getModel();
if (model == null) {
return null;
}

Back to the top