Bug 33184 - [Contributions] updating: Separator should return

isEnabled() == false

Change AbstractGroupMarker isEnabled to return true, as Group markers
(e.g. Separators) are not meant to be actionable.

Change-Id: I5a14fe62e8770ae02976cddb94f8b102bbaa8c8f
Signed-off-by: Robert Roth <robert.roth.off@gmail.com>

1 files changed, 14 insertions, 3 deletions

diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/action/AbstractGroupMarker.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/action/AbstractGroupMarker.java
index 13ca8835f69..691f73fbc2e 100644
--- a/bundles/org.eclipse.jface/src/org/eclipse/jface/action/AbstractGroupMarker.java
+++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/action/AbstractGroupMarker.java
@@ -7,6 +7,7 @@
  *
  * Contributors:
  *     IBM Corporation - initial API and implementation
+ *     Robert Roth <robert.roth.off@gmail.com> - bug 33184
  *******************************************************************************/
 package org.eclipse.jface.action;
 
@@ -48,11 +49,21 @@ public abstract class AbstractGroupMarker extends ContributionItem {
     }
 
     /**
-     * The <code>AbstractGroupMarker</code> implementation of this <code>IContributionItem</code>
-     * method returns <code>true</code> iff the id is not <code>null</code>. Subclasses may override.
+     * Always return <code>false</code> as group markers (including separators)
+     * are only there for visual separation, not meant to be actionable.
      */
     @Override
-	public boolean isGroupMarker() {
+    public boolean isEnabled() {
+        return false;
+    }
+
+    /**
+     * The <code>AbstractGroupMarker</code> implementation of this
+     * <code>IContributionItem</code> method returns <code>true</code> iff the
+     * id is not <code>null</code>. Subclasses may override.
+     */
+    @Override
+    public boolean isGroupMarker() {
         return getId() != null;
     }
 }