diff options
| author | Paul Webster | 2013-06-24 17:37:09 +0000 |
|---|---|---|
| committer | Paul Webster | 2013-06-24 17:37:09 +0000 |
| commit | f8df51502b1c801fd23198ad34123f0994633ce7 (patch) | |
| tree | c516487273452e89ee7cbf41f5a3ecd2bf2723ae | |
| parent | 628269f5e83dac8a5eea458d9997d1a96c83f614 (diff) | |
| download | eclipse.platform.ui-f8df51502b1c801fd23198ad34123f0994633ce7.tar.gz eclipse.platform.ui-f8df51502b1c801fd23198ad34123f0994633ce7.tar.xz eclipse.platform.ui-f8df51502b1c801fd23198ad34123f0994633ce7.zip | |
Bug 411465 - EditorPart#isSaveOnCloseNeeded() not called when closing
Editor Part
If the view is an ISaveablePart then it needs to be checked as well
| -rw-r--r-- | bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java index ccb2432b884..ff441baf938 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java @@ -1459,8 +1459,10 @@ public class WorkbenchPage extends CompatibleWorkbenchPage implements if (save) { if (workbenchPart instanceof ISaveablePart) { ISaveablePart saveablePart = (ISaveablePart) workbenchPart; - if (!saveSaveable(saveablePart, workbenchPart, confirm, true)) { - return false; + if (saveablePart.isSaveOnCloseNeeded()) { + if (!saveSaveable(saveablePart, workbenchPart, confirm, true)) { + return false; + } } } } |