Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTom Schindl2015-03-25 18:25:50 +0000
committerThomas Schindl2015-03-26 07:50:04 +0000
commitece1746f9356f6297cb2021284bc74ab2d2d3e7a (patch)
tree2aa7344a22e5ccc60585b6f4fab6b77744309f49
parent5f5655a94e574f0e4496f89a1506be82edd0ef2c (diff)
downloadeclipse.platform.ui-ece1746f9356f6297cb2021284bc74ab2d2d3e7a.tar.gz
eclipse.platform.ui-ece1746f9356f6297cb2021284bc74ab2d2d3e7a.tar.xz
eclipse.platform.ui-ece1746f9356f6297cb2021284bc74ab2d2d3e7a.zip
Bug 463125 - Error-Check for application without windows is done before
fragments have been merged Change-Id: I71a7c541830058d17f615367c94efd85286e9d8f
-rw-r--r--bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ResourceHandler.java13
1 files changed, 7 insertions, 6 deletions
diff --git a/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ResourceHandler.java b/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ResourceHandler.java
index 1ad46daed8f..285e149ff38 100644
--- a/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ResourceHandler.java
+++ b/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ResourceHandler.java
@@ -241,12 +241,6 @@ public class ResourceHandler implements IModelResourceHandler {
}
if (resource == null) {
Resource applicationResource = loadResource(applicationDefinitionInstance);
- if (!hasTopLevelWindows(applicationResource) && logger != null) {
- logger.error(
- new Exception(), // log a stack trace to help debug the corruption
- "Initializing from the application definition instance yields no top-level windows! " //$NON-NLS-1$
- + "Continuing execution, but the missing windows may cause other initialization failures."); //$NON-NLS-1$
- }
MApplication theApp = (MApplication) applicationResource.getContents().get(0);
resource = createResourceWithApp(theApp);
context.set(E4Workbench.NO_SAVED_MODEL_FOUND, Boolean.TRUE);
@@ -264,6 +258,13 @@ public class ResourceHandler implements IModelResourceHandler {
context);
contribProcessor.processModel(initialModel);
+ if (!hasTopLevelWindows(resource) && logger != null) {
+ logger.error(new Exception(), // log a stack trace to help debug the
+ // corruption
+ "Initializing from the application definition instance yields no top-level windows! " //$NON-NLS-1$
+ + "Continuing execution, but the missing windows may cause other initialization failures."); //$NON-NLS-1$
+ }
+
if (!clearPersistedState) {
CommandLineOptionModelProcessor processor = ContextInjectionFactory.make(
CommandLineOptionModelProcessor.class, context);

Back to the top