diff options
| author | Alexander Kurtakov | 2020-10-08 10:36:09 +0000 |
|---|---|---|
| committer | Alexander Kurtakov | 2020-10-09 08:33:19 +0000 |
| commit | e5a546395dc5497ae2e055746c6160aee87b899a (patch) | |
| tree | dc1ee9a4d5aaf14f8a6716ea0d265055fc92a04b | |
| parent | b7023e20c55f83903836d6a49e9bdd25516c7eef (diff) | |
| download | eclipse.platform.ui-e5a546395dc5497ae2e055746c6160aee87b899a.tar.gz eclipse.platform.ui-e5a546395dc5497ae2e055746c6160aee87b899a.tar.xz eclipse.platform.ui-e5a546395dc5497ae2e055746c6160aee87b899a.zip | |
Bug 567707 - Propose restart on enable/disable themingY20201012-1200Y20201011-1200Y20201010-1200Y20201009-1200I20201012-1800I20201012-0750I20201011-1800I20201010-1800I20201009-1800I20201009-0800
Restart is needed not only when theme is changed but when theming engine
is enabled/disable too.
Change-Id: I4dfe173f6e2c1684e194d367ffae58ac488aea3a
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2 files changed, 9 insertions, 1 deletions
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java index f6d22685a26..08454c0fbc0 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java @@ -270,7 +270,10 @@ public class ViewsPreferencePage extends PreferencePage implements IWorkbenchPre IEclipsePreferences prefs = getSwtRendererPreferences(); prefs.putBoolean(StackRenderer.MRU_KEY, enableMru.getSelection()); + boolean themingEnabledChanged = prefs.getBoolean(PartRenderingEngine.ENABLED_THEME_KEY, true) != themingEnabled + .getSelection(); prefs.putBoolean(PartRenderingEngine.ENABLED_THEME_KEY, themingEnabled.getSelection()); + prefs.putBoolean(CTabRendering.USE_ROUND_TABS, useRoundTabs.getSelection()); try { prefs.flush(); @@ -302,6 +305,11 @@ public class ViewsPreferencePage extends PreferencePage implements IWorkbenchPre notificationPopUp.open(); } } + } else if (themingEnabledChanged) { + if (notificationPopUp == null) { + notificationPopUp = new NotificationPopUp(getShell().getDisplay()); + notificationPopUp.open(); + } } return super.performOk(); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/messages.properties b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/messages.properties index 11f56a6c851..d5624e9813e 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/messages.properties +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/messages.properties @@ -493,7 +493,7 @@ OpenPerspectiveDialogAction_tooltip=Open Perspective #---- General Preferences---- PreferencePage_noDescription = (No description available) PreferencePageParameterValues_pageLabelSeparator = \ >\ -ThemingEnabled = E&nable theming (requires restart) +ThemingEnabled = E&nable theming ThemeChangeWarningText = A <a>restart</a> is required for the theme change to take full effect. ThemeChangeWarningTitle = Theme change # --- Workbench ----- |