Bug 401709: Secondary Problems view doesn't have a view menu -> not configurable

2 files changed, 13 insertions, 3 deletions

diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java
index 488e5390bb4..c2f62e9a1c6 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java
@@ -1897,10 +1897,11 @@ public class WorkbenchPage extends CompatibleWorkbenchPage implements
 		for (IViewReference reference : getViewReferences()) {
 			// If the id contains a ':' use the part before it as the descriptor
 			// id
-			int colonIndex = reference.getId().indexOf(':');
-			String descId = colonIndex == -1 ? viewId : viewId.substring(0, colonIndex);
+			String referenceId = reference.getId();
+			int colonIndex = referenceId.indexOf(':');
+			String descId = colonIndex == -1 ? referenceId : referenceId.substring(0, colonIndex);
 
-			if (descId.equals(reference.getId())) {
+			if (viewId.equals(descId)) {
 				String refSecondaryId = reference.getSecondaryId();
 				if (refSecondaryId == null) {
 					if (secondaryId == null) {
diff --git a/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/api/IWorkbenchPageTest.java b/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/api/IWorkbenchPageTest.java
index 7610c2e48d7..498c7bc3883 100644
--- a/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/api/IWorkbenchPageTest.java
+++ b/tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/api/IWorkbenchPageTest.java
@@ -1080,6 +1080,15 @@ public class IWorkbenchPageTest extends UITestCase {
 		assertNotNull(fActivePage.findViewReference(MockViewPart.ID4));
 	}
 
+	public void testFindSecondaryViewReference() throws Throwable {
+		fActivePage.getWorkbenchWindow().getWorkbench().showPerspective(
+				SessionPerspective.ID, fActivePage.getWorkbenchWindow());
+		assertNull(fActivePage.findViewReference(MockViewPart.IDMULT, "1"));
+		
+		fActivePage.showView(MockViewPart.IDMULT, "1", IWorkbenchPage.VIEW_ACTIVATE);
+		assertNotNull(fActivePage.findViewReference(MockViewPart.IDMULT, "1"));
+	}
+	
 	public void testGetViews() throws Throwable {
 		int totalBefore = fActivePage.getViewReferences().length;