Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Vogel2017-06-07 20:25:56 +0000
committerLars Vogel2017-06-09 08:49:48 +0000
commita2def5476b0222c7fee40a304fee36f0d29119ee (patch)
tree21b3b9c73ffe633ceb2f0156129fa60ebbd151b8
parent4f965f6f086f9171a36e4cbea09d5c7715f93c7d (diff)
downloadeclipse.platform.ui-a2def5476b0222c7fee40a304fee36f0d29119ee.tar.gz
eclipse.platform.ui-a2def5476b0222c7fee40a304fee36f0d29119ee.tar.xz
eclipse.platform.ui-a2def5476b0222c7fee40a304fee36f0d29119ee.zip
Bug 516530 - Use StringBuilder instead of StringBuffer - Part 1
Change-Id: Ifc352bac79ee24b0f1ac99ef4fa31cf30593de14 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
Diffstat
-rw-r--r--bundles/org.eclipse.e4.ui.bindings/src/org/eclipse/e4/ui/bindings/internal/Util.java4
-rw-r--r--bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/AbstractCSSPropertyHandlerProvider.java2
-rw-r--r--bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/CSSPropertyHandlerLazyProviderImpl.java6
-rw-r--r--bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/CSSPropertyHandlerSimpleProviderImpl.java4
-rw-r--r--bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/dom/CSSPropertyListImpl.java2
-rw-r--r--bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/dom/CSSValueListImpl.java2
-rw-r--r--bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/engine/RegistryCSSPropertyHandlerProvider.java6
-rw-r--r--bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/utils/StringUtils.java4
8 files changed, 15 insertions, 15 deletions
diff --git a/bundles/org.eclipse.e4.ui.bindings/src/org/eclipse/e4/ui/bindings/internal/Util.java b/bundles/org.eclipse.e4.ui.bindings/src/org/eclipse/e4/ui/bindings/internal/Util.java
index 80a007d1a13..defc4c1cae4 100644
--- a/bundles/org.eclipse.e4.ui.bindings/src/org/eclipse/e4/ui/bindings/internal/Util.java
+++ b/bundles/org.eclipse.e4.ui.bindings/src/org/eclipse/e4/ui/bindings/internal/Util.java
@@ -378,7 +378,7 @@ public final class Util {
return "null"; //$NON-NLS-1$
}
- final StringBuffer buffer = new StringBuffer();
+ final StringBuilder buffer = new StringBuilder();
buffer.append('[');
final int length = array.length;
@@ -445,7 +445,7 @@ public final class Util {
return src;
}
- StringBuffer buf = new StringBuffer();
+ StringBuilder buf = new StringBuilder();
int beginIndex = 0;
while (idx != -1 && idx < len) {
buf.append(src.substring(beginIndex, idx));
diff --git a/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/AbstractCSSPropertyHandlerProvider.java b/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/AbstractCSSPropertyHandlerProvider.java
index 6b76b2e410b..18e78b8d103 100644
--- a/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/AbstractCSSPropertyHandlerProvider.java
+++ b/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/AbstractCSSPropertyHandlerProvider.java
@@ -54,7 +54,7 @@ public abstract class AbstractCSSPropertyHandlerProvider implements
if (propertyValue == null) {
return null;
}
- StringBuffer style = new StringBuffer();
+ StringBuilder style = new StringBuilder();
style.append(propertyName);
style.append(":");
style.append(propertyValue);
diff --git a/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/CSSPropertyHandlerLazyProviderImpl.java b/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/CSSPropertyHandlerLazyProviderImpl.java
index 97ac83d6c46..8e4c75a2d45 100644
--- a/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/CSSPropertyHandlerLazyProviderImpl.java
+++ b/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/CSSPropertyHandlerLazyProviderImpl.java
@@ -150,7 +150,7 @@ public class CSSPropertyHandlerLazyProviderImpl extends
if (stylableElement.getDefaultStyleDeclaration(pseudoE) != null)
return stylableElement.getDefaultStyleDeclaration(pseudoE);
if (newStyle != null) {
- StringBuffer style = null;
+ StringBuilder style = null;
int length = newStyle.getLength();
for (int i = 0; i < length; i++) {
String propertyName = newStyle.item(i);
@@ -163,7 +163,7 @@ public class CSSPropertyHandlerLazyProviderImpl extends
propertyName, pseudoE);
if (s != null) {
if (style == null)
- style = new StringBuffer();
+ style = new StringBuilder();
style.append(s);
}
}
@@ -172,7 +172,7 @@ public class CSSPropertyHandlerLazyProviderImpl extends
propertyName, pseudoE);
if (s != null) {
if (style == null)
- style = new StringBuffer();
+ style = new StringBuilder();
style.append(s);
}
}
diff --git a/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/CSSPropertyHandlerSimpleProviderImpl.java b/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/CSSPropertyHandlerSimpleProviderImpl.java
index 04f663d8bb7..2741cf1c6f8 100644
--- a/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/CSSPropertyHandlerSimpleProviderImpl.java
+++ b/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/dom/properties/providers/CSSPropertyHandlerSimpleProviderImpl.java
@@ -247,14 +247,14 @@ public class CSSPropertyHandlerSimpleProviderImpl extends
return defaultStyleDeclaration;
// Default style must be computed.
- StringBuffer style = null;
+ StringBuilder style = null;
Collection<String> propertyNames = getAllCSSPropertyNames();
for (String propertyName : propertyNames) {
String s = getCSSPropertyStyle(engine, stylableElement,
propertyName, pseudoE);
if (s != null) {
if (style == null)
- style = new StringBuffer();
+ style = new StringBuilder();
style.append(s);
}
}
diff --git a/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/dom/CSSPropertyListImpl.java b/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/dom/CSSPropertyListImpl.java
index 15afefbe3ad..25fb7b34bdd 100644
--- a/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/dom/CSSPropertyListImpl.java
+++ b/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/dom/CSSPropertyListImpl.java
@@ -73,7 +73,7 @@ public class CSSPropertyListImpl implements CSSPropertyList {
@Override
public String toString() {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
for (int i = 0; i < getLength(); i++) {
sb.append(item(i).toString()).append("\r\n");
}
diff --git a/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/dom/CSSValueListImpl.java b/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/dom/CSSValueListImpl.java
index 600c32913a7..619d4370c89 100644
--- a/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/dom/CSSValueListImpl.java
+++ b/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/dom/CSSValueListImpl.java
@@ -64,7 +64,7 @@ public class CSSValueListImpl extends AbstractCSSNode implements CSSValueList {
@Override
public String toString() {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
for (CSSValue cssValue : values) {
sb.append(cssValue.getCssText() + "\n");
}
diff --git a/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/engine/RegistryCSSPropertyHandlerProvider.java b/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/engine/RegistryCSSPropertyHandlerProvider.java
index 911c94d5c5a..8b207f32fe7 100644
--- a/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/engine/RegistryCSSPropertyHandlerProvider.java
+++ b/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/engine/RegistryCSSPropertyHandlerProvider.java
@@ -159,7 +159,7 @@ public class RegistryCSSPropertyHandlerProvider extends
if (stylableElement.getDefaultStyleDeclaration(pseudoE) != null)
return stylableElement.getDefaultStyleDeclaration(pseudoE);
if (newStyle != null) {
- StringBuffer style = null;
+ StringBuilder style = null;
int length = newStyle.getLength();
for (int i = 0; i < length; i++) {
String propertyName = newStyle.item(i);
@@ -172,7 +172,7 @@ public class RegistryCSSPropertyHandlerProvider extends
propertyName, pseudoE);
if (s != null) {
if (style == null)
- style = new StringBuffer();
+ style = new StringBuilder();
style.append(s);
}
}
@@ -181,7 +181,7 @@ public class RegistryCSSPropertyHandlerProvider extends
propertyName, pseudoE);
if (s != null) {
if (style == null)
- style = new StringBuffer();
+ style = new StringBuilder();
style.append(s);
}
}
diff --git a/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/utils/StringUtils.java b/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/utils/StringUtils.java
index 95297ac2e60..33bb091d746 100644
--- a/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/utils/StringUtils.java
+++ b/bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/utils/StringUtils.java
@@ -35,7 +35,7 @@ public class StringUtils {
char line2[] = line.toCharArray();
char newString2[] = newString.toCharArray();
int oLength = oldString.length();
- StringBuffer buf = new StringBuffer(line2.length);
+ StringBuilder buf = new StringBuilder(line2.length);
buf.append(line2, 0, i).append(newString2);
i += oLength;
int j;
@@ -152,7 +152,7 @@ public class StringUtils {
return str;
}
int strLen = str.length();
- StringBuffer buffer = new StringBuffer(strLen);
+ StringBuilder buffer = new StringBuilder(strLen);
boolean capitalizeNext = true;
for (int i = 0; i < strLen; i++) {
char ch = str.charAt(i);

Back to the top