diff options
| author | Lars Vogel | 2020-06-05 16:39:15 +0000 |
|---|---|---|
| committer | Lars Vogel | 2020-06-09 16:01:31 +0000 |
| commit | 845b2367d92f0be651256ff37d897e28a2f99288 (patch) | |
| tree | a600a315f86d68382047db7dc9bbd3ca99aa4013 | |
| parent | f739c41ad232714536979ba6a434914324a6b6e5 (diff) | |
| download | eclipse.platform.ui-845b2367d92f0be651256ff37d897e28a2f99288.tar.gz eclipse.platform.ui-845b2367d92f0be651256ff37d897e28a2f99288.tar.xz eclipse.platform.ui-845b2367d92f0be651256ff37d897e28a2f99288.zip | |
Bug 564063 - Using ArrayContentProvider.getInstance() instead of new instance
ArrayContentProvider does not hold any data, hence it can be shared
across instances.
Change-Id: I1788968c5befeec33dab975d93cf8a82bc32dc95
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2 files changed, 2 insertions, 2 deletions
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/SaveablesList.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/SaveablesList.java index 1f2681e946c..581d4b22160 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/SaveablesList.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/SaveablesList.java @@ -773,7 +773,7 @@ public class SaveablesList implements ISaveablesLifecycleListener { } } else { MyListSelectionDialog dlg = new MyListSelectionDialog(shellProvider.getShell(), modelsToSave, - new ArrayContentProvider(), new WorkbenchPartLabelProvider(), + ArrayContentProvider.getInstance(), new WorkbenchPartLabelProvider(), stillOpenElsewhere ? WorkbenchMessages.EditorManager_saveResourcesOptionallyMessage : WorkbenchMessages.EditorManager_saveResourcesMessage, canCancel, stillOpenElsewhere); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkingSetSelectionDialog.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkingSetSelectionDialog.java index 42c068533c9..77dc74ea0fc 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkingSetSelectionDialog.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkingSetSelectionDialog.java @@ -95,7 +95,7 @@ public class WorkingSetSelectionDialog extends AbstractWorkingSetDialog { super(parentShell, workingSetIds, true); initWorkbenchWindow(); - contentProvider = new ArrayContentProvider(); + contentProvider = ArrayContentProvider.getInstance(); labelProvider = new WorkingSetLabelProvider(); multiSelect = multi; if (multiSelect) { |