Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Vogel2014-04-23 19:35:00 +0000
committerLars Vogel2014-04-23 19:41:32 +0000
commit822529afe037f0f0cedd1407584f5990e2a4e997 (patch)
treebabd85d9c449b8138896d090cdadf0dcdfd0376d
parent180bfe91ed54da388ebd2182924c2c04a767ce98 (diff)
downloadeclipse.platform.ui-822529afe037f0f0cedd1407584f5990e2a4e997.tar.gz
eclipse.platform.ui-822529afe037f0f0cedd1407584f5990e2a4e997.tar.xz
eclipse.platform.ui-822529afe037f0f0cedd1407584f5990e2a4e997.zip
Bug 433336 - Use boolean primitives in ModelAssembler.runProcessors()
method Change-Id: I2ff8934a87d4e6ecedcbb44a1561209021cb0a03 Signed-off-by: Lars Vogel <Lars.Vogel@gmail.com>
-rw-r--r--bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelAssembler.java8
1 files changed, 4 insertions, 4 deletions
diff --git a/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelAssembler.java b/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelAssembler.java
index 2cfc4574bf3..49b067431e1 100644
--- a/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelAssembler.java
+++ b/bundles/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelAssembler.java
@@ -7,7 +7,7 @@
*
* Contributors:
* Tom Schindl<tom.schindl@bestsolution.at> - initial API and implementation
- * Lars Vogel <Lars.Vogel@gmail.com> - Bug 430075, 430080, 431464
+ * Lars Vogel <Lars.Vogel@gmail.com> - Bug 430075, 430080, 431464, 433336
* René Brandstetter - Bug 419749 - [Workbench] [e4 Workbench] - Remove the deprecated PackageAdmin
* Brian de Alwis (MTI) - Bug 433053
******************************************************************************/
@@ -214,13 +214,13 @@ public class ModelAssembler {
* @param extensions
* @param afterFragments
*/
- private void runProcessors(IExtension[] extensions, boolean initial, Boolean afterFragments) {
+ private void runProcessors(IExtension[] extensions, boolean initial, boolean afterFragments) {
for (IExtension extension : extensions) {
IConfigurationElement[] ces = extension.getConfigurationElements();
for (IConfigurationElement ce : ces) {
boolean parseBoolean = Boolean.parseBoolean(ce.getAttribute("beforefragment")); //$NON-NLS-1$
- if ("processor".equals(ce.getName()) && !afterFragments.equals(parseBoolean)) { //$NON-NLS-1$
- if (initial || !INITIAL.equals(ce.getAttribute("apply"))) { //$NON-NLS-1$
+ if ("processor".equals(ce.getName()) && afterFragments == parseBoolean) { //$NON-NLS-1$
+ if (initial || !INITIAL.equals(ce.getAttribute("apply"))) { //$NON-NLS-1$
runProcessor(ce);
}
}

Back to the top