Bug 464153: External web browser parameters are not updated after change on preference page

2 files changed, 8 insertions, 2 deletions

diff --git a/bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/browsers/MozillaBrowser.java b/bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/browsers/MozillaBrowser.java
index 0dd97b2323d..b883e3e07bd 100644
--- a/bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/browsers/MozillaBrowser.java
+++ b/bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/browsers/MozillaBrowser.java
@@ -59,6 +59,10 @@ public class MozillaBrowser extends AbstractWebBrowser {
 		return executable;
 	}
 
+	String getParameters() {
+		return parameters;
+	}
+
 	@Override
 	public void openURL(URL url2) {
 		String url = null;
diff --git a/bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/browsers/MozillaFactory.java b/bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/browsers/MozillaFactory.java
index cc2bdb00563..953de63ac3e 100644
--- a/bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/browsers/MozillaFactory.java
+++ b/bundles/org.eclipse.ui.browser/src/org/eclipse/ui/internal/browser/browsers/MozillaFactory.java
@@ -48,7 +48,7 @@ public class MozillaFactory extends BrowserFactory {
 		}
 	}*/
 
-	/**
+	/*
 	 * On some OSes 0 is always returned by "which" command it is necessary to
 	 * examine ouput to find out failure.
 	 *
@@ -81,7 +81,9 @@ public class MozillaFactory extends BrowserFactory {
 	@Override
 	public IWebBrowser createBrowser(String id, String location, String parameters) {
 		// Create single browser for all clients
-		if (browserInstance == null || !browserInstance.getExecutable().equals(location)) {
+		if (browserInstance == null
+				|| !browserInstance.getExecutable().equals(location)
+				|| !browserInstance.getParameters().equals(parameters)) {
 			browserInstance = new MozillaBrowser(id, location, parameters);
 		}
 		return browserInstance;