Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTill Brychcy2019-02-21 07:52:05 +0000
committerLakshmi Shanmugam2019-02-23 12:54:59 +0000
commit6d90c60abee2b10c79a55d404cb75d876e0c5e01 (patch)
tree54dd0763bcb4c4839d7f4e132cfba8b280d18bff
parentcedc75933b05d2f133b9ae67672e853201d276fc (diff)
downloadeclipse.platform.ui-6d90c60abee2b10c79a55d404cb75d876e0c5e01.tar.gz
eclipse.platform.ui-6d90c60abee2b10c79a55d404cb75d876e0c5e01.tar.xz
eclipse.platform.ui-6d90c60abee2b10c79a55d404cb75d876e0c5e01.zip
Bug 544606 - Disabled button text not visible in dark theme on MacI20190223-1800
-rw-r--r--bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/properties/css2/CSSPropertyTextSWTHandler.java4
-rw-r--r--bundles/org.eclipse.ui.themes/css/e4-dark_mac.css1
2 files changed, 3 insertions, 2 deletions
diff --git a/bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/properties/css2/CSSPropertyTextSWTHandler.java b/bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/properties/css2/CSSPropertyTextSWTHandler.java
index f09d1ef5370..2708cdd5e50 100644
--- a/bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/properties/css2/CSSPropertyTextSWTHandler.java
+++ b/bundles/org.eclipse.e4.ui.css.swt/src/org/eclipse/e4/ui/css/swt/properties/css2/CSSPropertyTextSWTHandler.java
@@ -1,5 +1,5 @@
/*******************************************************************************
- * Copyright (c) 2008, 2014 Angelo Zerr and others.
+ * Copyright (c) 2008, 2019 Angelo Zerr and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
@@ -64,7 +64,7 @@ public class CSSPropertyTextSWTHandler extends AbstractCSSPropertyTextHandler {
if (value.getCssValueType() == CSSValue.CSS_PRIMITIVE_VALUE) {
Color newColor = (Color) engine.convert(value, Color.class, widget
.getDisplay());
- if (newColor == null || newColor.isDisposed()) {
+ if (newColor != null && newColor.isDisposed()) {
return;
}
diff --git a/bundles/org.eclipse.ui.themes/css/e4-dark_mac.css b/bundles/org.eclipse.ui.themes/css/e4-dark_mac.css
index 7aa077dd435..6d48d2ca32e 100644
--- a/bundles/org.eclipse.ui.themes/css/e4-dark_mac.css
+++ b/bundles/org.eclipse.ui.themes/css/e4-dark_mac.css
@@ -202,5 +202,6 @@ Form > LayoutComposite > LayoutComposite > Button,
.MPart LayoutComposite > * > LayoutComposite > Section > LayoutComposite > Button,
.MPartStack.active .MPart LayoutComposite > * > LayoutComposite > Section > LayoutComposite > Button {
background-color: unset;
+ color: unset;
}

Back to the top