Bug 572711 - Use requestlayout in LazyStackRenderer

In LazyStackRenderer.showElementRecursive shared elements are re-parented to a new parent composite in a CTabFolder. A comment indicated that calling layout is too expensive, instead setSize was called.

This commit switches this to calling requestlayout that should be even less expensive. The effect is visible when switching perspectives.

Change-Id: Ic52c8e13ced5bbdf527cbecc2f594381cced5bcd
Signed-off-by: Rolf Theunissen <rolf.theunissen@gmail.com>

1 files changed, 1 insertions, 5 deletions

diff --git a/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/LazyStackRenderer.java b/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/LazyStackRenderer.java
index fd935c8e4f5..70ae7a7abd3 100644
--- a/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/LazyStackRenderer.java
+++ b/bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/LazyStackRenderer.java
@@ -291,13 +291,9 @@ public abstract class LazyStackRenderer extends SWTPartRenderer {
 			Composite phComp = (Composite) ph.getWidget();
 			Control refCtrl = (Control) ph.getRef().getWidget();
 
-			// If the parent changes we need to adjust the bounds of the child
-			// we do not call layout() because this could lead to
-			// a big amount of layout calls in unrelated places e.g. none
-			// visible children of a CTabFolder (see 460745)
 			if (refCtrl != null && refCtrl.getParent() != phComp) {
 				refCtrl.setParent(phComp);
-				refCtrl.setSize(phComp.getSize());
+				refCtrl.requestLayout();
 			}
 
 			element = ref;