Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Webster2013-05-15 17:07:34 +0000
committerPaul Webster2013-05-15 17:07:34 +0000
commit3d6eeeb2857cc8b1bc5fb407e65ed250a892f28f (patch)
tree7ae8c06ff1db559323557c8819f58e678073c5fa
parent8cc5a361955d563dc4a90d6be58efce386e01779 (diff)
downloadeclipse.platform.ui-3d6eeeb2857cc8b1bc5fb407e65ed250a892f28f.tar.gz
eclipse.platform.ui-3d6eeeb2857cc8b1bc5fb407e65ed250a892f28f.tar.xz
eclipse.platform.ui-3d6eeeb2857cc8b1bc5fb407e65ed250a892f28f.zip
Revert "Bug 402429 - hiddenToolBarItem perspective extension does not react to"
-rw-r--r--bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CoolBarToTrimManager.java24
1 files changed, 5 insertions, 19 deletions
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CoolBarToTrimManager.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CoolBarToTrimManager.java
index 43063c2f15e..632db2b0a1d 100644
--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CoolBarToTrimManager.java
+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CoolBarToTrimManager.java
@@ -1,5 +1,5 @@
/*******************************************************************************
- * Copyright (c) 2011, 2013 IBM Corporation and others.
+ * Copyright (c) 2011, 2012 IBM Corporation and others.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Eclipse Public License v1.0
* which accompanies this distribution, and is available at
@@ -704,10 +704,12 @@ public class CoolBarToTrimManager extends ContributionManager implements ICoolBa
container, null);
for (IContributionItem item : manager.getItems()) {
- if (item == null || !isChildVisible(item)) {
+ if (item == null) {
+ continue;
+ }
+ if (renderer.getToolElement(item) != null) {
continue;
}
-
if (item instanceof IToolBarContributionItem) {
IToolBarManager manager2 = ((IToolBarContributionItem) item).getToolBarManager();
//new Exception("fill(MToolBar container, IContributionManager manager) with " //$NON-NLS-1$
@@ -736,20 +738,4 @@ public class CoolBarToTrimManager extends ContributionManager implements ICoolBa
}
}
}
-
- private boolean isChildVisible(IContributionItem item) {
- Boolean v;
-
- IContributionManagerOverrides overrides = getOverrides();
- if (overrides == null) {
- v = null;
- } else {
- v = getOverrides().getVisible(item);
- }
-
- if (v != null) {
- return v.booleanValue();
- }
- return item.isVisible();
- }
}

Back to the top