diff options
| author | Andrey Loskutov | 2015-02-08 20:28:06 +0000 |
|---|---|---|
| committer | Wojciech Sudol | 2015-04-13 15:15:06 +0000 |
| commit | 34f01a490d31a8591bf4a053d3be7192c1bb9972 (patch) | |
| tree | f78ddcfaac8dcab77c3c1d0bd4d60d3bc7cfaf71 | |
| parent | 48c65fb0010f4f9e1f0e6bdc28e3eb3938bea6ea (diff) | |
| download | eclipse.platform.ui-34f01a490d31a8591bf4a053d3be7192c1bb9972.tar.gz eclipse.platform.ui-34f01a490d31a8591bf4a053d3be7192c1bb9972.tar.xz eclipse.platform.ui-34f01a490d31a8591bf4a053d3be7192c1bb9972.zip | |
Bug 413329 - NPE in CustomizePerspectiveDialog in createMenuEntries
Don't create menu entries for if contribution item is missing.
Change-Id: Icfbe5d60c814d03032552a1ff28598662466b072
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
| -rw-r--r-- | bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizePerspectiveDialog.java | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizePerspectiveDialog.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizePerspectiveDialog.java index a14cfdaacd0..e390df1ab50 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizePerspectiveDialog.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/CustomizePerspectiveDialog.java @@ -1944,6 +1944,9 @@ public class CustomizePerspectiveDialog extends TrayDialog { } else { contributionItem = menuMngrRenderer.getContribution(menuItem); } + if (contributionItem == null) { + return dynamicEntry; + } if (dynamicEntry != null && contributionItem.equals(dynamicEntry.getIContributionItem())) { // If the last item added is the item meant to go before the |