diff options
| author | Lars Vogel | 2020-07-21 09:13:04 +0000 |
|---|---|---|
| committer | Lars Vogel | 2020-07-22 07:50:44 +0000 |
| commit | 2cad088ee37df98a0caed5e24593406f797ea416 (patch) | |
| tree | f82e7fa3e9e515fae5572488600480f4d1b9fc4b | |
| parent | 4034449d77608bd3cddf97230ede965c39c21145 (diff) | |
| download | eclipse.platform.ui-2cad088ee37df98a0caed5e24593406f797ea416.tar.gz eclipse.platform.ui-2cad088ee37df98a0caed5e24593406f797ea416.tar.xz eclipse.platform.ui-2cad088ee37df98a0caed5e24593406f797ea416.zip | |
Bug 565208: Remove calls to Color.dispose
Removes unnecessary field from ColorSelector
Change-Id: Id6076ef715c17d75fd47910d58e306948a3cea09
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
| -rw-r--r-- | bundles/org.eclipse.jface/src/org/eclipse/jface/preference/ColorSelector.java | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/preference/ColorSelector.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/preference/ColorSelector.java index 873360b7599..f7b4425bcf8 100644 --- a/bundles/org.eclipse.jface/src/org/eclipse/jface/preference/ColorSelector.java +++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/preference/ColorSelector.java @@ -49,8 +49,6 @@ public class ColorSelector extends EventManager { private Button fButton; - private Color fColor; - private RGB fColorValue; private Point fExtent; @@ -177,11 +175,8 @@ public class ColorSelector extends EventManager { protected void updateColorImage() { Display display = fButton.getDisplay(); GC gc = new GC(fImage); - if (fColor != null) { - fColor.dispose(); - } - fColor = new Color(display, fColorValue); - gc.setBackground(fColor); + Color color = new Color(display, fColorValue); + gc.setBackground(color); gc.fillRectangle(1, 1, fExtent.x - 2, fExtent.y - 2); gc.dispose(); fButton.setImage(fImage); |