diff options
| author | Lars Vogel | 2017-05-11 19:16:33 +0000 |
|---|---|---|
| committer | Alexander Kurtakov | 2017-07-03 18:36:57 +0000 |
| commit | 10e998f40b0111726cf2825cf6876d59d5f47025 (patch) | |
| tree | f9f25a5df2a79f334ffa28536c873e787ceaacee | |
| parent | da2e408f6ecdeb2019c2298b4372097d60dc7c92 (diff) | |
| download | eclipse.platform.ui-10e998f40b0111726cf2825cf6876d59d5f47025.tar.gz eclipse.platform.ui-10e998f40b0111726cf2825cf6876d59d5f47025.tar.xz eclipse.platform.ui-10e998f40b0111726cf2825cf6876d59d5f47025.zip | |
Bug 516530 - Use StringBuilder instead of StringBuffer - Part 6
Change-Id: I0827afdb5f362db9fa74951cbfe9ba91959556cb
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
69 files changed, 82 insertions, 82 deletions
diff --git a/bundles/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/CopyPropertyAction.java b/bundles/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/CopyPropertyAction.java index 8f3fd4ebdb2..fe1d2f21316 100644 --- a/bundles/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/CopyPropertyAction.java +++ b/bundles/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/CopyPropertyAction.java @@ -61,7 +61,7 @@ import org.eclipse.ui.internal.views.properties.PropertiesMessages; .getFirstElement(); // Place text on the clipboard - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(entry.getDisplayName()); buffer.append("\t"); //$NON-NLS-1$ buffer.append(entry.getValueAsString()); diff --git a/bundles/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/PropertySheetPage.java b/bundles/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/PropertySheetPage.java index 1c8b0483fa7..35b0ce3869a 100644 --- a/bundles/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/PropertySheetPage.java +++ b/bundles/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/PropertySheetPage.java @@ -442,7 +442,7 @@ public class PropertySheetPage extends Page implements IPropertySheetPage, IAdap .getFirstElement(); // Place text as the data - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(entry.getDisplayName()); buffer.append("\t"); //$NON-NLS-1$ buffer.append(entry.getValueAsString()); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/ActiveShellExpression.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/ActiveShellExpression.java index d3dde654d37..a854a102994 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/ActiveShellExpression.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/ActiveShellExpression.java @@ -118,7 +118,7 @@ public final class ActiveShellExpression extends Expression { @Override public final String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("ActiveShellExpression("); //$NON-NLS-1$ buffer.append(activeShell); buffer.append(')'); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/LegacyHandlerSubmissionExpression.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/LegacyHandlerSubmissionExpression.java index dc847e2fe91..4f7019a7374 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/LegacyHandlerSubmissionExpression.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/LegacyHandlerSubmissionExpression.java @@ -163,7 +163,7 @@ public final class LegacyHandlerSubmissionExpression extends Expression { @Override public final String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("LegacyHandlerSubmission("); //$NON-NLS-1$ buffer.append(activeShell); buffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/XMLMemento.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/XMLMemento.java index f04e3cf76c9..e6f124e606d 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/XMLMemento.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/XMLMemento.java @@ -675,7 +675,7 @@ public final class XMLMemento implements IMemento { } private void startTag(Element element, boolean hasChildren) { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append("<"); //$NON-NLS-1$ sb.append(element.getTagName()); NamedNodeMap attributes = element.getAttributes(); @@ -692,14 +692,14 @@ public final class XMLMemento implements IMemento { } private void endTag(Element element) { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append("</"); //$NON-NLS-1$ sb.append(element.getNodeName()); sb.append(">"); //$NON-NLS-1$ print(sb.toString()); } - private static void appendEscapedChar(StringBuffer buffer, char c) { + private static void appendEscapedChar(StringBuilder buffer, char c) { String replacement = getReplacement(c); if (replacement != null) { buffer.append('&'); @@ -711,7 +711,7 @@ public final class XMLMemento implements IMemento { } private static String getEscaped(String s) { - StringBuffer result = new StringBuffer(s.length() + 10); + StringBuilder result = new StringBuilder(s.length() + 10); for (int i = 0; i < s.length(); ++i) { appendEscapedChar(result, s.charAt(i)); } diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/actions/RetargetAction.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/actions/RetargetAction.java index a3ff4d5aa08..97f84ba688a 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/actions/RetargetAction.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/actions/RetargetAction.java @@ -309,7 +309,7 @@ public class RetargetAction extends PartEventAction implements */ @Override public final String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("RetargetAction("); //$NON-NLS-1$ buffer.append(getId()); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/commands/ActionHandler.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/commands/ActionHandler.java index c7e4c1c869e..61a5eee6959 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/commands/ActionHandler.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/commands/ActionHandler.java @@ -254,7 +254,7 @@ public final class ActionHandler extends AbstractHandler { @Override @Deprecated public final String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("ActionHandler(action="); //$NON-NLS-1$ buffer.append(action); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/commands/HandlerSubmission.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/commands/HandlerSubmission.java index bf7a282b8b7..e3c9d851ab9 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/commands/HandlerSubmission.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/commands/HandlerSubmission.java @@ -233,7 +233,7 @@ public final class HandlerSubmission implements Comparable { @Override public String toString() { if (string == null) { - final StringBuffer stringBuffer = new StringBuffer(); + final StringBuilder stringBuffer = new StringBuilder(); stringBuffer.append("[activePartId="); //$NON-NLS-1$ stringBuffer.append(activePartId); stringBuffer.append(",activeShell="); //$NON-NLS-1$ diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/commands/Priority.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/commands/Priority.java index 6fbb1695c03..471284cd3dc 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/commands/Priority.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/commands/Priority.java @@ -115,7 +115,7 @@ public final class Priority implements Comparable { @Deprecated public String toString() { if (string == null) { - final StringBuffer stringBuffer = new StringBuffer(); + final StringBuilder stringBuffer = new StringBuilder(); stringBuffer.append("[value="); //$NON-NLS-1$ stringBuffer.append(value); stringBuffer.append(']'); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/contexts/EnabledSubmission.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/contexts/EnabledSubmission.java index d0320156e0b..ec23c9d0d8c 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/contexts/EnabledSubmission.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/contexts/EnabledSubmission.java @@ -176,7 +176,7 @@ public final class EnabledSubmission implements Comparable { @Override public String toString() { if (string == null) { - final StringBuffer stringBuffer = new StringBuffer(); + final StringBuilder stringBuffer = new StringBuilder(); stringBuffer.append("[activePartId="); //$NON-NLS-1$ stringBuffer.append(activePartId); stringBuffer.append(",activeShell="); //$NON-NLS-1$ diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/FileSystemElement.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/FileSystemElement.java index b742fffa6bd..b0afcc027a0 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/FileSystemElement.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/FileSystemElement.java @@ -249,7 +249,7 @@ public class FileSystemElement implements IAdaptable { */ @Override public String toString() { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); if (isDirectory()) { buf.append("Folder(");//$NON-NLS-1$ } else { diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/FilteredItemsSelectionDialog.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/FilteredItemsSelectionDialog.java index 8c44b6c78f4..68c6e57ac51 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/FilteredItemsSelectionDialog.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/FilteredItemsSelectionDialog.java @@ -1657,13 +1657,13 @@ public abstract class FilteredItemsSelectionDialog extends SelectionStatusDialog gc.dispose(); - StringBuffer dashes = new StringBuffer(); + StringBuilder dashes = new StringBuilder(); int chars = (((width - fMessageLength) / fSeparatorWidth) / 2) - 2; for (int i = 0; i < chars; i++) { dashes.append('-'); } - StringBuffer result = new StringBuffer(); + StringBuilder result = new StringBuilder(); result.append(dashes); result.append(" " + separatorLabel + " "); //$NON-NLS-1$//$NON-NLS-2$ result.append(dashes); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/TypeFilteringDialog.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/TypeFilteringDialog.java index b7bae5a33d5..622d5ac4543 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/TypeFilteringDialog.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/TypeFilteringDialog.java @@ -172,7 +172,7 @@ public class TypeFilteringDialog extends SelectionDialog { } //Now add in the ones not selected to the user defined list Iterator initialIterator = this.initialSelections.iterator(); - StringBuffer entries = new StringBuffer(); + StringBuilder entries = new StringBuilder(); while (initialIterator.hasNext()) { String nextExtension = (String) initialIterator.next(); if (!selectedMappings.contains(nextExtension)) { diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/WorkingSetConfigurationBlock.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/WorkingSetConfigurationBlock.java index cb545960269..2779df651f7 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/WorkingSetConfigurationBlock.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/dialogs/WorkingSetConfigurationBlock.java @@ -411,7 +411,7 @@ public class WorkingSetConfigurationBlock { private void updateWorkingSetSelection() { if (selectedWorkingSets.length > 0) { workingSetCombo.setEnabled(true); - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append(selectedWorkingSets[0].getLabel()); for (int i = 1; i < selectedWorkingSets.length; i++) { diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ExtensionEventHandler.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ExtensionEventHandler.java index 0c618f2dedd..70fc24d2a0d 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ExtensionEventHandler.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ExtensionEventHandler.java @@ -195,7 +195,7 @@ class ExtensionEventHandler implements IRegistryChangeListener { return; } - final StringBuffer message = new StringBuffer( + final StringBuilder message = new StringBuilder( ExtensionEventHandlerMessages.ExtensionEventHandler_following_changes); for (Iterator i = changeList.iterator(); i.hasNext();) { diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ObjectActionContributor.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ObjectActionContributor.java index bf5ec37fcf5..aad09dddd78 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ObjectActionContributor.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ObjectActionContributor.java @@ -385,7 +385,7 @@ public class ObjectActionContributor extends PluginActionBuilder implements */ @Override public String toString() { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); IConfigurationElement[] children = config.getChildren(); for (IConfigurationElement element : children) { String label = element.getAttribute(IWorkbenchRegistryConstants.ATT_LABEL); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/PartSite.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/PartSite.java index 357251cd142..7e34e36bbfa 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/PartSite.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/PartSite.java @@ -627,7 +627,7 @@ public abstract class PartSite implements IWorkbenchPartSite { */ @Override public String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("PartSite(id="); //$NON-NLS-1$ buffer.append(getId()); buffer.append(",pluginId="); //$NON-NLS-1$ diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ReopenEditorMenu.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ReopenEditorMenu.java index 09d9f21c7f4..94220f0d5f3 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ReopenEditorMenu.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ReopenEditorMenu.java @@ -88,10 +88,10 @@ public class ReopenEditorMenu extends ContributionItem { * @return a string suitable for an MRU file menu */ public static String calcText(int index, String name, String toolTip, boolean rtl) { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); int mnemonic = index + 1; - StringBuffer nm = new StringBuffer(); + StringBuilder nm = new StringBuilder(); nm.append(mnemonic); if (mnemonic <= MAX_MNEMONIC_SIZE) { nm.insert(nm.length() - (mnemonic + "").length(), '&'); //$NON-NLS-1$ diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/SwitchToWindowMenu.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/SwitchToWindowMenu.java index ec881d48d98..638ece9daf2 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/SwitchToWindowMenu.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/SwitchToWindowMenu.java @@ -53,7 +53,7 @@ public class SwitchToWindowMenu extends ContributionItem { return null; } - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); if (number < 10) { sb.append('&'); } diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java index c1ffdab097b..28cc3a6a82e 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java @@ -2622,7 +2622,7 @@ public final class Workbench extends EventManager implements IWorkbench, return null; } - StringBuffer result = new StringBuffer(512); + StringBuilder result = new StringBuilder(512); result.append(property); result.append('\n'); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/AboutUtils.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/AboutUtils.java index b237ad6fa11..0b0dede46ca 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/AboutUtils.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/AboutUtils.java @@ -164,7 +164,7 @@ public class AboutUtils { * @since 3.0.2 */ private static String urlEncodeForSpaces(char[] input) { - StringBuffer retu = new StringBuffer(input.length); + StringBuilder retu = new StringBuilder(input.length); for (char element : input) { if (element == ' ') { retu.append("%20"); //$NON-NLS-1$ diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/BundleSigningInfo.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/BundleSigningInfo.java index 8b89140c96a..c7657fa7b26 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/BundleSigningInfo.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/about/BundleSigningInfo.java @@ -177,7 +177,7 @@ public class BundleSigningInfo { if (certs.length == 0) signerText = WorkbenchMessages.BundleSigningTray_Unknown; else { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); for (Iterator i = certs[0].entrySet().iterator(); i .hasNext();) { Map.Entry entry = (Entry) i.next(); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/Activity.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/Activity.java index 75bc6ef57d3..23c90eaf5a6 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/Activity.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/Activity.java @@ -340,7 +340,7 @@ final class Activity implements IActivity { @Override public String toString() { if (string == null) { - final StringBuffer stringBuffer = new StringBuffer(); + final StringBuilder stringBuffer = new StringBuilder(); stringBuffer.append('['); stringBuffer.append(activityRequirementBindings); stringBuffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityDefinition.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityDefinition.java index af77bc2ead8..242857a6370 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityDefinition.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityDefinition.java @@ -164,7 +164,7 @@ public final class ActivityDefinition implements Comparable { @Override public String toString() { if (string == null) { - final StringBuffer stringBuffer = new StringBuffer(); + final StringBuilder stringBuffer = new StringBuilder(); stringBuffer.append('['); stringBuffer.append(id); stringBuffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityPatternBinding.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityPatternBinding.java index b36c6719017..c218b2ad77d 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityPatternBinding.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityPatternBinding.java @@ -156,7 +156,7 @@ public final class ActivityPatternBinding implements IActivityPatternBinding { @Override public String toString() { if (string == null) { - final StringBuffer stringBuffer = new StringBuffer(); + final StringBuilder stringBuffer = new StringBuilder(); stringBuffer.append('['); stringBuffer.append(activityId); stringBuffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityPatternBindingDefinition.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityPatternBindingDefinition.java index 09fb6be801c..845c7ea1ed8 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityPatternBindingDefinition.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityPatternBindingDefinition.java @@ -160,7 +160,7 @@ public final class ActivityPatternBindingDefinition { @Override public String toString() { if (string == null) { - final StringBuffer stringBuffer = new StringBuffer(); + final StringBuilder stringBuffer = new StringBuilder(); stringBuffer.append('['); stringBuffer.append(activityId); stringBuffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityRequirementBinding.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityRequirementBinding.java index f9f7b8fe50c..941e99dd640 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityRequirementBinding.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityRequirementBinding.java @@ -93,7 +93,7 @@ public final class ActivityRequirementBinding implements @Override public String toString() { if (string == null) { - final StringBuffer stringBuffer = new StringBuffer(); + final StringBuilder stringBuffer = new StringBuilder(); stringBuffer.append('['); stringBuffer.append(requiredActivityId); stringBuffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityRequirementBindingDefinition.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityRequirementBindingDefinition.java index ec8e3061e1e..9d2406893bb 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityRequirementBindingDefinition.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/ActivityRequirementBindingDefinition.java @@ -142,7 +142,7 @@ public final class ActivityRequirementBindingDefinition { @Override public String toString() { if (string == null) { - final StringBuffer stringBuffer = new StringBuffer(); + final StringBuilder stringBuffer = new StringBuilder(); stringBuffer.append('['); stringBuffer.append(requiredActivityId); stringBuffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/Category.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/Category.java index e86cdbf7657..caf349592ac 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/Category.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/Category.java @@ -229,7 +229,7 @@ final class Category implements ICategory { @Override public String toString() { if (string == null) { - final StringBuffer stringBuffer = new StringBuffer(); + final StringBuilder stringBuffer = new StringBuilder(); stringBuffer.append('['); stringBuffer.append(categoryActivityBindings); stringBuffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/CategoryActivityBinding.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/CategoryActivityBinding.java index 2453b373d3a..e2a68516343 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/CategoryActivityBinding.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/CategoryActivityBinding.java @@ -89,7 +89,7 @@ public final class CategoryActivityBinding implements ICategoryActivityBinding { @Override public String toString() { if (string == null) { - final StringBuffer stringBuffer = new StringBuffer(); + final StringBuilder stringBuffer = new StringBuilder(); stringBuffer.append('['); stringBuffer.append(activityId); stringBuffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/CategoryActivityBindingDefinition.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/CategoryActivityBindingDefinition.java index 7735589ce5c..816eeadfc78 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/CategoryActivityBindingDefinition.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/CategoryActivityBindingDefinition.java @@ -139,7 +139,7 @@ public final class CategoryActivityBindingDefinition { @Override public String toString() { if (string == null) { - final StringBuffer stringBuffer = new StringBuffer(); + final StringBuilder stringBuffer = new StringBuilder(); stringBuffer.append('['); stringBuffer.append(activityId); stringBuffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/CategoryDefinition.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/CategoryDefinition.java index 3483513bd44..72caac51934 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/CategoryDefinition.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/CategoryDefinition.java @@ -161,7 +161,7 @@ public final class CategoryDefinition implements Comparable { @Override public String toString() { if (string == null) { - final StringBuffer stringBuffer = new StringBuffer(); + final StringBuilder stringBuffer = new StringBuilder(); stringBuffer.append('['); stringBuffer.append(id); stringBuffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/Identifier.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/Identifier.java index dd434e90c7f..872ee7937a8 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/Identifier.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/activities/Identifier.java @@ -183,7 +183,7 @@ final class Identifier implements IIdentifier { @Override public String toString() { if (string == null) { - final StringBuffer stringBuffer = new StringBuffer(); + final StringBuilder stringBuffer = new StringBuilder(); stringBuffer.append('['); stringBuffer.append(activityIds); stringBuffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/browser/DefaultWebBrowser.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/browser/DefaultWebBrowser.java index aa3524e5bc5..a079dcdeeaa 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/browser/DefaultWebBrowser.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/browser/DefaultWebBrowser.java @@ -125,7 +125,7 @@ public class DefaultWebBrowser extends AbstractWebBrowser { * */ private String urlEncodeForSpaces(char[] input) { - StringBuffer retu = new StringBuffer(input.length); + StringBuilder retu = new StringBuilder(input.length); for (char element : input) { if (element == ' ') { retu.append("%20"); //$NON-NLS-1$ diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/contexts/ContextActivation.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/contexts/ContextActivation.java index 16701458899..cbf386ba5b2 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/contexts/ContextActivation.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/contexts/ContextActivation.java @@ -104,7 +104,7 @@ final class ContextActivation extends EvaluationResultCache implements @Override public final String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("ContextActivation(contextId="); //$NON-NLS-1$ buffer.append(contextId); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/contexts/ContextAuthority.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/contexts/ContextAuthority.java index 1caa321efce..0114d29d4f0 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/contexts/ContextAuthority.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/contexts/ContextAuthority.java @@ -477,7 +477,7 @@ public final class ContextAuthority extends ExpressionAuthority { // Debugging output if (DEBUG) { - final StringBuffer buffer = new StringBuffer("register shell '"); //$NON-NLS-1$ + final StringBuilder buffer = new StringBuilder("register shell '"); //$NON-NLS-1$ buffer.append(shell); buffer.append("' as "); //$NON-NLS-1$ switch (type) { diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/decorators/DecorationResult.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/decorators/DecorationResult.java index ff9aa166eed..61bb7824d26 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/decorators/DecorationResult.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/decorators/DecorationResult.java @@ -103,7 +103,7 @@ public class DecorationResult { return text; } - StringBuffer result = new StringBuffer(); + StringBuilder result = new StringBuilder(); ListIterator prefixIterator = prefixes.listIterator(); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/decorators/DecoratorManager.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/decorators/DecoratorManager.java index a1ac77003bf..651562bedab 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/decorators/DecoratorManager.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/decorators/DecoratorManager.java @@ -748,7 +748,7 @@ public class DecoratorManager implements ILabelProviderListener, * Store the currently enabled decorators in preference store. */ private void writeDecoratorsPreference() { - StringBuffer enabledIds = new StringBuffer(); + StringBuilder enabledIds = new StringBuilder(); writeDecoratorsPreference(enabledIds, getFullDefinitions()); writeDecoratorsPreference(enabledIds, getLightweightManager() .getDefinitions()); @@ -758,7 +758,7 @@ public class DecoratorManager implements ILabelProviderListener, PrefUtil.savePrefs(); } - private void writeDecoratorsPreference(StringBuffer enabledIds, + private void writeDecoratorsPreference(StringBuilder enabledIds, DecoratorDefinition[] definitions) { for (DecoratorDefinition definition : definitions) { enabledIds.append(definition.getId()); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/PropertyDialog.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/PropertyDialog.java index 17fb8eb45e4..f32ace0e9c0 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/PropertyDialog.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/PropertyDialog.java @@ -104,7 +104,7 @@ public class PropertyDialog extends FilteredPreferenceDialog { elements = ((IStructuredSelection) element).toArray(); else elements = new Object[] { element }; - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); // Print at most 3 entries... for (int i = 0; i < elements.length; i++) { element = elements[i]; diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/StartupPreferencePage.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/StartupPreferencePage.java index 6afd7562a99..d52496761d8 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/StartupPreferencePage.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/StartupPreferencePage.java @@ -132,7 +132,7 @@ public class StartupPreferencePage extends PreferencePage implements */ @Override public boolean performOk() { - StringBuffer preference = new StringBuffer(); + StringBuilder preference = new StringBuilder(); TableItem items[] = pluginsList.getItems(); for (int i = 0; i < items.length; i++) { if (!items[i].getChecked()) { diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WizardCollectionElement.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WizardCollectionElement.java index 1f500ec9d42..3c61dfc0987 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WizardCollectionElement.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WizardCollectionElement.java @@ -313,7 +313,7 @@ public class WizardCollectionElement extends AdaptableList implements IPluginCon */ @Override public String toString() { - StringBuffer buf = new StringBuffer("WizardCollection, "); //$NON-NLS-1$ + StringBuilder buf = new StringBuilder("WizardCollection, "); //$NON-NLS-1$ buf.append(children.size()); buf.append(" children, "); //$NON-NLS-1$ buf.append(wizards.size()); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkingSetSelectionDialog.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkingSetSelectionDialog.java index 352bb5669ad..c8c2c80a5ec 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkingSetSelectionDialog.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/WorkingSetSelectionDialog.java @@ -361,7 +361,7 @@ public class WorkingSetSelectionDialog extends AbstractWorkingSetDialog { * @return the name */ private String getAggregateIdForSets(IWorkingSet[] typedResult) { - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append("Aggregate:"); //$NON-NLS-1$ for (IWorkingSet element : typedResult) { buffer.append(element.getName()).append(':'); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/ItemDetailToolTip.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/ItemDetailToolTip.java index b74177034ed..2423b09a8e7 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/ItemDetailToolTip.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/cpd/ItemDetailToolTip.java @@ -302,7 +302,7 @@ class ItemDetailToolTip extends NameAndDescriptionToolTip { // Show dynamic menu item info if (item instanceof DynamicContributionItem) { DynamicContributionItem dynamic = ((DynamicContributionItem) item); - StringBuffer text = new StringBuffer(); + StringBuilder text = new StringBuilder(); final List<MenuItem> currentItems = dynamic.getCurrentItems(); if (currentItems.size() > 0) { diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/ActivePartExpression.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/ActivePartExpression.java index b45b38ea778..3b869c0bb2f 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/ActivePartExpression.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/ActivePartExpression.java @@ -88,7 +88,7 @@ public final class ActivePartExpression extends Expression { @Override public final String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("ActivePartExpression("); //$NON-NLS-1$ buffer.append(activePart); buffer.append(')'); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/AndExpression.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/AndExpression.java index e00b5e58286..eb912fc10d8 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/AndExpression.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/AndExpression.java @@ -51,7 +51,7 @@ public final class AndExpression extends CompositeExpression { @Override public final String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("AndExpression("); //$NON-NLS-1$ if (fExpressions != null) { final Iterator itr = fExpressions.iterator(); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyActionExpressionWrapper.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyActionExpressionWrapper.java index 48cfb601859..2f3b1b487dd 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyActionExpressionWrapper.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyActionExpressionWrapper.java @@ -116,7 +116,7 @@ public final class LegacyActionExpressionWrapper extends @Override public final String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("LegacyActionExpressionWrapper("); //$NON-NLS-1$ buffer.append(expression); buffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyActionSetExpression.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyActionSetExpression.java index 66347a2baa0..48f0af81bc2 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyActionSetExpression.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyActionSetExpression.java @@ -107,7 +107,7 @@ public final class LegacyActionSetExpression extends WorkbenchWindowExpression { @Override public final String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("ActionSetExpression("); //$NON-NLS-1$ buffer.append(actionSetId); buffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyEditorActionBarExpression.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyEditorActionBarExpression.java index 35ba5b89598..7deceb2bfb6 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyEditorActionBarExpression.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyEditorActionBarExpression.java @@ -94,7 +94,7 @@ public class LegacyEditorActionBarExpression extends Expression { @Override public final String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("LegacyEditorActionBarExpression("); //$NON-NLS-1$ buffer.append(activeEditorId); buffer.append(')'); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyEditorContributionExpression.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyEditorContributionExpression.java index 5358a761fe6..57fc2739de0 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyEditorContributionExpression.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyEditorContributionExpression.java @@ -109,7 +109,7 @@ public final class LegacyEditorContributionExpression extends @Override public final String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("LegacyEditorContributionExpression("); //$NON-NLS-1$ buffer.append(activeEditorId); buffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacySelectionEnablerWrapper.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacySelectionEnablerWrapper.java index 7e3cc1cb802..1f18f1964ba 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacySelectionEnablerWrapper.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacySelectionEnablerWrapper.java @@ -113,7 +113,7 @@ public final class LegacySelectionEnablerWrapper extends @Override public final String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("LegacySelectionEnablerWrapper("); //$NON-NLS-1$ buffer.append(enabler); buffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyViewContributionExpression.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyViewContributionExpression.java index 9deb6634f73..d7d7d582cdd 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyViewContributionExpression.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyViewContributionExpression.java @@ -109,7 +109,7 @@ public final class LegacyViewContributionExpression extends @Override public final String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("LegacyViewContributionExpression("); //$NON-NLS-1$ buffer.append(activePartId); buffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyViewerContributionExpression.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyViewerContributionExpression.java index 4dbeeeb6ded..75e2cf74c90 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyViewerContributionExpression.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/LegacyViewerContributionExpression.java @@ -145,7 +145,7 @@ public final class LegacyViewerContributionExpression extends @Override public final String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("ViewerContributionExpression("); //$NON-NLS-1$ buffer.append(targetId); buffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/WorkbenchWindowExpression.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/WorkbenchWindowExpression.java index 25b9a96934a..65c3d4e6969 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/WorkbenchWindowExpression.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/expressions/WorkbenchWindowExpression.java @@ -102,7 +102,7 @@ public class WorkbenchWindowExpression extends Expression { @Override public String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("WorkbenchWindowExpression("); //$NON-NLS-1$ buffer.append(window); buffer.append(')'); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/ActionDelegateHandlerProxy.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/ActionDelegateHandlerProxy.java index 865857d3f7e..a4fde8fe193 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/ActionDelegateHandlerProxy.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/ActionDelegateHandlerProxy.java @@ -504,7 +504,7 @@ public final class ActionDelegateHandlerProxy implements ISelectionListener, } } catch (final CoreException e) { // We will just fall through an let it return false. - final StringBuffer message = new StringBuffer( + final StringBuilder message = new StringBuilder( "An exception occurred while evaluating the enabledWhen expression for "); //$NON-NLS-1$ if (delegate != null) { message.append(delegate); @@ -694,7 +694,7 @@ public final class ActionDelegateHandlerProxy implements ISelectionListener, @Override public final String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("ActionDelegateHandlerProxy("); //$NON-NLS-1$ buffer.append(getDelegate()); if (element != null) { diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/LegacyHandlerProxy.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/LegacyHandlerProxy.java index be1c84494b6..24d46e2a7f8 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/LegacyHandlerProxy.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/LegacyHandlerProxy.java @@ -138,7 +138,7 @@ public final class LegacyHandlerProxy extends AbstractHandler { @Override public final String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("LegacyProxy("); //$NON-NLS-1$ if (handler == null) { diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/LegacyHandlerWrapper.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/LegacyHandlerWrapper.java index e571acb12e2..5561c2343fc 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/LegacyHandlerWrapper.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/LegacyHandlerWrapper.java @@ -83,7 +83,7 @@ public final class LegacyHandlerWrapper implements IHandler { throws ExecutionException { // Debugging output if (DEBUG_HANDLERS) { - final StringBuffer buffer = new StringBuffer("Executing LegacyHandlerWrapper for "); //$NON-NLS-1$ + final StringBuilder buffer = new StringBuilder("Executing LegacyHandlerWrapper for "); //$NON-NLS-1$ if (handler == null) { buffer.append("no handler"); //$NON-NLS-1$ } else { @@ -137,7 +137,7 @@ public final class LegacyHandlerWrapper implements IHandler { @Override public final String toString() { - final StringBuffer buffer = new StringBuffer(); + final StringBuilder buffer = new StringBuilder(); buffer.append("LegacyHandlerWrapper("); //$NON-NLS-1$ buffer.append(handler); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/AbstractKeyFormatter.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/AbstractKeyFormatter.java index 86acfbf0a33..dd455313f48 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/AbstractKeyFormatter.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/AbstractKeyFormatter.java @@ -64,7 +64,7 @@ public abstract class AbstractKeyFormatter implements IKeyFormatter { @Override public String format(KeySequence keySequence) { - StringBuffer stringBuffer = new StringBuffer(); + StringBuilder stringBuffer = new StringBuilder(); Iterator keyStrokeItr = keySequence.getKeyStrokes().iterator(); while (keyStrokeItr.hasNext()) { @@ -85,7 +85,7 @@ public abstract class AbstractKeyFormatter implements IKeyFormatter { // Format the modifier keys, in sorted order. SortedSet modifierKeys = new TreeSet(getModifierKeyComparator()); modifierKeys.addAll(keyStroke.getModifierKeys()); - StringBuffer stringBuffer = new StringBuffer(); + StringBuilder stringBuffer = new StringBuilder(); Iterator modifierKeyItr = modifierKeys.iterator(); while (modifierKeyItr.hasNext()) { stringBuffer.append(format((ModifierKey) modifierKeyItr.next())); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/CompactKeyFormatter.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/CompactKeyFormatter.java index d4573c64f6a..67ebf3553df 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/CompactKeyFormatter.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/CompactKeyFormatter.java @@ -34,7 +34,7 @@ public class CompactKeyFormatter extends NativeKeyFormatter { @Override public String format(KeySequence keySequence) { - StringBuffer stringBuffer = new StringBuffer(); + StringBuilder stringBuffer = new StringBuilder(); List keyStrokes = keySequence.getKeyStrokes(); KeyStroke[] keyStrokeArray = (KeyStroke[]) keyStrokes @@ -69,7 +69,7 @@ public class CompactKeyFormatter extends NativeKeyFormatter { } public String formatKeyStrokes(Set modifierKeys, List naturalKeys) { - StringBuffer stringBuffer = new StringBuffer(); + StringBuilder stringBuffer = new StringBuilder(); String keyDelimiter = getKeyDelimiter(); // Format the modifier keys, in sorted order. diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/KeySequenceBinding.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/KeySequenceBinding.java index 69174500f81..b0e684c4950 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/KeySequenceBinding.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/KeySequenceBinding.java @@ -103,7 +103,7 @@ public final class KeySequenceBinding implements IKeySequenceBinding { @Override public String toString() { if (string == null) { - final StringBuffer stringBuffer = new StringBuffer(); + final StringBuilder stringBuffer = new StringBuilder(); stringBuffer.append('['); stringBuffer.append(keySequence); stringBuffer.append(','); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/NewKeysPreferencePage.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/NewKeysPreferencePage.java index 2f8ab4d7340..8e516bc66bd 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/NewKeysPreferencePage.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/NewKeysPreferencePage.java @@ -352,7 +352,7 @@ public class NewKeysPreferencePage extends PreferencePage implements IWorkbenchP if (rc == null) { rc = super.getText(element); } - StringBuffer buf = new StringBuffer(rc); + StringBuilder buf = new StringBuilder(rc); for (int i = 1; i < USER_DELTA_COLUMN; i++) { String text = getColumnText(element, i); if (text != null) { diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/model/KeyController.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/model/KeyController.java index 2fc9ee467c2..03123070a9e 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/model/KeyController.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/keys/model/KeyController.java @@ -515,7 +515,7 @@ public class KeyController { || be.getTrigger().isEmpty()) { continue; } - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); buffer.append(ESCAPED_QUOTE + Util.replaceAll(be.getCategory(), ESCAPED_QUOTE, REPLACEMENT) diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/misc/StringMatcher.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/misc/StringMatcher.java index 0e0d3568528..10233786d45 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/misc/StringMatcher.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/misc/StringMatcher.java @@ -287,7 +287,7 @@ public class StringMatcher { Vector temp = new Vector(); int pos = 0; - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); while (pos < fLength) { char c = fPattern.charAt(pos++); switch (c) { diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/quickaccess/CamelUtil.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/quickaccess/CamelUtil.java index 59a954cdb13..424d8aab5f2 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/quickaccess/CamelUtil.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/quickaccess/CamelUtil.java @@ -33,7 +33,7 @@ public class CamelUtil { * the given string. */ public static String getCamelCase(String s) { - StringBuffer result = new StringBuffer(); + StringBuilder result = new StringBuilder(); if (s.length() > 0) { int index = 0; while (index != -1) { diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/CategorizedPageRegistryReader.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/CategorizedPageRegistryReader.java index 3313ab7e514..787c15b0a28 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/CategorizedPageRegistryReader.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/CategorizedPageRegistryReader.java @@ -82,7 +82,7 @@ public abstract class CategorizedPageRegistryReader extends RegistryReader { return; } - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); StringTokenizer stok = new StringTokenizer(category, PREFERENCE_SEPARATOR); Object immediateParent = null; while (stok.hasMoreTokens()) { diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/RegistryReader.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/RegistryReader.java index 18b15ec37f3..2bd9b282669 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/RegistryReader.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/RegistryReader.java @@ -48,7 +48,7 @@ public abstract class RegistryReader { */ protected static void logError(IConfigurationElement element, String text) { IExtension extension = element.getDeclaringExtension(); - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf .append("Plugin " + extension.getNamespace() + ", extension " //$NON-NLS-1$//$NON-NLS-2$ + extension.getExtensionPointUniqueIdentifier()); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/services/ActionSetSourceProvider.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/services/ActionSetSourceProvider.java index 9dba4b17c32..21895e02f96 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/services/ActionSetSourceProvider.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/services/ActionSetSourceProvider.java @@ -55,7 +55,7 @@ public final class ActionSetSourceProvider extends AbstractSourceProvider final IActionSetDescriptor[] newActionSets = event.getNewActionSets(); if (!Util.equals(newActionSets, activeActionSets)) { if (DEBUG) { - final StringBuffer message = new StringBuffer(); + final StringBuilder message = new StringBuilder(); message.append("Action sets changed to ["); //$NON-NLS-1$ if (newActionSets != null) { for (int i = 0; i < newActionSets.length; i++) { diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/StackTraceSupportArea.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/StackTraceSupportArea.java index 058ecb7bf80..c054f80d207 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/StackTraceSupportArea.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/StackTraceSupportArea.java @@ -135,7 +135,7 @@ public class StackTraceSupportArea extends AbstractStatusAreaProvider { if (list == null || list.isDisposed()) { return ""; //$NON-NLS-1$ } - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); String newLine = System.getProperty("line.separator"); //$NON-NLS-1$ for (int i = 0; i < list.getItemCount(); i++) { sb.append(list.getItem(i)); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/themes/ColorsAndFontsPreferencePage.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/themes/ColorsAndFontsPreferencePage.java index 86319c87964..a45e3f61160 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/themes/ColorsAndFontsPreferencePage.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/themes/ColorsAndFontsPreferencePage.java @@ -1755,7 +1755,7 @@ getPreferenceStore(), private void saveTreeSelection() { IStructuredSelection selection = tree.getViewer().getStructuredSelection(); Object element = selection.getFirstElement(); - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); appendMarkerToBuffer(buffer, element); if (buffer.length() > 0) buffer.append(((IThemeElementDefinition) element).getId()); @@ -1821,7 +1821,7 @@ getPreferenceStore(), Object[] elements = tree.getViewer().getExpandedElements(); List elementIds = new ArrayList(elements.length); - StringBuffer buffer = new StringBuffer(); + StringBuilder buffer = new StringBuilder(); for (Object object : elements) { appendMarkerToBuffer(buffer, object); @@ -1843,7 +1843,7 @@ getPreferenceStore(), getPreferenceStore().setValue(EXPANDED_ELEMENTS_PREF, buffer.toString()); } - private void appendMarkerToBuffer(StringBuffer buffer, Object object) { + private void appendMarkerToBuffer(StringBuilder buffer, Object object) { if (object instanceof FontDefinition) { buffer.append(MARKER_FONT); } else if (object instanceof ColorDefinition) { @@ -1957,7 +1957,7 @@ getPreferenceStore(), FontData[] fontData = currentFont != null ? currentFont.getFontData() : new FontData[0]; // recalculate sample text - StringBuffer tmp = new StringBuffer(); + StringBuilder tmp = new StringBuilder(); for (FontData currentFontData : fontData) { tmp.append(currentFontData.getName()); tmp.append(' '); diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/operations/OperationHistoryActionHandler.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/operations/OperationHistoryActionHandler.java index a3fffa18175..c84bc96d3ec 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/operations/OperationHistoryActionHandler.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/operations/OperationHistoryActionHandler.java @@ -443,7 +443,7 @@ try { private String shortenText(String message) { int length = message.length(); if (length > MAX_LABEL_LENGTH) { - StringBuffer result = new StringBuffer(); + StringBuilder result = new StringBuilder(); int end = MAX_LABEL_LENGTH / 2 - 1; result.append(message.substring(0, end)); result.append("..."); //$NON-NLS-1$ |
