diff options
| author | Friederike | 2016-07-23 12:18:36 +0000 |
|---|---|---|
| committer | Friederike | 2016-07-23 12:49:36 +0000 |
| commit | 0723c476e5f4979022990e46e36cec1e7924e67d (patch) | |
| tree | e80251a7b26a2dc686874f91bbfd25eae5e38693 | |
| parent | 24a4f72a4beab64558b81c5b4544c36047e2d8bd (diff) | |
| download | eclipse.platform.ui-0723c476e5f4979022990e46e36cec1e7924e67d.tar.gz eclipse.platform.ui-0723c476e5f4979022990e46e36cec1e7924e67d.tar.xz eclipse.platform.ui-0723c476e5f4979022990e46e36cec1e7924e67d.zip | |
Bug 478336 - Removed auto-generated TODOsI20160726-1400
Many auto-generated TODOs are removed from the codebase but only those
for methods. auto-generated catch blocks have not been changed.
Change-Id: I76db021f3bc03a7db9f55846a5481e518317ad55
Signed-off-by: Friederike Schertel <friederike@schertel.org>
12 files changed, 27 insertions, 40 deletions
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CycleEditorHandler.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CycleEditorHandler.java index 084cd8dfbb2..9788d777f2b 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CycleEditorHandler.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CycleEditorHandler.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2007, 2015 IBM Corporation and others. + * Copyright (c) 2007, 2016 IBM Corporation and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -8,6 +8,7 @@ * Contributors: * IBM Corporation - initial API and implementation * Lars Vogel <Lars.Vogel@gmail.com> - Bug 440810 + * Friederike Schertel <friederike@schertel.org> - Bug 478336 ******************************************************************************/ package org.eclipse.ui.internal; @@ -66,7 +67,6 @@ public class CycleEditorHandler extends CycleBaseHandler { @Override protected String getTableHeader(IWorkbenchPart activePart) { - // TODO Auto-generated method stub return WorkbenchMessages.CycleEditorAction_header; } diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CycleViewHandler.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CycleViewHandler.java index ff3fca9717a..de732b4cb7c 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CycleViewHandler.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/CycleViewHandler.java @@ -9,6 +9,7 @@ * IBM Corporation - initial API and implementation * Lars Vogel <Lars.Vogel@gmail.com> - Bug 440810 * Simon Scholz <simon.scholz@vogella.com> - Bug 454143, 461063 + * Friederike Schertel <friederike@schertel.org> - Bug 478336 ******************************************************************************/ package org.eclipse.ui.internal; @@ -98,25 +99,24 @@ public class CycleViewHandler extends CycleBaseHandler { @Override protected ParameterizedCommand getBackwardCommand() { - // TODO Auto-generated method stub - final ICommandService commandService = window.getWorkbench().getService(ICommandService.class); - final Command command = commandService.getCommand(IWorkbenchCommandConstants.WINDOW_PREVIOUS_VIEW); - ParameterizedCommand commandBack = new ParameterizedCommand(command, null); - return commandBack; + return getParametrizedCommand(IWorkbenchCommandConstants.WINDOW_PREVIOUS_VIEW); } @Override protected ParameterizedCommand getForwardCommand() { - // TODO Auto-generated method stub + return getParametrizedCommand(IWorkbenchCommandConstants.WINDOW_NEXT_VIEW); + } + + private ParameterizedCommand getParametrizedCommand(String workbenchCommand) + { final ICommandService commandService = window.getWorkbench().getService(ICommandService.class); - final Command command = commandService.getCommand(IWorkbenchCommandConstants.WINDOW_NEXT_VIEW); - ParameterizedCommand commandF = new ParameterizedCommand(command, null); - return commandF; + final Command command = commandService.getCommand(workbenchCommand); + ParameterizedCommand parameterizedCommand = new ParameterizedCommand(command, null); + return parameterizedCommand; } @Override protected String getTableHeader(IWorkbenchPart activePart) { - // TODO Auto-generated method stub return WorkbenchMessages.CyclePartAction_header; } diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ImageCycleFeedbackBase.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ImageCycleFeedbackBase.java index 7a537cedebd..6e8269b56af 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ImageCycleFeedbackBase.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ImageCycleFeedbackBase.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2007, 2015 IBM Corporation and others. + * Copyright (c) 2007, 2016 IBM Corporation and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -7,6 +7,7 @@ * * Contributors: * IBM Corporation - initial API and implementation + * Friederike Schertel <friederike@schertel.org> - Bug 478336 ******************************************************************************/ package org.eclipse.ui.internal; @@ -80,7 +81,6 @@ public abstract class ImageCycleFeedbackBase extends AnimationFeedbackBase { @Override public void dispose() { - // TODO Auto-generated method stub if (stoppedImage == null || stoppedImage.isDisposed()) return; setStoppedImage(stoppedImage); @@ -99,7 +99,6 @@ public abstract class ImageCycleFeedbackBase extends AnimationFeedbackBase { @Override public void renderStep(AnimationEngine engine) { - // TODO Auto-generated method stub if (offScreenImage == null) { offScreenImage = getOffscreenImage(); } diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ShowViewMenuHandler.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ShowViewMenuHandler.java index 0331d896e4f..a6364f31cf0 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ShowViewMenuHandler.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ShowViewMenuHandler.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2007, 2015 IBM Corporation and others. + * Copyright (c) 2007, 2016 IBM Corporation and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -7,6 +7,7 @@ * * Contributors: * IBM Corporation - initial API and implementation + * Friederike Schertel <friederike@schertel.org> - Bug 478336 ******************************************************************************/ package org.eclipse.ui.internal; @@ -137,7 +138,6 @@ public class ShowViewMenuHandler extends AbstractEvaluationHandler { @Override protected Expression getEnabledWhenExpression() { - // TODO Auto-generated method stub if (enabledWhen == null) { enabledWhen = new Expression() { @Override diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ViewReference.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ViewReference.java index 907ef77ffb6..2e2278d69ba 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ViewReference.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ViewReference.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2005, 2015 IBM Corporation and others. + * Copyright (c) 2005, 2016 IBM Corporation and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -7,6 +7,7 @@ * * Contributors: * IBM Corporation - initial API and implementation + * Friederike Schertel <friederike@schertel.org> - Bug 478336 *******************************************************************************/ package org.eclipse.ui.internal; @@ -87,7 +88,6 @@ public class ViewReference extends WorkbenchPartReference implements IViewRefere @Override public boolean isFastView() { - // TODO Auto-generated method stub return false; } diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/ActionDelegateHandlerProxy.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/ActionDelegateHandlerProxy.java index 11af7486dab..6852f561ed4 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/ActionDelegateHandlerProxy.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/ActionDelegateHandlerProxy.java @@ -7,6 +7,7 @@ * * Contributors: * IBM Corporation - initial API and implementation + * Friederike Schertel <friederike@schertel.org> - Bug 478336 *******************************************************************************/ package org.eclipse.ui.internal.handlers; @@ -234,8 +235,6 @@ public final class ActionDelegateHandlerProxy implements ISelectionListener, @Override public void addState(String id, State state) { - // TODO Auto-generated method stub - } @@ -421,13 +420,11 @@ public final class ActionDelegateHandlerProxy implements ISelectionListener, @Override public State getState(String stateId) { - // TODO Auto-generated method stub return null; } @Override public String[] getStateIds() { - // TODO Auto-generated method stub return null; } @@ -665,8 +662,6 @@ public final class ActionDelegateHandlerProxy implements ISelectionListener, @Override public void removeState(String stateId) { - // TODO Auto-generated method stub - } private final void selectionChanged(final ISelection selection) { diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/HandlerActivation.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/HandlerActivation.java index 611a45e41ff..cea1eb32748 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/HandlerActivation.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/HandlerActivation.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2005, 2015 IBM Corporation and others. + * Copyright (c) 2005, 2016 IBM Corporation and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -7,6 +7,7 @@ * * Contributors: * IBM Corporation - initial API and implementation + * Friederike Schertel <friederike@schertel.org> - Bug 478336 *******************************************************************************/ package org.eclipse.ui.internal.handlers; @@ -145,8 +146,6 @@ final class HandlerActivation implements IHandlerActivation { @Override public void clearActive() { - // TODO Auto-generated method stub - } @Override @@ -180,4 +179,3 @@ final class HandlerActivation implements IHandlerActivation { + ": " + handler + ": " + context; //$NON-NLS-1$ //$NON-NLS-2$ } } - diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/LegacyHandlerService.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/LegacyHandlerService.java index 0478d9a91e0..6f917809106 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/LegacyHandlerService.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/handlers/LegacyHandlerService.java @@ -9,6 +9,7 @@ * IBM Corporation - initial API and implementation * Lars Vogel <Lars.Vogel@vogella.com> - Bug 472654 * Daniel Kruegler <daniel.kruegler@gmail.com> - Bug 487418 + * Friederike Schertel <friederike@schertel.org> - Bug 478336 ******************************************************************************/ package org.eclipse.ui.internal.handlers; @@ -230,14 +231,10 @@ public class LegacyHandlerService implements IHandlerService { @Override public void addSourceProvider(ISourceProvider provider) { - // TODO Auto-generated method stub - } @Override public void removeSourceProvider(ISourceProvider provider) { - // TODO Auto-generated method stub - } @Override diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/menus/MenuPersistence.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/menus/MenuPersistence.java index 496265e9032..8b5bbfae477 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/menus/MenuPersistence.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/menus/MenuPersistence.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2005, 2015 IBM Corporation and others. + * Copyright (c) 2005, 2016 IBM Corporation and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -8,6 +8,7 @@ * Contributors: * IBM Corporation - initial API and implementation * Lars Vogel <Lars.Vogel@vogella.com> - Bug 472654 + * Friederike Schertel <friederike@schertel.org> - Bug 478336 *******************************************************************************/ package org.eclipse.ui.internal.menus; @@ -85,7 +86,6 @@ final public class MenuPersistence extends RegistryPersistence { } @Override protected boolean isChangeImportant(IRegistryChangeEvent event) { - // TODO Auto-generated method stub return false; } diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/menus/WorkbenchMenuService.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/menus/WorkbenchMenuService.java index ace075debad..68cc27aee86 100755 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/menus/WorkbenchMenuService.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/menus/WorkbenchMenuService.java @@ -89,14 +89,12 @@ public class WorkbenchMenuService implements IMenuService { @Override public void addSourceProvider(ISourceProvider provider) { - // TODO Auto-generated method + // TODO Auto-generated method } @Override public void removeSourceProvider(ISourceProvider provider) { - // TODO Auto-generated method stub - } @Override diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/ViewDescriptor.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/ViewDescriptor.java index a03f5b79329..db472bd1e7d 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/ViewDescriptor.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/registry/ViewDescriptor.java @@ -8,6 +8,7 @@ * Contributors: * IBM Corporation - initial API and implementation * Markus Alexander Kuppe, Versant Corporation - bug #215797 + * Friederike Schertel <friederike@schertel.org> - Bug 478336 *******************************************************************************/ package org.eclipse.ui.internal.registry; @@ -100,7 +101,6 @@ public class ViewDescriptor implements IViewDescriptor, IPluginContribution { @Override public float getFastViewWidthRatio() { - // TODO Auto-generated method stub return 0; } diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/InternalDialog.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/InternalDialog.java index 80a823c8472..925e412692b 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/InternalDialog.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/statushandlers/InternalDialog.java @@ -8,6 +8,7 @@ * Contributors: * IBM Corporation - initial API and implementation * Patrik Suzzi <psuzzi@gmail.com> - Bug 473973 + * Friederike Schertel <friederike@schertel.org> - Bug 478336 ******************************************************************************/ package org.eclipse.ui.internal.statushandlers; @@ -468,7 +469,6 @@ public class InternalDialog extends TrayDialog { @Override public Point getInitialLocation(Point initialSize) { - // TODO Auto-generated method stub return super.getInitialLocation(initialSize); } |
