diff options
| author | Paul Elder | 2013-11-14 18:17:51 +0000 |
|---|---|---|
| committer | Paul Webster | 2013-11-19 21:06:35 +0000 |
| commit | eb411f692ec4e08f41bd3e0df84d06810b39ede8 (patch) | |
| tree | 2fed7bf1ede7cc4acc737ccbde8136af8c97a22b | |
| parent | 0aa6fcb3c3bd2c13d15a96d964d0f0df44f954c7 (diff) | |
| download | eclipse.platform.ui-eb411f692ec4e08f41bd3e0df84d06810b39ede8.tar.gz eclipse.platform.ui-eb411f692ec4e08f41bd3e0df84d06810b39ede8.tar.xz eclipse.platform.ui-eb411f692ec4e08f41bd3e0df84d06810b39ede8.zip | |
bug 411465: EditorPart#isSaveOnCloseNeeded() not called when closing
Change-Id: I03b7cb331dad3fde7ea04acdd42963c8cf41e40a
| -rw-r--r-- | bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java | 3 | ||||
| -rw-r--r-- | bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindow.java | 2 |
2 files changed, 4 insertions, 1 deletions
diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java index a09e5ae3e1f..703bb82453d 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchPage.java @@ -3766,6 +3766,9 @@ public class WorkbenchPage extends CompatibleWorkbenchPage implements */ public boolean saveSaveable(ISaveablePart saveable, IWorkbenchPart part, boolean confirm, boolean closing) { + if (closing && !saveable.isSaveOnCloseNeeded()) { + return true; + } return SaveableHelper.savePart(saveable, part, legacyWindow, confirm); } diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindow.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindow.java index 168424d99dd..0551c748639 100644 --- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindow.java +++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchWindow.java @@ -529,7 +529,7 @@ public class WorkbenchWindow implements IWorkbenchWindow { IWorkbenchPart workbenchPart = ((CompatibilityPart) object).getPart(); if (workbenchPart instanceof ISaveablePart) { ISaveablePart saveablePart = (ISaveablePart) workbenchPart; - return page.saveSaveable(saveablePart, workbenchPart, confirm, false); + return page.saveSaveable(saveablePart, workbenchPart, confirm, true); } } return super.save(dirtyPart, confirm); |