Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-01-15Bug 540662 - [Tips] Preference to unsubscribe from a Tip ProviderY20200121-0055Y20200120-2315Y20200120-0020I20200122-1805I20200121-2225I20200121-1805I20200120-1800I20200120-0715I20200120-0530I20200120-0445I20200120-0355I20200120-0115I20200119-2330I20200119-1800I20200118-1800I20200117-1800I20200116-1800I20200116-0930I20200116-0330I20200116-0310I20200115-1800Wim Jongman1-36/+124
This change adds supports for disabling and enabling providers. The preference can be specified via product customization, with the following line: org.eclipse.tips.ide/disabled_providers=<comma sep list of provider ids> This patch provides additional coding to prevent initializing of the preferences on every call. Change-Id: I636c537ba4fbd51cee7915c9e452e2b03b5caa65 Signed-off-by: Wim Jongman <wim.jongman@remainsoftware.com>
2020-01-15Use System.lineSeparator()Lars Vogel2-2/+2
Benefit of this way rather than System.getProperty("line.separator") is that there are no security checks. Change-Id: Id647195dc018313e2347947e0f33151529684f33 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-13Iterate over Map.entrySet instead of Map.keySet and value searchI20200114-1805Lars Vogel5-10/+15
Faster than first getting the keys and afterwards reading the value. Done with Autorefactor https://github.com/JnRouvignac/AutoRefactor/ batch conversion using the iterate over Map.entrySet instead of Map.keySet and value search Change-Id: Iba43f18044c0a292989db477cf5f3df38871baa0 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-134.15 update for org.eclipse.tips.ide and org.eclipse.tips.featureY20200114-0045I20200113-1800Lars Vogel4-4/+4
Required for https://git.eclipse.org/r/155767 Change-Id: I9bd6458dc0e1121a64f0ed3adb38c7e43707be28 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-13Bug 559005 - Update platform to Jetty 9.4.25Alexander Kurtakov1-1/+1
Build jsps with jetty 9.4.25. Change-Id: I01b535751130189869da043fd31c4de9a9db142b Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-01-13Bug 559097 - Compile warnings in I20200113-0130Alexander Kurtakov3-7/+10
Fix platform.ua. Warnings in places where dealing with ServletResponse.getWriter are just suppressed as writer shouldn't be closed in this places. Change-Id: I2d18b200ec008f05aa67fa07cd22da18c6360d2e Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-01-10Removes unnecessary whitespace from user assistanceI20200113-0130I20200112-1800I20200111-1800I20200111-0325I20200111-0230I20200110-1805Lars Vogel3-7/+7
Change-Id: I87aae462d9e2aa50a34c14f0b64c3f5fa916a816 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-08Avoid unnecessary semicolonsLars Vogel3-4/+4
Done via batch cleanup with Source -> Clean-up -> Remove redundant semicolons Change-Id: I84fdb2b42b2ce16a16ff5216ecb4fa89ea007046 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-06Bug 552347: Universal Intro's Launchbar icons not high resolutionY20200108-0435S4_15_0_M1I20200110-0905I20200110-0200I20200109-2350I20200108-2240I20200108-0600I20200108-0025I20200107-1800I20200107-0600I20200106-1805Matthias Becker52-5/+5
Also provide high resolution icons for the remaining themes. Change-Id: I4bf5003ea1b0dd071c5d206fb2b5a0217cefda1a
2019-12-23Bug 558450 - Unanticipated comparator errors in I20191218-1805Y20200103-2350I20200106-0600I20200105-1800I20200105-0955I20200105-0600I20200104-1800I20200104-0625I20200104-0600I20200103-1800I20200102-1800I20200101-1800I20191231-1800I20191230-1800I20191229-2200I20191229-1800I20191228-1800I20191227-1800I20191226-1800I20191225-1800I20191224-1800I20191223-1800Sravan Kumar Lakkimsetti1-0/+12
Change-Id: I8342ebb904e0a887f253cd38a81e9c6b5f07f6eb Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2019-12-19Use lambdas where possibleI20191222-1800I20191221-2205I20191221-1800I20191220-1805Lars Vogel4-40/+23
Using the batch cleanup operation via Source -> Cleanup -> "Use lambdas where possible" from standard JDT. Change-Id: I93fa87e9eea2894832ce3b7b456adbca4a41ca48 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-12-19Bug 558450 - Unanticipated comparator errors in I20191218-1805I20191219-1800Sravan Kumar Lakkimsetti1-0/+1
Change-Id: I25a1809022f3bafc313c78e251989af31516b62d Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2019-12-17Bug 533828 - DefaultHelpUI is inconsitent and doesn't always show theI20191218-1805I20191218-0015I20191217-1800Johan Compagner2-10/+28
right help in the same way Change-Id: Icd77d6a86e3410d1854342a1b3efa6c44a27c7f5 Signed-off-by: Johan Compagner <jcompagner@gmail.com>
2019-12-12Removes unnecessary whitespace from ua bundlesY20191217-0600I20191216-1805I20191215-1800I20191214-1800I20191213-1805I20191213-0155I20191212-1800Lars Vogel6-7/+7
Done via cleanup action Change-Id: Iaaf14827c18694909821e251525de328739c585f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-12-12Bug 558222 - [GTK] Help "close" button has inverted colorsAlexander Kurtakov6-61/+24
Use real icon instead of drawing close button. Icons(including @2x) are close icons used in o.e.equinox.p2.ui.sdk.scheduler. Change-Id: I0b3be0c09177153e1d6e181dadacab01eede4795 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-12-12Use .isEmpty() instead of .size()==0 or .equals("")Carsten Hammer29-41/+40
Change-Id: I795082af563324917ba37929eb8a4dbc74ed7ce8 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-12-12Version updates for 4.15 streamKarsten Thoms8-8/+8
Required for https://git.eclipse.org/r/#/c/154033/ Change-Id: I4b457534fe168989a4f5d2f70a03caea25eb5ca3 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-12-11Removes reference to org.eclipse.core.runtime.compatibility from helpI20191211-1805Lars Vogel1-3/+1
content This plug-in has been deleted via Bug 394739 Change-Id: Ic2859e2f5ebbb9075ee0cb3f4f1df05b52dc2906
2019-12-11Bug 483370 - Replace FastStack from org.eclipse.help with Java 7 DequeLars Vogel2-54/+6
Change-Id: I3c16b0915c5a00e617aa4fa54e6a55575dc4e1e5 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-12-11Bug 446171 - [Intro] Remove usage of isPlain() method in IntroLaunchBarAlexander Kurtakov1-21/+0
Remove yet another unnecessary method. Change-Id: I95a103e91d74abef71830c9e988159b571f9cc39 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-12-10Remove unnecessary type specificationsCarsten Hammer12-13/+13
Since Java 7 the diamond operator can be used instead of explicit type parameters. Change-Id: I09b387aae76e2bed342456edccbc83c1bf006dac Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-12-10Version updates for 4.15 streamI20191211-0135Karsten Thoms4-4/+4
Required for - https://git.eclipse.org/r/#/c/154034/ Change-Id: I3aae683b7c426481e5c1c38ca2c9ab2bd8be959d Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-12-10Bug 446171 - Removes dead "simple" check and unused private methodsI20191210-1800Lars Vogel1-64/+6
During Bug 446171 I noticed that simple is always set to true and that several private methods can be removed Change-Id: I8880e20f1144d7ffeb1ee27b7808699395590efa Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-12-10Bug 446171 - [Intro] Remove usage of isPlain() method in IntroLaunchBarLars Vogel1-32/+7
Change-Id: I0ed8f528ef31e0e6eec3529174c41031ee333709 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-12-104.15 update for org.eclipse.ui.introLars Vogel2-2/+2
Required for https://git.eclipse.org/r/c/153944 Change-Id: Ica4398ca6627d355503d399bd7412fe98061104f
2019-12-104.15 version bump of org.eclipse.ua.testsLars Vogel2-2/+2
Required for https://git.eclipse.org/r/c/154154/ Change-Id: Id26a6907ef2afcd689435f3a2a85c0dc5c93b0f2 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-12-104.15 update for org.eclipse.help.baseLars Vogel2-2/+2
Change-Id: Ic9103132e183f614e6e587b383f50d879157a3bd Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-12-06Bug 553742 - POM and product version change for 4.15 releaseY20191208-2315I20191210-0230I20191209-2205I20191209-1600I20191209-1310I20191209-1130I20191209-1110Niraj Modi21-21/+21
Change-Id: I3896fa1b2bb991c6438d8c9f091271ff0f868cd6 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2019-11-23Bug 548250 - Javadoc problems in platform.uaY20191127-0140Y20191126-0500S4_14_0_RC2aS4_14_0_RC2S4_14_0_RC1R4_14I20191210-0610I20191204-1800I20191204-0600I20191203-1800I20191203-0600I20191202-1800I20191202-0600I20191201-1800I20191201-0600I20191130-1800I20191130-0600I20191129-1800I20191127-1800I20191127-0600I20191126-2315I20191126-1800I20191126-0600I20191125-1800I20191125-0600I20191124-1800I20191124-0600I20191123-1800I20191123-1115I20191123-0600R4_14_maintenancePaul Pazderski46-123/+150
Change-Id: I4fc959485fcb2ee5b20c4099c0f08532e66669da Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-22Bug 553363 - Update platform to Jetty 9.4.24I20191123-0100I20191122-1800Alexander Kurtakov1-1/+1
Use respective jspc maven plugin. Change-Id: I8ea5e398ba6930f6366f52c0a764e95fdd3b84ba Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-11-19Bug 551402 - Missing pack200 files in I-builds repositoryI20191120-2335I20191120-1800I20191120-0840I20191120-0600I20191119-2200I20191119-1800I20191119-1250I20191119-1235I20191119-1215I20191119-1155I20191119-0850I20191119-0725I20191119-0510Alexander Kurtakov2-2/+2
Force republish due to missing pack files in repo. Change-Id: I855c30285db80416d2d62368506a09837d9bf14e Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-11-07Bug 552768 - Avoid showing the tips of day layout job to the userY20191112-0030Y20191107-0440I20191119-0315I20191119-0020I20191118-2230I20191118-1800I20191118-0600I20191117-1800I20191117-0600I20191116-1800I20191116-0600I20191115-1800I20191114-1800I20191114-0410I20191113-2315I20191113-1800I20191112-1800I20191111-1800I20191111-0920I20191111-0655I20191111-0435I20191111-0145I20191110-1800I20191109-1800I20191109-0650I20191109-0330I20191108-1800I20191107-1800Lars Vogel1-0/+1
We set this job to system so that the regular user does not have to worry about it. Change-Id: Ib7262f90d98fcb5ca5acb38c96ec08807812fa58 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-11-06Bug 548801 - [Tip of the day] Avoid initial Layout Shell call duringY20191107-0420I20191106-1805Lars Vogel1-2/+30
startup This mitigates the hack to layout the Shell to show the update icon in the toolbar. We do no layout call if the workbench starts up, that avoids UI freezes in case the WS needs to be build. New tips still trigger a layout call but muliple calls arriving within 5 secs will be combined Tests done: Preference: Indicate new tips in the status bar Test scenario: new tips are present at startup -> Toolbar icon is shown to the user Test scenerio: tips are read by the user --> Toolbar icon is hidden For this test I removed the SWTTips from plugin.xml as they provide infinite tips. Test scenario: delay tip provider and check if icon is still shown Using private void load(TipProvider provider) { try { Thread.sleep(20000); } catch (InterruptedException e) { // TODO Auto-generated catch block e.printStackTrace(); } Also works. Change-Id: If470cc10cdade32132c4695796b4b74a64cf55ba Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-11-04Removes redundant semicolon from org.eclipse.help.baseI20191105-1800I20191105-0025I20191104-1800Lars Vogel1-1/+1
Change-Id: I7a8fab18a7133e2cb68fccfea0bda2d3c396ebff Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-10-30Bug 549166 - Tests running in tips UI jobI20191103-1800I20191102-1800I20191101-1800I20191101-0300I20191031-1800I20191031-1325Simeon Andreev3-12/+2
In org.eclipse.tips.ui.internal.TipComposite, methods loadTimeOutScript() and loadWaitingScript() will process SWT display events. This code runs during org.eclipse.tips.ide.internal.Startup$2.runInUIThread, when showing the tips dialog on start-up. As a result, the Eclipse test harness can run tests in this UA start-up UI job. From that point on, tests that wait for jobs to finish will hang forever, since the tests themselves run inside a UI job. This change removes processing of display events in tips UI job. This prevents Eclipse tests from running in a tips UI job, which in turn results into a "hanging" tips UI job. Change-Id: Ica968412ccc427e35d68c12e95efd14da5d9254d Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2019-10-25Bug 552347 - Universal Intro's Launchbar does not use high resolutionI20191030-1800I20191030-0010I20191029-1800I20191028-1800Matthias Becker10-0/+0
icons Change-Id: I8bdbe9dbc1eb8068f876116e24911f4d4a2c87a3 Signed-off-by: Matthias Becker <ma.becker@sap.com>
2019-10-25Bug 552395 - Update platform to Jetty 9.4.22I20191027-1800I20191026-1800I20191025-1805Alexander Kurtakov1-1/+1
Build jsps with the newer jspc maven plugin. Change-Id: I52dc81736119b866703aa1bfe6b3db3ecfd601c2 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-10-24Foreach conversion in o.e.help.base.I20191024-1800Alexander Kurtakov33-270/+195
Change-Id: I1eef612ed9ba50a10a103ee29934cb200dc44a3f Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-10-24Bug 546446 - buildhelpIndex ant task not reporting which file breaksAndrew Obuchowicz1-2/+2
Replace system.out calls with system.err so that files which break indexing will be output to console during build Change-Id: I60e0a737faf4762367159ec0a41e72572f8e0882 Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2019-10-23Bug 540268: [Solstice] firststeps16.png missing for launchbarMatthias Becker6-2/+2
Add missing icons. This also adds the high resolution version of that icons. Change-Id: I3115e72870482497f894127610a014c86db760c5 Signed-off-by: Matthias Becker <ma.becker@sap.com>
2019-10-16Bug 492993 - Welcome page title hidden on magnificationI20191023-1810I20191022-1800I20191022-0405I20191020-1800I20191019-1800I20191018-1800I20191018-0720I20191016-1800Brian de Alwis2-1/+4
Set explicit header text size and mark as !important Change-Id: Icd2522135aabcfa05359c50b8934bbce04c8deb9
2019-10-04Bug 551763 - Update platform to Jetty 9.4.21S4_14_0_M1I20191015-1800I20191014-1800I20191013-1800I20191012-1800I20191011-1800I20191009-1800I20191009-0600I20191009-0300I20191008-1800I20191008-0600I20191007-1800I20191007-0625I20191007-0430I20191006-1800I20191006-0600Alexander Kurtakov1-1/+1
Build jsps with respective jspc maven plugin. Change-Id: I3fb75a0e9d98baa691f23da62dea37f4a89768f7 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-10-02Bug 551680 - [Webapp][Security] XSS in query paramI20191003-1800I20191002-1800Laurence Labonté1-0/+1
Use "URLEncoder.encode()" to encode the query param Change-Id: I72d44b483e4ee87313fd931e82fefdd33ddbaa7a Signed-off-by: Laurence Labonté <laurence.labonte@xmedius.com>
2019-09-25Bug 551438 - Fix files that have ended up with CRLF in the gitI20191002-0100I20191001-1800I20190930-1800I20190929-1800I20190928-1800I20190928-0515I20190928-0205I20190928-0000I20190927-1800I20190927-1530I20190927-0255I20190927-0225I20190927-0145I20190926-1800I20190926-0625Ed Merks27-1682/+1682
repository Change-Id: I83cf17686f742f6fde0e77883355e7dce5f5724c Signed-off-by: Ed Merks <ed.merks@gmail.com>
2019-09-18Bug 551174 - Comparator errors in 4.14 I build - I20190917-1800I20190924-1800I20190923-1800I20190923-0615I20190922-1800I20190921-1800I20190920-1800I20190919-1800I20190919-0850I20190918-1800I20190918-0300Alexander Kurtakov1-1/+2
Change-Id: I2eef25cdcc4a16fcbfba510fab7dc784bda6fd92 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-09-17Remove unused api problem filter.I20190917-1800Alexander Kurtakov3-13/+2
Change-Id: I945edf3bb38f1fd50622538b1159fb15b2b9c76e Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-09-17Bug 546446 - buildhelpIndex ant task not reporting which file breaksAlexander Kurtakov4-3/+36
indexing Make sure that IndexAssembler doesn't accept broken xml. Change-Id: I67bdf6d9ceb3439a7f366a293548d5947162bad5 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-09-17Cleanup generification warnings.Alexander Kurtakov8-13/+18
Some fixed and what can't be suppressed. Change-Id: Ia21b1390ab6862c292bb3916ce6ffcfd60915796 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-09-14550830 Fixes wrong NLS packageI20190916-1800I20190915-1800I20190914-1800Lars Vogel1-1/+1
Change-Id: I4508871d904c45798ca3c615032ed8137157cae0 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-09-14Bug 550788 - Replace Tip of the day Early Startup extension with an OSGiLars Vogel9-16/+38
service Also renames Startup to TipsStartupService Also includes the version increase for the 4.14 stream Activating the project specific preferences Change-Id: Ibc830435e520eb2a4a39257e5da423941028c837 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>

Back to the top