Bug 550037 - Use StringBuilder instead of StringBuffer inI20190814-1800

eclipse.platform.ua

Change-Id: I02a691f97d114be1ad17b2a996f38f05bc73e5f4
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>

3 files changed, 19 insertions, 19 deletions

diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/html/HTMLUtil.java b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/html/HTMLUtil.java
index e6b1df8da..5e81ae827 100644
--- a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/html/HTMLUtil.java
+++ b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/html/HTMLUtil.java
@@ -133,8 +133,8 @@ public final class HTMLUtil {
 	 *            the value of the attribute
 	 * @return
 	 */
-	public static StringBuffer createAttribute(String attrName, String attrValue) {
-		StringBuffer attribute = new StringBuffer();
+	public static StringBuilder createAttribute(String attrName, String attrValue) {
+		StringBuilder attribute = new StringBuilder();
 		if (attrName != null && attrValue != null) {
 			attribute.append(attrName).append(IIntroHTMLConstants.EQUALS)
 					.append(IIntroHTMLConstants.QUOTE).append(attrValue)
@@ -143,17 +143,17 @@ public final class HTMLUtil {
 		return attribute;
 	}
 
-	public static StringBuffer openHTMLStartTag(String elementName) {
-		return new StringBuffer().append(IIntroHTMLConstants.LT).append(
+	public static StringBuilder openHTMLStartTag(String elementName) {
+		return new StringBuilder().append(IIntroHTMLConstants.LT).append(
 				elementName);
 	}
 
-	public static StringBuffer closeHTMLTag() {
+	public static StringBuilder closeHTMLTag() {
 		return closeHTMLTag(true);
 	}
 
-	public static StringBuffer closeHTMLTag(boolean newLine) {
-		StringBuffer closing = new StringBuffer()
+	public static StringBuilder closeHTMLTag(boolean newLine) {
+		StringBuilder closing = new StringBuilder()
 				.append(IIntroHTMLConstants.GT);
 		if (newLine)
 			closing.append(IIntroHTMLConstants.NEW_LINE);
diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/loader/ModelLoaderUtil.java b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/loader/ModelLoaderUtil.java
index c68c02b3d..43e91980a 100644
--- a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/loader/ModelLoaderUtil.java
+++ b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/loader/ModelLoaderUtil.java
@@ -165,11 +165,11 @@ public class ModelLoaderUtil {
 	 * @param element
 	 * @return
 	 */
-	public static StringBuffer createPathToElementKey(
+	public static StringBuilder createPathToElementKey(
 			AbstractIntroIdElement element, boolean full) {
 		if (element.getId() == null)
 			return null;
-		StringBuffer buffer = new StringBuffer(element.getId());
+		StringBuilder buffer = new StringBuilder(element.getId());
 		AbstractBaseIntroElement parent = (AbstractBaseIntroElement) element
 			.getParent();
 		while (parent != null
diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/swt/PageStyleManager.java b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/swt/PageStyleManager.java
index 4a5461bad..a1950bd6c 100644
--- a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/swt/PageStyleManager.java
+++ b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/swt/PageStyleManager.java
@@ -201,7 +201,7 @@ public class PageStyleManager extends SharedStyleManager {
 
 	private int getIntProperty(AbstractBaseIntroElement element,
 			String qualifier, int defaultValue) {
-		StringBuffer buff = ModelLoaderUtil.createPathToElementKey(element, true);
+		StringBuilder buff = ModelLoaderUtil.createPathToElementKey(element, true);
 		if (buff == null)
 			return defaultValue;
 		String key = buff.append(qualifier).toString();
@@ -210,7 +210,7 @@ public class PageStyleManager extends SharedStyleManager {
 
 	private boolean getBooleanProperty(AbstractBaseIntroElement element,
 			String qualifier, boolean defaultValue) {
-		StringBuffer buff = ModelLoaderUtil.createPathToElementKey(element, true);
+		StringBuilder buff = ModelLoaderUtil.createPathToElementKey(element, true);
 		if (buff == null)
 			return defaultValue;
 		String key = buff.append(qualifier).toString();
@@ -255,7 +255,7 @@ public class PageStyleManager extends SharedStyleManager {
 	 * @return
 	 */
 	public String getDescription(IntroGroup group) {
-		StringBuffer buff = ModelLoaderUtil.createPathToElementKey(group, true);
+		StringBuilder buff = ModelLoaderUtil.createPathToElementKey(group, true);
 		if (buff == null)
 			return null;
 		String key = buff.append(".description-id").toString(); //$NON-NLS-1$
@@ -395,7 +395,7 @@ public class PageStyleManager extends SharedStyleManager {
 
 
 	public Color getColor(FormToolkit toolkit, AbstractBaseIntroElement element) {
-		StringBuffer buff = ModelLoaderUtil.createPathToElementKey(element, true);
+		StringBuilder buff = ModelLoaderUtil.createPathToElementKey(element, true);
 		if (buff == null)
 			return null;
 		String key = buff.append(".font.fg").toString(); //$NON-NLS-1$
@@ -403,7 +403,7 @@ public class PageStyleManager extends SharedStyleManager {
 	}
 
 	public Color getBackgrond(FormToolkit toolkit, AbstractBaseIntroElement element) {
-		StringBuffer buff = ModelLoaderUtil.createPathToElementKey(element, true);
+		StringBuilder buff = ModelLoaderUtil.createPathToElementKey(element, true);
 		if (buff == null)
 			return null;
 		String key = buff.append(".bg").toString(); //$NON-NLS-1$
@@ -413,7 +413,7 @@ public class PageStyleManager extends SharedStyleManager {
 	public boolean isBold(IntroText text) {
 		String value = null;
 		/*
-		StringBuffer buff = ModelLoaderUtil.createPathToElementKey(text, true);
+		StringBuilder buff = ModelLoaderUtil.createPathToElementKey(text, true);
 		if (buff != null) {
 			String key = buff.append(".font.bold").toString(); //$NON-NLS-1$
 			value = getProperty(key);
@@ -436,7 +436,7 @@ public class PageStyleManager extends SharedStyleManager {
 	}
 
 	private String getPropertyValue(AbstractIntroIdElement element, String suffix) {
-		StringBuffer buff = ModelLoaderUtil.createPathToElementKey(element, true);
+		StringBuilder buff = ModelLoaderUtil.createPathToElementKey(element, true);
 		if (buff != null) {
 			String key = buff.append(suffix).toString();
 			String value = getProperty(key);
@@ -492,13 +492,13 @@ public class PageStyleManager extends SharedStyleManager {
 
 	private String createImageKey(AbstractIntroPage page, IntroLink link,
 			String qualifier) {
-		StringBuffer buff = null;
+		StringBuilder buff = null;
 		if (link != null) {
 			buff = ModelLoaderUtil.createPathToElementKey(link, true);
 			if (buff == null)
 				return ""; //$NON-NLS-1$
 		} else {
-			buff = new StringBuffer();
+			buff = new StringBuilder();
 			buff.append(page.getId());
 		}
 		buff.append("."); //$NON-NLS-1$
@@ -521,7 +521,7 @@ public class PageStyleManager extends SharedStyleManager {
 
 	public Image getImage(IntroImage introImage) {
 		String imageLocation = introImage.getSrcAsIs();
-		StringBuffer buff = ModelLoaderUtil.createPathToElementKey(introImage, true);
+		StringBuilder buff = ModelLoaderUtil.createPathToElementKey(introImage, true);
 		String key;
 		if (buff == null) {
 			key = "//" + imageLocation; //$NON-NLS-1$