Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLars Vogel2018-06-04 10:04:50 +0000
committerLars Vogel2018-06-04 10:05:53 +0000
commit5603f0c702ee27dc07ff6bd8dccd6928fdc1d882 (patch)
tree861f79ff17167c0d13a6c7fa17dad76853a014cb /org.eclipse.tips.ide
parentd571994b35dc7f1f911e7f2fd14ee7f304803b1d (diff)
downloadeclipse.platform.ua-5603f0c702ee27dc07ff6bd8dccd6928fdc1d882.tar.gz
eclipse.platform.ua-5603f0c702ee27dc07ff6bd8dccd6928fdc1d882.tar.xz
eclipse.platform.ua-5603f0c702ee27dc07ff6bd8dccd6928fdc1d882.zip
Bug 535437 - [Tips] Run cleanup actions to tips and enhance save actions
Change-Id: I0d1741a53928df3c82828bac83b470f5cc756ce2 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
Diffstat (limited to 'org.eclipse.tips.ide')
-rw-r--r--org.eclipse.tips.ide/.settings/org.eclipse.jdt.ui.prefs12
-rw-r--r--org.eclipse.tips.ide/src/org/eclipse/tips/ide/internal/provider/Tip6_ActionsTip.java3
2 files changed, 8 insertions, 7 deletions
diff --git a/org.eclipse.tips.ide/.settings/org.eclipse.jdt.ui.prefs b/org.eclipse.tips.ide/.settings/org.eclipse.jdt.ui.prefs
index 52fe6a983..def5bb091 100644
--- a/org.eclipse.tips.ide/.settings/org.eclipse.jdt.ui.prefs
+++ b/org.eclipse.tips.ide/.settings/org.eclipse.jdt.ui.prefs
@@ -14,7 +14,7 @@ sp_cleanup.always_use_parentheses_in_expressions=false
sp_cleanup.always_use_this_for_non_static_field_access=false
sp_cleanup.always_use_this_for_non_static_method_access=false
sp_cleanup.convert_functional_interfaces=true
-sp_cleanup.convert_to_enhanced_for_loop=false
+sp_cleanup.convert_to_enhanced_for_loop=true
sp_cleanup.correct_indentation=false
sp_cleanup.format_source_code=true
sp_cleanup.format_source_code_changes_only=true
@@ -34,15 +34,15 @@ sp_cleanup.qualify_static_member_accesses_through_subtypes_with_declaring_class=
sp_cleanup.qualify_static_member_accesses_with_declaring_class=false
sp_cleanup.qualify_static_method_accesses_with_declaring_class=false
sp_cleanup.remove_private_constructors=true
-sp_cleanup.remove_redundant_modifiers=false
+sp_cleanup.remove_redundant_modifiers=true
sp_cleanup.remove_redundant_type_arguments=true
sp_cleanup.remove_trailing_whitespaces=true
sp_cleanup.remove_trailing_whitespaces_all=true
sp_cleanup.remove_trailing_whitespaces_ignore_empty=false
sp_cleanup.remove_unnecessary_casts=true
-sp_cleanup.remove_unnecessary_nls_tags=false
-sp_cleanup.remove_unused_imports=false
-sp_cleanup.remove_unused_local_variables=false
+sp_cleanup.remove_unnecessary_nls_tags=true
+sp_cleanup.remove_unused_imports=true
+sp_cleanup.remove_unused_local_variables=true
sp_cleanup.remove_unused_private_fields=true
sp_cleanup.remove_unused_private_members=false
sp_cleanup.remove_unused_private_methods=true
@@ -50,7 +50,7 @@ sp_cleanup.remove_unused_private_types=true
sp_cleanup.sort_members=false
sp_cleanup.sort_members_all=false
sp_cleanup.use_anonymous_class_creation=false
-sp_cleanup.use_blocks=false
+sp_cleanup.use_blocks=true
sp_cleanup.use_blocks_only_for_return_and_throw=false
sp_cleanup.use_lambda=true
sp_cleanup.use_parentheses_in_expressions=false
diff --git a/org.eclipse.tips.ide/src/org/eclipse/tips/ide/internal/provider/Tip6_ActionsTip.java b/org.eclipse.tips.ide/src/org/eclipse/tips/ide/internal/provider/Tip6_ActionsTip.java
index aa8e07e26..a41cf608c 100644
--- a/org.eclipse.tips.ide/src/org/eclipse/tips/ide/internal/provider/Tip6_ActionsTip.java
+++ b/org.eclipse.tips.ide/src/org/eclipse/tips/ide/internal/provider/Tip6_ActionsTip.java
@@ -57,8 +57,9 @@ public class Tip6_ActionsTip extends Tip implements IHtmlTip {
Runnable runner2 = () -> Display.getDefault().syncExec(() -> {
PreferenceDialog pref = PreferencesUtil.createPreferenceDialogOn(
PlatformUI.getWorkbench().getActiveWorkbenchWindow().getShell(), "myPreferencePage", null, null);
- if (pref != null)
+ if (pref != null) {
pref.open();
+ }
});
ArrayList<TipAction> actions = new ArrayList<>();
actions.add(new TipAction("Clock", "What is the time?", clock, getImage("icons/clock.png")));

Back to the top