Bug 531792: [Tips] API cleanup

* Moved TipManager to internal
* Fixed all arising issues
* Added save read tips to preferences

Change-Id: Id557ab165f63ecabf87460671d1ec8e7ba5de522
Signed-off-by: Wim Jongman <wim.jongman@remainsoftware.com>

2 files changed, 13 insertions, 13 deletions

diff --git a/org.eclipse.tips.examples/src/org/eclipse/tips/examples/swttip/SwtTipImpl.java b/org.eclipse.tips.examples/src/org/eclipse/tips/examples/swttip/SwtTipImpl.java
index faeb61c3b..6d994e4b8 100644
--- a/org.eclipse.tips.examples/src/org/eclipse/tips/examples/swttip/SwtTipImpl.java
+++ b/org.eclipse.tips.examples/src/org/eclipse/tips/examples/swttip/SwtTipImpl.java
@@ -44,7 +44,7 @@ public class SwtTipImpl extends Tip implements ISwtTip {
 
 	private String fSubject;
 
-	public SwtTipImpl(String providerId, int  number) {
+	public SwtTipImpl(String providerId, long number) {
 		super(providerId);
 		fSubject = "This is a tip " + number;
 	}
diff --git a/org.eclipse.tips.examples/src/org/eclipse/tips/examples/swttip/SwtTipsProvider.java b/org.eclipse.tips.examples/src/org/eclipse/tips/examples/swttip/SwtTipsProvider.java
index 5424fdd68..3c7280dd8 100644
--- a/org.eclipse.tips.examples/src/org/eclipse/tips/examples/swttip/SwtTipsProvider.java
+++ b/org.eclipse.tips.examples/src/org/eclipse/tips/examples/swttip/SwtTipsProvider.java
@@ -26,9 +26,10 @@ import org.eclipse.tips.core.internal.LogUtil;
 import org.osgi.framework.Bundle;
 import org.osgi.framework.FrameworkUtil;
 
+@SuppressWarnings("restriction")
 public class SwtTipsProvider extends TipProvider {
 
-	private TipImage fImage64, fImage48;
+	private TipImage fImage;
 	private int fCounter;
 	private boolean fFetching;
 
@@ -43,8 +44,8 @@ public class SwtTipsProvider extends TipProvider {
 	}
 
 	@Override
-	public synchronized List<Tip> getTips(boolean pFilter) {
-		List<Tip> tips = super.getTips(pFilter);
+	public synchronized List<Tip> getTips() {
+		List<Tip> tips = super.getTips();
 		if (tips.size() <= 1) {
 			Job job = new Job(getDescription() + " is getting more tips.") {
 
@@ -61,18 +62,17 @@ public class SwtTipsProvider extends TipProvider {
 
 	@Override
 	public TipImage getImage() {
-		if (fImage48 == null) {
+		if (fImage == null) {
 			Bundle bundle = FrameworkUtil.getBundle(getClass());
 			try {
-				fImage48 = new TipImage(bundle.getEntry("icons/48/swt.png")).setAspectRatio(1);
+				fImage = new TipImage(bundle.getEntry("icons/48/swt.png")).setAspectRatio(1);
 			} catch (IOException e) {
 				getManager().log(LogUtil.error(getClass(), e));
 			}
 		}
-		return fImage48;
+		return fImage;
 	}
 
-
 	@Override
 	public synchronized IStatus loadNewTips(IProgressMonitor pMonitor) {
 		SubMonitor subMonitor = SubMonitor.convert(pMonitor);
@@ -82,11 +82,11 @@ public class SwtTipsProvider extends TipProvider {
 		try {
 			subMonitor.beginTask("Loading Tips for " + getDescription(), -1);
 			List<Tip> tips = new ArrayList<>();
-			tips.add(new SwtTipImpl(getID(),1));
-			tips.add(new SwtTipImpl(getID(),2));
-			tips.add(new SwtTipImpl(getID(),3));
-			tips.add(new SwtTipImpl(getID(),4));
-			tips.add(new SwtTipImpl(getID(),5));
+			tips.add(new SwtTipImpl(getID(), System.currentTimeMillis() + 100));
+			tips.add(new SwtTipImpl(getID(), System.currentTimeMillis() + 200));
+			tips.add(new SwtTipImpl(getID(), System.currentTimeMillis() + 300));
+			tips.add(new SwtTipImpl(getID(), System.currentTimeMillis() + 400));
+			tips.add(new SwtTipImpl(getID(), System.currentTimeMillis() + 500));
 			addTips(tips);
 			return Status.OK_STATUS;
 		} finally {