Bug 535391 - [Tips] Do not open tips on startup if there are no new tipsI20180601-0915I20180601-0900

* Tip Dialog is not shown on startup if there or no new tips
* Improved logging/tracing
* Load check method had a timing problem

Change-Id: Ic7df5eb0649f73857b7c42c6b36f3f7210f8af4d
Signed-off-by: Wim Jongman <wim.jongman@remainsoftware.com>

2 files changed, 5 insertions, 5 deletions

diff --git a/org.eclipse.tips.core/src/org/eclipse/tips/core/ITipManager.java b/org.eclipse.tips.core/src/org/eclipse/tips/core/ITipManager.java
index 16007f3fc..8e2e64983 100644
--- a/org.eclipse.tips.core/src/org/eclipse/tips/core/ITipManager.java
+++ b/org.eclipse.tips.core/src/org/eclipse/tips/core/ITipManager.java
@@ -84,10 +84,10 @@ public interface ITipManager {
 	public boolean isOpen();
 
 	/**
-	 * Indicates if this manager has providers with tips (based on the read or
-	 * unread requirement). Be aware that subsequent calls to this method may return
-	 * different results based on the async nature of loading providers.
-	 * 
+	 * Indicates if this manager has providers with unread tips. Be aware that
+	 * subsequent calls to this method may return different results based on the
+	 * async nature of loading providers.
+	 *
 	 * @return true if this {@link TipManager} has providers with tips.
 	 * @see TipProvider#getTips()
 	 */
diff --git a/org.eclipse.tips.core/src/org/eclipse/tips/core/internal/TipManager.java b/org.eclipse.tips.core/src/org/eclipse/tips/core/internal/TipManager.java
index f8bb83f7e..f466dd330 100644
--- a/org.eclipse.tips.core/src/org/eclipse/tips/core/internal/TipManager.java
+++ b/org.eclipse.tips.core/src/org/eclipse/tips/core/internal/TipManager.java
@@ -275,7 +275,7 @@ public abstract class TipManager implements ITipManager {
 	@Override
 	public boolean hasContent() {
 		for (TipProvider provider : getProviders()) {
-			if (provider.isReady() && !provider.getTips().isEmpty()) {
+			if (provider.isReady() && !provider.getTips(tip -> !isRead(tip)).isEmpty()) {
 				return true;
 			}
 		}