Bug 535975 - [Tips] Minor refactoringI20180618-0800

* Job titles shall be short and not sentences, they are displayed in the
status bar and progress view
* an ellipsis has 3 dots (at least in English)
* fix grammar and typos
* use MessageFormat instead of relying on the message in the properties
file ending with a blank character, this can go wrong to easily

Change-Id: Idfd85865d789d64a1c6f74fac345c41c303b6e52
Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>

2 files changed, 8 insertions, 12 deletions

diff --git a/org.eclipse.tips.core/src/org/eclipse/tips/core/TipProvider.java b/org.eclipse.tips.core/src/org/eclipse/tips/core/TipProvider.java
index 86221f385..e1a3022ac 100644
--- a/org.eclipse.tips.core/src/org/eclipse/tips/core/TipProvider.java
+++ b/org.eclipse.tips.core/src/org/eclipse/tips/core/TipProvider.java
@@ -28,7 +28,7 @@ import org.eclipse.tips.core.internal.LogUtil;
  * manage its tips. Examples of managing tips are:
  *
  * <ul>
- * <li>Loading tips from the internet</li>
+ * <li>Loading tips from the Internet</li>
  * <li>Serve next, previous and current tip on request</li>
  * </ul>
  *
@@ -36,7 +36,7 @@ import org.eclipse.tips.core.internal.LogUtil;
  * TipManager will insert itself by calling {@link #setManager(ITipManager)}.
  * Then the TipManager will asynchronous call this providers'
  * {@link #loadNewTips(IProgressMonitor)} method. The job of the load() method
- * is to do long work like fetching new tips from the internet and storing them
+ * is to do long work like fetching new tips from the Internet and storing them
  * locally. There is no defined method on how tips should be stored locally,
  * implementers are free to do what is needed.
  *
@@ -69,22 +69,18 @@ public abstract class TipProvider {
 	 * requirement to only serve read tips. Subclasses may replace this predicate if
 	 * they want to add some additional tests.
 	 */
-	private Predicate<Tip> fUnreadTipPredicate = new Predicate<Tip>() {
-
-		@Override
-		public boolean test(Tip pTip) {
-			if (getManager().mustServeReadTips()) {
-				return true;
-			}
-			return !getManager().isRead(pTip);
+	private Predicate<Tip> fUnreadTipPredicate = pTip -> {
+		if (getManager().mustServeReadTips()) {
+			return true;
 		}
+		return !getManager().isRead(pTip);
 	};
 
 	/**
 	 * The zero argument constructor must be able to instantiate the TipProvider.
 	 * This method may also be used to quickly set the available tips by calling the
 	 * {@link #setTips(List)} method. The constructor may not be used to load tips
-	 * from the internet. Use the {@link #loadNewTips(IProgressMonitor)} method for
+	 * from the Internet. Use the {@link #loadNewTips(IProgressMonitor)} method for
 	 * this purpose.
 	 *
 	 * @see #loadNewTips(IProgressMonitor)
diff --git a/org.eclipse.tips.core/src/org/eclipse/tips/core/internal/messages.properties b/org.eclipse.tips.core/src/org/eclipse/tips/core/internal/messages.properties
index 75f6c7491..30aa0af29 100644
--- a/org.eclipse.tips.core/src/org/eclipse/tips/core/internal/messages.properties
+++ b/org.eclipse.tips.core/src/org/eclipse/tips/core/internal/messages.properties
@@ -1,5 +1,5 @@
 FinalTip_2=No more tips
 FinalTip_3=There are no more tips
-FinalTip_4=This provider has no more new tips. You can toggle the <b>Unread</b> checkbox below or select another provider.
+FinalTip_4=This provider has no more new tips. You can toggle the <b>Unread</b> checkbox below or select another provider by clicking another of the big icons at the bottom of this dialog.
 TipManager_0=Registering provider ID {0} with description {1}.
 TipManager_2=This TipManager is disposed.