diff options
author | Lars Vogel | 2021-04-09 05:47:23 +0000 |
---|---|---|
committer | Alexander Kurtakov | 2021-04-09 17:26:43 +0000 |
commit | b34414f78e74cfe1d007079c5990bf9f3a2bc3de (patch) | |
tree | 233d7af3215f7b146ed5c7f9749a2bad31b6dbb9 | |
parent | f107358c39302aa8931e5806935b17b1062b414d (diff) | |
download | eclipse.platform.ua-b34414f78e74cfe1d007079c5990bf9f3a2bc3de.tar.gz eclipse.platform.ua-b34414f78e74cfe1d007079c5990bf9f3a2bc3de.tar.xz eclipse.platform.ua-b34414f78e74cfe1d007079c5990bf9f3a2bc3de.zip |
[dogfooding][cleanup] Use static inner class clean up for
help.ui
Using this cleanup brings:
- It reviews the feature
- For optimization: small memory usage reduction as the outer pointer
is removed
Change-Id: Ife2ca6e5eadfbaa78fbe98af226551864fa7772d
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
12 files changed, 16 insertions, 16 deletions
diff --git a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/ContextHelpDialog.java b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/ContextHelpDialog.java index d4baa02e1..8945a54b9 100644 --- a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/ContextHelpDialog.java +++ b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/ContextHelpDialog.java @@ -473,7 +473,7 @@ public class ContextHelpDialog { }); } - public class Description extends StyledText { + public static class Description extends StyledText { /** * @param parent * @param style diff --git a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/DefaultHelpUI.java b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/DefaultHelpUI.java index 99062d9c9..d79ca04ac 100644 --- a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/DefaultHelpUI.java +++ b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/DefaultHelpUI.java @@ -70,7 +70,7 @@ public class DefaultHelpUI extends AbstractHelpUI { private static final String HELP_VIEW_ID = "org.eclipse.help.ui.HelpView"; //$NON-NLS-1$ - class ExternalWorkbenchBrowser implements IBrowser { + static class ExternalWorkbenchBrowser implements IBrowser { public ExternalWorkbenchBrowser() { } diff --git a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/HelpActivitySupport.java b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/HelpActivitySupport.java index a62aebbf6..d0e62268b 100644 --- a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/HelpActivitySupport.java +++ b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/HelpActivitySupport.java @@ -47,7 +47,7 @@ public class HelpActivitySupport implements IHelpActivitySupport { private boolean filteringEnabled; private ActivityDescriptor activityDescriptor; - class ActivityDescriptor { + static class ActivityDescriptor { private IConfigurationElement config; private String documentMessage; private boolean needsLiveHelp; diff --git a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/preferences/ICTable.java b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/preferences/ICTable.java index c3a3d41c1..172126c33 100644 --- a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/preferences/ICTable.java +++ b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/preferences/ICTable.java @@ -139,7 +139,7 @@ public class ICTable { * for the Table. This class implements IRemoteHelpListViewer interface an * registers itself with RemoteICList */ - class ICContentProvider implements IStructuredContentProvider + static class ICContentProvider implements IStructuredContentProvider { private List<IC> content = new ArrayList<>(); @@ -161,7 +161,7 @@ public class ICTable { } - public class ICLabelProvider extends LabelProvider implements ITableLabelProvider { + public static class ICLabelProvider extends LabelProvider implements ITableLabelProvider { @Override public Image getColumnImage(Object element, int columnIndex) { diff --git a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/AllTopicsPart.java b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/AllTopicsPart.java index b357aa18f..ed5c3fac5 100644 --- a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/AllTopicsPart.java +++ b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/AllTopicsPart.java @@ -134,7 +134,7 @@ public class AllTopicsPart extends HyperlinkTreePart { } } - class EmptyContainerFilter extends ViewerFilter { + static class EmptyContainerFilter extends ViewerFilter { @Override public boolean select(Viewer viewer, Object parentElement, diff --git a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/ContextHelpPart.java b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/ContextHelpPart.java index 36f3be3b2..a4fcc15ea 100644 --- a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/ContextHelpPart.java +++ b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/ContextHelpPart.java @@ -424,7 +424,7 @@ public class ContextHelpPart extends SectionPart implements IHelpPart { return buff.length() > 0 ? buff.toString().trim() : null; } - private class SearchTerms { + private static class SearchTerms { private List<String> terms = new ArrayList<>(); private Set<String> termSet = new HashSet<>(); diff --git a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/EngineTypeWizardPage.java b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/EngineTypeWizardPage.java index 5664871b4..1108bcaee 100644 --- a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/EngineTypeWizardPage.java +++ b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/EngineTypeWizardPage.java @@ -50,7 +50,7 @@ public class EngineTypeWizardPage extends WizardPage { } } - class EngineLabelProvider extends LabelProvider implements ITableLabelProvider { + static class EngineLabelProvider extends LabelProvider implements ITableLabelProvider { @Override public String getText(Object obj) { diff --git a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/HyperlinkTreePart.java b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/HyperlinkTreePart.java index 143251a09..e4acfb60e 100644 --- a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/HyperlinkTreePart.java +++ b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/HyperlinkTreePart.java @@ -71,7 +71,7 @@ public abstract class HyperlinkTreePart extends AbstractFormPart implements } } - private class ScopeFilter extends ViewerFilter { + private static class ScopeFilter extends ViewerFilter { public ScopeFilter(AbstractHelpScope scope) { this.scope = scope; diff --git a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/IndexPart.java b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/IndexPart.java index 20c1a3942..08b197033 100644 --- a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/IndexPart.java +++ b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/IndexPart.java @@ -110,7 +110,7 @@ public class IndexPart extends HyperlinkTreePart implements IHelpUIConstants { return message; } - class RoleFilter extends ViewerFilter { + static class RoleFilter extends ViewerFilter { @Override public boolean select(Viewer viewer, Object parentElement, diff --git a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/ReusableHelpPart.java b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/ReusableHelpPart.java index cadb5430b..8b47153ad 100644 --- a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/ReusableHelpPart.java +++ b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/ReusableHelpPart.java @@ -688,7 +688,7 @@ public class ReusableHelpPart implements IHelpUIConstants, IActivityManagerListe } } - class RoleFilter extends ViewerFilter { + static class RoleFilter extends ViewerFilter { @Override public boolean select(Viewer viewer, Object parentElement, @@ -701,7 +701,7 @@ public class ReusableHelpPart implements IHelpUIConstants, IActivityManagerListe } } - class UAFilter extends ViewerFilter { + static class UAFilter extends ViewerFilter { @Override public boolean select(Viewer viewer, Object parentElement, Object element) { diff --git a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/ScopePreferenceDialog.java b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/ScopePreferenceDialog.java index 6feb024cb..5d7c0bf56 100644 --- a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/ScopePreferenceDialog.java +++ b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/ScopePreferenceDialog.java @@ -37,7 +37,7 @@ public class ScopePreferenceDialog extends PreferenceDialog { private EngineDescriptorManager descManager; private ArrayList<PendingOperation> pendingOperations; - class PendingOperation { + static class PendingOperation { int action; EngineDescriptor desc; public PendingOperation(int action, EngineDescriptor desc) { diff --git a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/ScopeSetDialog.java b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/ScopeSetDialog.java index f7af292cc..a0cc345cb 100644 --- a/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/ScopeSetDialog.java +++ b/org.eclipse.help.ui/src/org/eclipse/help/ui/internal/views/ScopeSetDialog.java @@ -54,7 +54,7 @@ import org.eclipse.ui.PlatformUI; public class ScopeSetDialog extends TrayDialog { - public class NonDefaultFilter extends ViewerFilter { + public static class NonDefaultFilter extends ViewerFilter { @Override public boolean select(Viewer viewer, Object parentElement, Object element) { @@ -99,7 +99,7 @@ public class ScopeSetDialog extends TrayDialog { private Object[] result; private boolean localOnly; - private abstract class PendingOperation { + private abstract static class PendingOperation { ScopeSet set; public PendingOperation(ScopeSet set) { this.set = set; @@ -124,7 +124,7 @@ public class ScopeSetDialog extends TrayDialog { } } - private class RenameOperation extends PendingOperation { + private static class RenameOperation extends PendingOperation { private String newName; public RenameOperation(ScopeSet set, String newName) { super(set); |