Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWim Jongman2020-07-17 13:22:34 +0000
committerWim Jongman2020-07-20 14:32:00 +0000
commit03366ec96aae0fd3c97ca711872c2c43e416a735 (patch)
tree51f0670ff50aa87f6ee5ce4c69221e993fc361d3
parentda8dd73ac51a957e5eaf903e373908f67f8928f2 (diff)
downloadeclipse.platform.ua-03366ec96aae0fd3c97ca711872c2c43e416a735.tar.gz
eclipse.platform.ua-03366ec96aae0fd3c97ca711872c2c43e416a735.tar.xz
eclipse.platform.ua-03366ec96aae0fd3c97ca711872c2c43e416a735.zip
Bug 561220 - Tip of the day not working
Fixed. The Next... button is disabled until a tip provider was actually selected. Change-Id: I1984cfd1fc7d1d6686afca6d424fc7915ebc2348 Signed-off-by: Wim Jongman <wim.jongman@remainsoftware.com>
-rw-r--r--org.eclipse.tips.feature/feature.xml2
-rw-r--r--org.eclipse.tips.feature/pom.xml2
-rw-r--r--org.eclipse.tips.ui/META-INF/MANIFEST.MF2
-rw-r--r--org.eclipse.tips.ui/pom.xml2
-rw-r--r--org.eclipse.tips.ui/src/org/eclipse/tips/ui/internal/TipComposite.java14
5 files changed, 14 insertions, 8 deletions
diff --git a/org.eclipse.tips.feature/feature.xml b/org.eclipse.tips.feature/feature.xml
index f23dc6904..5f538e42e 100644
--- a/org.eclipse.tips.feature/feature.xml
+++ b/org.eclipse.tips.feature/feature.xml
@@ -15,7 +15,7 @@
<feature
id="org.eclipse.tips.feature"
label="%featureName"
- version="0.2.1000.qualifier"
+ version="0.2.1100.qualifier"
provider-name="%providerName"
license-feature="org.eclipse.license"
license-feature-version="0.0.0">
diff --git a/org.eclipse.tips.feature/pom.xml b/org.eclipse.tips.feature/pom.xml
index 718d887f0..acb40549d 100644
--- a/org.eclipse.tips.feature/pom.xml
+++ b/org.eclipse.tips.feature/pom.xml
@@ -23,7 +23,7 @@
</parent>
<groupId>org.eclipse.ui</groupId>
<artifactId>org.eclipse.tips.feature</artifactId>
- <version>0.2.1000-SNAPSHOT</version>
+ <version>0.2.1100-SNAPSHOT</version>
<packaging>eclipse-feature</packaging>
<build>
<plugins>
diff --git a/org.eclipse.tips.ui/META-INF/MANIFEST.MF b/org.eclipse.tips.ui/META-INF/MANIFEST.MF
index 5fc1dda62..1c600aacd 100644
--- a/org.eclipse.tips.ui/META-INF/MANIFEST.MF
+++ b/org.eclipse.tips.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %Bundle-Name
Bundle-SymbolicName: org.eclipse.tips.ui;singleton:=true
-Bundle-Version: 0.1.900.qualifier
+Bundle-Version: 0.1.1000.qualifier
Bundle-RequiredExecutionEnvironment: JavaSE-1.8
Require-Bundle: org.eclipse.core.runtime;bundle-version="3.0.0",
org.eclipse.jface;bundle-version="3.0.0",
diff --git a/org.eclipse.tips.ui/pom.xml b/org.eclipse.tips.ui/pom.xml
index 6c43c47e3..4d80ac8fc 100644
--- a/org.eclipse.tips.ui/pom.xml
+++ b/org.eclipse.tips.ui/pom.xml
@@ -22,6 +22,6 @@
</parent>
<groupId>org.eclipse.ui</groupId>
<artifactId>org.eclipse.tips.ui</artifactId>
- <version>0.1.900-SNAPSHOT</version>
+ <version>0.1.1000-SNAPSHOT</version>
<packaging>eclipse-plugin</packaging>
</project>
diff --git a/org.eclipse.tips.ui/src/org/eclipse/tips/ui/internal/TipComposite.java b/org.eclipse.tips.ui/src/org/eclipse/tips/ui/internal/TipComposite.java
index 214ecaf71..56eb5d30b 100644
--- a/org.eclipse.tips.ui/src/org/eclipse/tips/ui/internal/TipComposite.java
+++ b/org.eclipse.tips.ui/src/org/eclipse/tips/ui/internal/TipComposite.java
@@ -89,6 +89,7 @@ public class TipComposite extends Composite implements ProviderSelectionListener
private Menu fActionMenu;
private ToolBar ftoolBar;
private ToolItem fStartupItem;
+ private Button fNextTipButton;
/**
* Constructor.
@@ -224,15 +225,16 @@ public class TipComposite extends Composite implements ProviderSelectionListener
});
fPreviousTipButton.setEnabled(false);
- Button btnNextTip = new Button(buttonBar, SWT.NONE);
- btnNextTip.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, false, false, 1, 1));
- btnNextTip.setText(Messages.TipComposite_8);
- btnNextTip.addSelectionListener(new SelectionAdapter() {
+ fNextTipButton = new Button(buttonBar, SWT.NONE);
+ fNextTipButton.setLayoutData(new GridData(SWT.FILL, SWT.CENTER, false, false, 1, 1));
+ fNextTipButton.setText(Messages.TipComposite_8);
+ fNextTipButton.addSelectionListener(new SelectionAdapter() {
@Override
public void widgetSelected(SelectionEvent e) {
getNextTip();
}
});
+ fNextTipButton.setEnabled(false);
Button btnClose = new Button(buttonBar, SWT.NONE);
btnClose.addSelectionListener(new SelectionAdapter() {
@@ -332,6 +334,10 @@ public class TipComposite extends Composite implements ProviderSelectionListener
* @param provider the {@link TipProvider}
*/
public void setProvider(TipProvider provider) {
+ if (provider == null) {
+ return;
+ }
+ fNextTipButton.setEnabled(true);
fProvider = provider;
fSlider.setTipProvider(provider);
getCurrentTip();

Back to the top