Bug 550037 - Use StringBuilder instead of StringBuffer inI20190814-1800

eclipse.platform.ua

Change-Id: I02a691f97d114be1ad17b2a996f38f05bc73e5f4
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>

9 files changed, 37 insertions, 37 deletions

diff --git a/org.eclipse.help.base/src/org/eclipse/help/internal/search/PluginVersionInfo.java b/org.eclipse.help.base/src/org/eclipse/help/internal/search/PluginVersionInfo.java
index 8c9765139..13ab14896 100644
--- a/org.eclipse.help.base/src/org/eclipse/help/internal/search/PluginVersionInfo.java
+++ b/org.eclipse.help.base/src/org/eclipse/help/internal/search/PluginVersionInfo.java
@@ -79,7 +79,7 @@ public class PluginVersionInfo extends HelpProperties {
 			if (pluginBundle == null) {
 				continue;
 			}
-			StringBuffer pluginVersionAndFragments = new StringBuffer();
+			StringBuilder pluginVersionAndFragments = new StringBuilder();
 			appendBundleInformation(pluginVersionAndFragments, bundleId,
 					pluginBundle.getHeaders().get(
 							Constants.BUNDLE_VERSION));
@@ -99,7 +99,7 @@ public class PluginVersionInfo extends HelpProperties {
 		}
 	}
 
-	protected void appendBundleInformation(StringBuffer buffer, String id,
+	protected void appendBundleInformation(StringBuilder buffer, String id,
 			String version) {
 		if (buffer.length()>0)
 			buffer.append(SEPARATOR);
diff --git a/org.eclipse.help.base/src/org/eclipse/help/search/HelpIndexBuilder.java b/org.eclipse.help.base/src/org/eclipse/help/search/HelpIndexBuilder.java
index 07b1c4f40..2d67e7549 100644
--- a/org.eclipse.help.base/src/org/eclipse/help/search/HelpIndexBuilder.java
+++ b/org.eclipse.help.base/src/org/eclipse/help/search/HelpIndexBuilder.java
@@ -183,7 +183,7 @@ public class HelpIndexBuilder {
 			// We will ignore docBundleIds which is null anyway,
 			// and use id and fid to create plugin info
 			// for the destination
-			StringBuffer buffer = new StringBuffer();
+			StringBuilder buffer = new StringBuilder();
 			appendBundleInformation(buffer, id.id, id.version.toString());
 			if (fid != null)
 				appendBundleInformation(buffer, fid.id, fid.version.toString());
diff --git a/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/StatusProducer.java b/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/StatusProducer.java
index 71495f970..3f7140dcf 100644
--- a/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/StatusProducer.java
+++ b/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/StatusProducer.java
@@ -82,7 +82,7 @@ public class StatusProducer implements IHelpContentProducer {
 			!href.equalsIgnoreCase(MissingContentManager.REMOTE_STATUS_HELP_VIEW_HREF))
 			return null;
 
-		StringBuffer pageBuffer = new StringBuffer();
+		StringBuilder pageBuffer = new StringBuilder();
 
 
 		// Get all remote sites, and subset of non-working sites
@@ -220,7 +220,7 @@ public class StatusProducer implements IHelpContentProducer {
 		return getBytes(pageBuffer);
 	}
 
-	public void addCloseLink(Locale locale, StringBuffer pageBuffer) {
+	public void addCloseLink(Locale locale, StringBuilder pageBuffer) {
 		WebappPreferences prefs = new WebappPreferences();
 		String homepage = "/help/topic"+prefs.getHelpHome(); //$NON-NLS-1$
 		pageBuffer.append(tab(3)+"<div style=\"position:absolute;right:4px;top:4px;\">\n"); //$NON-NLS-1$
@@ -230,7 +230,7 @@ public class StatusProducer implements IHelpContentProducer {
 	}
 
 	private InputStream getNetworkOKPage(Locale locale) {
-		StringBuffer pageBuffer = new StringBuffer();
+		StringBuilder pageBuffer = new StringBuilder();
 		// Write HTML header and body beginning.
 		String title = WebappResources.getString("networkHelpAvailable", locale); //$NON-NLS-1$
 		pageBuffer.append(getHtmlHead(locale, title));
@@ -245,7 +245,7 @@ public class StatusProducer implements IHelpContentProducer {
 	}
 
 	private InputStream getMissingTopicPage(String topicPath, Locale locale) {
-		StringBuffer pageBuffer = new StringBuffer();
+		StringBuilder pageBuffer = new StringBuilder();
 		// Write HTML header and body beginning.
 		String title = WebappResources.getString("someBooksUninstalled", locale); //$NON-NLS-1$
 		pageBuffer.append(getHtmlHead(locale, title));
@@ -274,7 +274,7 @@ public class StatusProducer implements IHelpContentProducer {
 		if (unresolved.length == 0) {
 			return getNoBooksMissingPage(locale, isHelpView);
 		}
-		StringBuffer pageBuffer = new StringBuffer();
+		StringBuilder pageBuffer = new StringBuilder();
 		// Write HTML header and body beginning.
 		String title = WebappResources.getString("someBooksUninstalled", locale); //$NON-NLS-1$
 		pageBuffer.append(getHtmlHead(locale, title));
@@ -320,7 +320,7 @@ public class StatusProducer implements IHelpContentProducer {
 
 
 	private InputStream getNoBooksMissingPage(Locale locale, boolean isHelpView) {
-		StringBuffer pageBuffer = new StringBuffer();
+		StringBuilder pageBuffer = new StringBuilder();
 		// Write HTML header and body beginning.
 		String title = WebappResources.getString("allBooksInstalledTitle", locale); //$NON-NLS-1$
 		pageBuffer.append(getHtmlHead(locale, title));
@@ -409,7 +409,7 @@ public class StatusProducer implements IHelpContentProducer {
 		return tabs;
 	}
 
-	private static InputStream getBytes(StringBuffer pageBuffer) {
+	private static InputStream getBytes(StringBuilder pageBuffer) {
 		return new ByteArrayInputStream(pageBuffer.toString().getBytes(StandardCharsets.UTF_8));
 	}
 
diff --git a/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/service/AboutService.java b/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/service/AboutService.java
index 3bb7be752..eef6e0e8b 100644
--- a/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/service/AboutService.java
+++ b/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/service/AboutService.java
@@ -125,7 +125,7 @@ public class AboutService extends AboutServlet {
 
 	private String processRequest(HttpServletRequest req, HttpServletResponse resp)
 			throws ServletException, IOException {
-		StringBuffer buf = new StringBuffer();
+		StringBuilder buf = new StringBuilder();
 		buf.append("<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n"); //$NON-NLS-1$
 
 		String showParam = req.getParameter("show"); //$NON-NLS-1$
@@ -140,7 +140,7 @@ public class AboutService extends AboutServlet {
 		return buf.toString();
 	}
 
-	private void getAgent(StringBuffer buf, HttpServletRequest req, HttpServletResponse resp)
+	private void getAgent(StringBuilder buf, HttpServletRequest req, HttpServletResponse resp)
 			throws IOException {
 		service = Utils.AGENT;
 
@@ -153,7 +153,7 @@ public class AboutService extends AboutServlet {
 		buf.append("</userAgent>"); //$NON-NLS-1$
 	}
 
-	private void getPreferences(StringBuffer buf, HttpServletResponse resp)
+	private void getPreferences(StringBuilder buf, HttpServletResponse resp)
 			throws IOException {
 		service = Utils.PREFERENCE;
 
@@ -166,7 +166,7 @@ public class AboutService extends AboutServlet {
 		buf.append("\n</preferences>"); //$NON-NLS-1$
 	}
 
-	private void getAboutPlugins(StringBuffer buf, HttpServletRequest req, HttpServletResponse resp)
+	private void getAboutPlugins(StringBuilder buf, HttpServletRequest req, HttpServletResponse resp)
 			throws IOException {
 		service = Utils.ABOUT_PLUGIN;
 
diff --git a/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/AboutServlet.java b/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/AboutServlet.java
index e775ddb4c..45940920a 100644
--- a/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/AboutServlet.java
+++ b/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/AboutServlet.java
@@ -150,7 +150,7 @@ public class AboutServlet extends HttpServlet {
 	}
 
 	private void getPreferences(HttpServletResponse resp) throws IOException {
-		StringBuffer buf = new StringBuffer();
+		StringBuilder buf = new StringBuilder();
 		buf.append(XHTML_1);
 		String title = WebappResources.getString("preferences", locale); //$NON-NLS-1$
 		buf.append(UrlUtil.htmlEncode(title));
diff --git a/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/PreferenceWriter.java b/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/PreferenceWriter.java
index c41ddbd25..c945e5642 100644
--- a/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/PreferenceWriter.java
+++ b/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/PreferenceWriter.java
@@ -32,15 +32,15 @@ import org.osgi.service.prefs.BackingStoreException;
  */
 
 public class PreferenceWriter {
-	private StringBuffer buf;
+	private StringBuilder buf;
 	private Locale locale;
 	private boolean isXML;
 
-	public PreferenceWriter(StringBuffer buf, Locale locale) {
+	public PreferenceWriter(StringBuilder buf, Locale locale) {
 		this(buf, locale, false);
 	}
 
-	public PreferenceWriter(StringBuffer buf, Locale locale, boolean isXML) {
+	public PreferenceWriter(StringBuilder buf, Locale locale, boolean isXML) {
 		this.buf = buf;
 		this.locale = locale;
 		this.isXML = isXML;
diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/html/HTMLUtil.java b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/html/HTMLUtil.java
index e6b1df8da..5e81ae827 100644
--- a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/html/HTMLUtil.java
+++ b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/html/HTMLUtil.java
@@ -133,8 +133,8 @@ public final class HTMLUtil {
 	 *            the value of the attribute
 	 * @return
 	 */
-	public static StringBuffer createAttribute(String attrName, String attrValue) {
-		StringBuffer attribute = new StringBuffer();
+	public static StringBuilder createAttribute(String attrName, String attrValue) {
+		StringBuilder attribute = new StringBuilder();
 		if (attrName != null && attrValue != null) {
 			attribute.append(attrName).append(IIntroHTMLConstants.EQUALS)
 					.append(IIntroHTMLConstants.QUOTE).append(attrValue)
@@ -143,17 +143,17 @@ public final class HTMLUtil {
 		return attribute;
 	}
 
-	public static StringBuffer openHTMLStartTag(String elementName) {
-		return new StringBuffer().append(IIntroHTMLConstants.LT).append(
+	public static StringBuilder openHTMLStartTag(String elementName) {
+		return new StringBuilder().append(IIntroHTMLConstants.LT).append(
 				elementName);
 	}
 
-	public static StringBuffer closeHTMLTag() {
+	public static StringBuilder closeHTMLTag() {
 		return closeHTMLTag(true);
 	}
 
-	public static StringBuffer closeHTMLTag(boolean newLine) {
-		StringBuffer closing = new StringBuffer()
+	public static StringBuilder closeHTMLTag(boolean newLine) {
+		StringBuilder closing = new StringBuilder()
 				.append(IIntroHTMLConstants.GT);
 		if (newLine)
 			closing.append(IIntroHTMLConstants.NEW_LINE);
diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/loader/ModelLoaderUtil.java b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/loader/ModelLoaderUtil.java
index c68c02b3d..43e91980a 100644
--- a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/loader/ModelLoaderUtil.java
+++ b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/loader/ModelLoaderUtil.java
@@ -165,11 +165,11 @@ public class ModelLoaderUtil {
 	 * @param element
 	 * @return
 	 */
-	public static StringBuffer createPathToElementKey(
+	public static StringBuilder createPathToElementKey(
 			AbstractIntroIdElement element, boolean full) {
 		if (element.getId() == null)
 			return null;
-		StringBuffer buffer = new StringBuffer(element.getId());
+		StringBuilder buffer = new StringBuilder(element.getId());
 		AbstractBaseIntroElement parent = (AbstractBaseIntroElement) element
 			.getParent();
 		while (parent != null
diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/swt/PageStyleManager.java b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/swt/PageStyleManager.java
index 4a5461bad..a1950bd6c 100644
--- a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/swt/PageStyleManager.java
+++ b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/swt/PageStyleManager.java
@@ -201,7 +201,7 @@ public class PageStyleManager extends SharedStyleManager {
 
 	private int getIntProperty(AbstractBaseIntroElement element,
 			String qualifier, int defaultValue) {
-		StringBuffer buff = ModelLoaderUtil.createPathToElementKey(element, true);
+		StringBuilder buff = ModelLoaderUtil.createPathToElementKey(element, true);
 		if (buff == null)
 			return defaultValue;
 		String key = buff.append(qualifier).toString();
@@ -210,7 +210,7 @@ public class PageStyleManager extends SharedStyleManager {
 
 	private boolean getBooleanProperty(AbstractBaseIntroElement element,
 			String qualifier, boolean defaultValue) {
-		StringBuffer buff = ModelLoaderUtil.createPathToElementKey(element, true);
+		StringBuilder buff = ModelLoaderUtil.createPathToElementKey(element, true);
 		if (buff == null)
 			return defaultValue;
 		String key = buff.append(qualifier).toString();
@@ -255,7 +255,7 @@ public class PageStyleManager extends SharedStyleManager {
 	 * @return
 	 */
 	public String getDescription(IntroGroup group) {
-		StringBuffer buff = ModelLoaderUtil.createPathToElementKey(group, true);
+		StringBuilder buff = ModelLoaderUtil.createPathToElementKey(group, true);
 		if (buff == null)
 			return null;
 		String key = buff.append(".description-id").toString(); //$NON-NLS-1$
@@ -395,7 +395,7 @@ public class PageStyleManager extends SharedStyleManager {
 
 
 	public Color getColor(FormToolkit toolkit, AbstractBaseIntroElement element) {
-		StringBuffer buff = ModelLoaderUtil.createPathToElementKey(element, true);
+		StringBuilder buff = ModelLoaderUtil.createPathToElementKey(element, true);
 		if (buff == null)
 			return null;
 		String key = buff.append(".font.fg").toString(); //$NON-NLS-1$
@@ -403,7 +403,7 @@ public class PageStyleManager extends SharedStyleManager {
 	}
 
 	public Color getBackgrond(FormToolkit toolkit, AbstractBaseIntroElement element) {
-		StringBuffer buff = ModelLoaderUtil.createPathToElementKey(element, true);
+		StringBuilder buff = ModelLoaderUtil.createPathToElementKey(element, true);
 		if (buff == null)
 			return null;
 		String key = buff.append(".bg").toString(); //$NON-NLS-1$
@@ -413,7 +413,7 @@ public class PageStyleManager extends SharedStyleManager {
 	public boolean isBold(IntroText text) {
 		String value = null;
 		/*
-		StringBuffer buff = ModelLoaderUtil.createPathToElementKey(text, true);
+		StringBuilder buff = ModelLoaderUtil.createPathToElementKey(text, true);
 		if (buff != null) {
 			String key = buff.append(".font.bold").toString(); //$NON-NLS-1$
 			value = getProperty(key);
@@ -436,7 +436,7 @@ public class PageStyleManager extends SharedStyleManager {
 	}
 
 	private String getPropertyValue(AbstractIntroIdElement element, String suffix) {
-		StringBuffer buff = ModelLoaderUtil.createPathToElementKey(element, true);
+		StringBuilder buff = ModelLoaderUtil.createPathToElementKey(element, true);
 		if (buff != null) {
 			String key = buff.append(suffix).toString();
 			String value = getProperty(key);
@@ -492,13 +492,13 @@ public class PageStyleManager extends SharedStyleManager {
 
 	private String createImageKey(AbstractIntroPage page, IntroLink link,
 			String qualifier) {
-		StringBuffer buff = null;
+		StringBuilder buff = null;
 		if (link != null) {
 			buff = ModelLoaderUtil.createPathToElementKey(link, true);
 			if (buff == null)
 				return ""; //$NON-NLS-1$
 		} else {
-			buff = new StringBuffer();
+			buff = new StringBuilder();
 			buff.append(page.getId());
 		}
 		buff.append("."); //$NON-NLS-1$
@@ -521,7 +521,7 @@ public class PageStyleManager extends SharedStyleManager {
 
 	public Image getImage(IntroImage introImage) {
 		String imageLocation = introImage.getSrcAsIs();
-		StringBuffer buff = ModelLoaderUtil.createPathToElementKey(introImage, true);
+		StringBuilder buff = ModelLoaderUtil.createPathToElementKey(introImage, true);
 		String key;
 		if (buff == null) {
 			key = "//" + imageLocation; //$NON-NLS-1$