Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLakshmi Shanmugam2020-02-07 10:31:07 +0000
committerLakshmi Shanmugam2020-02-07 10:31:29 +0000
commit80fbb52cd58719c116cb221eb7869dd979b189be (patch)
tree3f575abc2cb42aa96a950a1f4c28ca73d30a3aee
parentaada320ac9b1d463031f9356923568a511e9278c (diff)
downloadeclipse.platform.ua-80fbb52cd58719c116cb221eb7869dd979b189be.tar.gz
eclipse.platform.ua-80fbb52cd58719c116cb221eb7869dd979b189be.tar.xz
eclipse.platform.ua-80fbb52cd58719c116cb221eb7869dd979b189be.zip
Bug 559486 - [Accessibility] Orphan content found that does not resideI20200209-1800I20200208-1800I20200207-1800
within a WAI-ARIA landmark or labelled region role Added tab and toolbar roles Change-Id: I392a5075d63e0b3e4224fab449a41cbf70beefde
-rw-r--r--org.eclipse.help.webapp/advanced/tabs.jsp8
-rw-r--r--org.eclipse.help.webapp/advanced/toolbar.jsp2
2 files changed, 4 insertions, 6 deletions
diff --git a/org.eclipse.help.webapp/advanced/tabs.jsp b/org.eclipse.help.webapp/advanced/tabs.jsp
index 09a356206..077bf5eec 100644
--- a/org.eclipse.help.webapp/advanced/tabs.jsp
+++ b/org.eclipse.help.webapp/advanced/tabs.jsp
@@ -254,10 +254,8 @@ function getPreviousLink(currentLink){
</script>
</head>
-
<body dir="<%=direction%>" onload="showTab('<%=data.getVisibleView()%>')">
-
- <table cellspacing="0" cellpadding="0" border="0" width="100%" height="100%" valign="middle">
+ <table id="tab-container" role="tablist" cellspacing="0" cellpadding="0" border="0" width="100%" height="100%" valign="middle">
<tr>
<%
@@ -275,7 +273,8 @@ function getPreviousLink(currentLink){
<td title="<%=UrlUtil.htmlEncode(title)%>"
align="center"
valign="middle"
- class="tab"
+ class="tab"
+ role="tab"
id="<%=views[i].getName()%>"
onclick="parent.showView('<%=views[i].getName()%>')"
onmouseover="window.status='<%=UrlUtil.JavaScriptEncode(title)%>';return true;"
@@ -301,7 +300,6 @@ function getPreviousLink(currentLink){
</tr>
</table>
-
</body>
</html>
diff --git a/org.eclipse.help.webapp/advanced/toolbar.jsp b/org.eclipse.help.webapp/advanced/toolbar.jsp
index a3fc3af50..551ffc7da 100644
--- a/org.eclipse.help.webapp/advanced/toolbar.jsp
+++ b/org.eclipse.help.webapp/advanced/toolbar.jsp
@@ -449,7 +449,7 @@ if(buttons.length > 0){
}
%>
-<table id="container" width="100%" border="0" cellspacing="0" cellpadding="0" height="100%" style='padding-<%=isRTL?"right":"left"%>:<%=data.isIE()?"5px":"8px"%>;'>
+<table role="toolbar" id="container" width="100%" border="0" cellspacing="0" cellpadding="0" height="100%" style='padding-<%=isRTL?"right":"left"%>:<%=data.isIE()?"5px":"8px"%>;'>
<tr>
<td nowrap style="font: <%=prefs.getToolbarFont()%>" valign="middle">

Back to the top