Skip to main content
aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLakshmi Shanmugam2020-02-13 07:39:33 +0000
committerLakshmi Shanmugam2020-02-13 10:01:21 +0000
commit83631414d312d7ad36d6696048528570eef6c7ca (patch)
treea0e55141c35144799f30079a7e8bb7fe8ef77399
parentcddcc07541f8665985593f04cff8b645326481e6 (diff)
downloadeclipse.platform.ua-83631414d312d7ad36d6696048528570eef6c7ca.tar.gz
eclipse.platform.ua-83631414d312d7ad36d6696048528570eef6c7ca.tar.xz
eclipse.platform.ua-83631414d312d7ad36d6696048528570eef6c7ca.zip
Bug 559486 - [Accessibility] Orphan content found that does not resideI20200214-0620I20200213-1800I20200213-1520I20200213-1210I20200213-1100
within a WAI-ARIA landmark or labelled region role Added role="main" to content Reverted commit 80fbb52cd58719c116cb221eb7869dd979b189be. Change-Id: Ifbefd5f68d96e5710b927ea9b04548adff8d77ab Signed-off-by: Lakshmi Shanmugam <lshanmug@in.ibm.com>
-rw-r--r--org.eclipse.help.base/doc/help_home.html2
-rw-r--r--org.eclipse.help.webapp/advanced/tabs.jsp8
-rw-r--r--org.eclipse.help.webapp/advanced/toolbar.jsp2
3 files changed, 7 insertions, 5 deletions
diff --git a/org.eclipse.help.base/doc/help_home.html b/org.eclipse.help.base/doc/help_home.html
index ae61ef6f3..87dca563a 100644
--- a/org.eclipse.help.base/doc/help_home.html
+++ b/org.eclipse.help.base/doc/help_home.html
@@ -9,7 +9,7 @@
</head>
<body>
-<div id="content">
+<div id="content" role="main">
<h1>Using the help system</h1>
<p>
diff --git a/org.eclipse.help.webapp/advanced/tabs.jsp b/org.eclipse.help.webapp/advanced/tabs.jsp
index 077bf5eec..09a356206 100644
--- a/org.eclipse.help.webapp/advanced/tabs.jsp
+++ b/org.eclipse.help.webapp/advanced/tabs.jsp
@@ -254,8 +254,10 @@ function getPreviousLink(currentLink){
</script>
</head>
+
<body dir="<%=direction%>" onload="showTab('<%=data.getVisibleView()%>')">
- <table id="tab-container" role="tablist" cellspacing="0" cellpadding="0" border="0" width="100%" height="100%" valign="middle">
+
+ <table cellspacing="0" cellpadding="0" border="0" width="100%" height="100%" valign="middle">
<tr>
<%
@@ -273,8 +275,7 @@ function getPreviousLink(currentLink){
<td title="<%=UrlUtil.htmlEncode(title)%>"
align="center"
valign="middle"
- class="tab"
- role="tab"
+ class="tab"
id="<%=views[i].getName()%>"
onclick="parent.showView('<%=views[i].getName()%>')"
onmouseover="window.status='<%=UrlUtil.JavaScriptEncode(title)%>';return true;"
@@ -300,6 +301,7 @@ function getPreviousLink(currentLink){
</tr>
</table>
+
</body>
</html>
diff --git a/org.eclipse.help.webapp/advanced/toolbar.jsp b/org.eclipse.help.webapp/advanced/toolbar.jsp
index 551ffc7da..a3fc3af50 100644
--- a/org.eclipse.help.webapp/advanced/toolbar.jsp
+++ b/org.eclipse.help.webapp/advanced/toolbar.jsp
@@ -449,7 +449,7 @@ if(buttons.length > 0){
}
%>
-<table role="toolbar" id="container" width="100%" border="0" cellspacing="0" cellpadding="0" height="100%" style='padding-<%=isRTL?"right":"left"%>:<%=data.isIE()?"5px":"8px"%>;'>
+<table id="container" width="100%" border="0" cellspacing="0" cellpadding="0" height="100%" style='padding-<%=isRTL?"right":"left"%>:<%=data.isIE()?"5px":"8px"%>;'>
<tr>
<td nowrap style="font: <%=prefs.getToolbarFont()%>" valign="middle">

Back to the top