diff options
author | Lars Vogel | 2021-04-09 05:48:20 +0000 |
---|---|---|
committer | Alexander Kurtakov | 2021-04-09 17:47:07 +0000 |
commit | 3f7c030ba8d44d88f5dd1212500263d46a2fb616 (patch) | |
tree | 6855dee640bb3febe41b9301228b42d2ccc9a687 | |
parent | b34414f78e74cfe1d007079c5990bf9f3a2bc3de (diff) | |
download | eclipse.platform.ua-3f7c030ba8d44d88f5dd1212500263d46a2fb616.tar.gz eclipse.platform.ua-3f7c030ba8d44d88f5dd1212500263d46a2fb616.tar.xz eclipse.platform.ua-3f7c030ba8d44d88f5dd1212500263d46a2fb616.zip |
[dogfooding][cleanup] Use static inner class clean up forI20210413-1400I20210412-2130I20210412-1800I20210411-1800I20210410-1800I20210410-0630I20210409-2140I20210409-1800
intro code
Using this cleanup brings:
- It reviews the feature
- For optimization: small memory usage reduction as the outer pointer
is removed
Change-Id: I76ed30b7303b62bbdb2b7ce4476f1e7153b8abaa
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
5 files changed, 5 insertions, 5 deletions
diff --git a/org.eclipse.ui.intro.universal/src/org/eclipse/ui/internal/intro/universal/CustomizationContentsArea.java b/org.eclipse.ui.intro.universal/src/org/eclipse/ui/internal/intro/universal/CustomizationContentsArea.java index 73b66c7b5..1715ef158 100644 --- a/org.eclipse.ui.intro.universal/src/org/eclipse/ui/internal/intro/universal/CustomizationContentsArea.java +++ b/org.eclipse.ui.intro.universal/src/org/eclipse/ui/internal/intro/universal/CustomizationContentsArea.java @@ -383,7 +383,7 @@ public class CustomizationContentsArea { } } - class IntroTheme { + static class IntroTheme { IConfigurationElement element; Image previewImage; diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/History.java b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/History.java index d66c7e987..4666d60c4 100644 --- a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/History.java +++ b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/History.java @@ -35,7 +35,7 @@ public class History { // IFrame is stored in history as a different object with the IFrameURL set. // This way the model actually creates one page for every embedded Help // Topic target but the navigation history updates the IFrame accordingly. - class HistoryObject { + static class HistoryObject { AbstractIntroPage page; String iframeUrl; String url; diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/IntroSearchParticipant.java b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/IntroSearchParticipant.java index 824b7c9be..a1da253ed 100644 --- a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/IntroSearchParticipant.java +++ b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/IntroSearchParticipant.java @@ -44,7 +44,7 @@ public class IntroSearchParticipant extends SearchParticipant { private IntroModelRoot model; - private class TitleAndSummary { + private static class TitleAndSummary { String title; String summary; } diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/loader/ContentProviderManager.java b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/loader/ContentProviderManager.java index 56bb898ae..3d0d0448e 100644 --- a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/loader/ContentProviderManager.java +++ b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/loader/ContentProviderManager.java @@ -54,7 +54,7 @@ public class ContentProviderManager { private Map<String, ContentProviderWrapper> contentProviders = new HashMap<>(); - class ContentProviderWrapper { + static class ContentProviderWrapper { IIntroContentProvider provider; AbstractIntroPage parentPage; diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/swt/RootPageForm.java b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/swt/RootPageForm.java index 683360d98..d9ac57ed7 100644 --- a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/swt/RootPageForm.java +++ b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/swt/RootPageForm.java @@ -75,7 +75,7 @@ public class RootPageForm implements IIntroConstants { } } - class RootPageLayout extends Layout { + static class RootPageLayout extends Layout { // gap between link composite and description label. private int VERTICAL_SPACING = 20; |