diff options
| author | Carsten Hammer | 2020-12-06 15:40:04 +0000 |
|---|---|---|
| committer | Alexander Kurtakov | 2021-04-28 15:41:47 +0000 |
| commit | fcb34bef239544a1b472435325fe0d3f3ed31358 (patch) | |
| tree | 28ff3b7df0480d9a9148a265854f38e580bae5d9 | |
| parent | 8895ea4bc6b532fce80c5e760d45d4b22331134f (diff) | |
| download | eclipse.platform.ua-fcb34bef239544a1b472435325fe0d3f3ed31358.tar.gz eclipse.platform.ua-fcb34bef239544a1b472435325fe0d3f3ed31358.tar.xz eclipse.platform.ua-fcb34bef239544a1b472435325fe0d3f3ed31358.zip | |
Bug: call super.tearDown()
TestCase
org.eclipse.ua.tests.help.performance.LowIterationHelpServerTest defines
tearDown that doesn't call super.tearDown()
Class is a JUnit TestCase and implements the tearDown method. The
tearDown method should call super.tearDown(), but doesn't.
Rank: Scary (7), confidence: Normal
Pattern: IJU_TEARDOWN_NO_SUPER
Type: IJU, Category: CORRECTNESS (Correctness)
Change-Id: I7269b8bf00d3ca0dff66457442eff07040825b2d
Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.ua/+/173450
Tested-by: Platform Bot <platform-bot@eclipse.org>
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
2 files changed, 2 insertions, 0 deletions
diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/performance/HelpServerTest.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/performance/HelpServerTest.java index 1d9f52cab..6b669bb1a 100644 --- a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/performance/HelpServerTest.java +++ b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/performance/HelpServerTest.java @@ -27,6 +27,7 @@ public class HelpServerTest extends PerformanceTestCase { @Override protected void tearDown() throws Exception { LoadServletUtil.stopServer(); + super.tearDown(); } public void testServletRead100x() throws Exception { diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/performance/LowIterationHelpServerTest.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/performance/LowIterationHelpServerTest.java index c6e1bbc66..42933fd6e 100644 --- a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/performance/LowIterationHelpServerTest.java +++ b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/performance/LowIterationHelpServerTest.java @@ -27,6 +27,7 @@ public class LowIterationHelpServerTest extends PerformanceTestCase { @Override protected void tearDown() throws Exception { LoadServletUtil.stopServer(); + super.tearDown(); } public void testServletRead20x() throws Exception { |