diff options
author | Lars Vogel | 2021-04-09 05:47:57 +0000 |
---|---|---|
committer | Alexander Kurtakov | 2021-04-28 17:56:27 +0000 |
commit | c6aa00e83fa740ea27573ad2292e5c3cd97daae5 (patch) | |
tree | 151fc0967b40be1c6b8507cb470821eae03c82d8 | |
parent | 6419fc8ea2bfa7ae635f7435fef452bfae6face4 (diff) | |
download | eclipse.platform.ua-c6aa00e83fa740ea27573ad2292e5c3cd97daae5.tar.gz eclipse.platform.ua-c6aa00e83fa740ea27573ad2292e5c3cd97daae5.tar.xz eclipse.platform.ua-c6aa00e83fa740ea27573ad2292e5c3cd97daae5.zip |
[dogfooding][cleanup] Use static inner class clean up forI20210505-0510I20210505-0100I20210504-1800I20210503-1800I20210502-1800I20210502-0730I20210501-1800I20210430-1800I20210429-1800I20210429-0600I20210428-1800
tests and examples
Using this cleanup brings:
- It reviews the feature
- For optimization: small memory usage reduction as the outer pointer
is removed
Change-Id: I0694e3be4c17ef7afa62f7222d2d0374b5d4afad
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.ua/+/179069
Tested-by: Platform Bot <platform-bot@eclipse.org>
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
12 files changed, 22 insertions, 22 deletions
diff --git a/org.eclipse.tips.examples/src/org/eclipse/tips/examples/swttip/SwtTipImpl.java b/org.eclipse.tips.examples/src/org/eclipse/tips/examples/swttip/SwtTipImpl.java index 5818735e2..022110f6d 100644 --- a/org.eclipse.tips.examples/src/org/eclipse/tips/examples/swttip/SwtTipImpl.java +++ b/org.eclipse.tips.examples/src/org/eclipse/tips/examples/swttip/SwtTipImpl.java @@ -31,7 +31,7 @@ import org.eclipse.tips.ui.ISwtTip; public class SwtTipImpl extends Tip implements ISwtTip { - private final class Beeper extends SelectionAdapter { + private static final class Beeper extends SelectionAdapter { @Override public void widgetSelected(SelectionEvent e) { e.widget.getDisplay().beep(); diff --git a/org.eclipse.ua.tests.doc/src/org/eclipse/ua/tests/doc/internal/linkchecker/TocLinkChecker.java b/org.eclipse.ua.tests.doc/src/org/eclipse/ua/tests/doc/internal/linkchecker/TocLinkChecker.java index b00667f44..271a81c74 100644 --- a/org.eclipse.ua.tests.doc/src/org/eclipse/ua/tests/doc/internal/linkchecker/TocLinkChecker.java +++ b/org.eclipse.ua.tests.doc/src/org/eclipse/ua/tests/doc/internal/linkchecker/TocLinkChecker.java @@ -38,28 +38,28 @@ import org.junit.Test; public class TocLinkChecker { - private final class ReferenceFilter extends TocValidator.Filter { + private static final class ReferenceFilter extends TocValidator.Filter { @Override public boolean isIncluded(String href) { return href.startsWith("reference"); } } - private final class NonReferenceFilter extends TocValidator.Filter { + private static final class NonReferenceFilter extends TocValidator.Filter { @Override public boolean isIncluded(String href) { return !href.startsWith("reference"); } } - private final class NonReferenceNonSampleFilter extends TocValidator.Filter { + private static final class NonReferenceNonSampleFilter extends TocValidator.Filter { @Override public boolean isIncluded(String href) { return !href.startsWith("reference") && !href.startsWith("samples"); } } - private final class ReferenceOrSampleFilter extends TocValidator.Filter { + private static final class ReferenceOrSampleFilter extends TocValidator.Filter { @Override public boolean isIncluded(String href) { return href.startsWith("reference") || href.startsWith("samples"); diff --git a/org.eclipse.ua.tests/cheatsheet/org/eclipse/ua/tests/cheatsheet/composite/TestTaskEvents.java b/org.eclipse.ua.tests/cheatsheet/org/eclipse/ua/tests/cheatsheet/composite/TestTaskEvents.java index d31914609..c11ce85dd 100644 --- a/org.eclipse.ua.tests/cheatsheet/org/eclipse/ua/tests/cheatsheet/composite/TestTaskEvents.java +++ b/org.eclipse.ua.tests/cheatsheet/org/eclipse/ua/tests/cheatsheet/composite/TestTaskEvents.java @@ -39,7 +39,7 @@ import org.junit.Test; public class TestTaskEvents { - public class TaskMap { + public static class TaskMap { private Map<String, TaskCounter> map = new HashMap<>(); private int eventCount = 0; @@ -68,7 +68,7 @@ public class TestTaskEvents { } } - public class TaskCounter { + public static class TaskCounter { private int count = 1; public int getCount() { diff --git a/org.eclipse.ua.tests/cheatsheet/org/eclipse/ua/tests/cheatsheet/other/TestStatePersistence.java b/org.eclipse.ua.tests/cheatsheet/org/eclipse/ua/tests/cheatsheet/other/TestStatePersistence.java index e5089e4fe..d9440ba1e 100644 --- a/org.eclipse.ua.tests/cheatsheet/org/eclipse/ua/tests/cheatsheet/other/TestStatePersistence.java +++ b/org.eclipse.ua.tests/cheatsheet/org/eclipse/ua/tests/cheatsheet/other/TestStatePersistence.java @@ -43,7 +43,7 @@ public class TestStatePersistence { private static final String TEST_ID = "TestId"; private static final String PATH = "ContentPath"; - private class PropertySet { + private static class PropertySet { public String id; public int currentItem; public int button; diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ConcurrentTocAccess.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ConcurrentTocAccess.java index b9f0bed5c..3998d00ce 100644 --- a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ConcurrentTocAccess.java +++ b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ConcurrentTocAccess.java @@ -31,7 +31,7 @@ public class ConcurrentTocAccess { // Set enableTimeout to false for debugging private boolean enableTimeout = true; - private class TocGenerator { + private static class TocGenerator { private int[] dimensions; private StringBuilder result; @@ -91,10 +91,10 @@ public class ConcurrentTocAccess { } } - private class BadHrefException extends RuntimeException { + private static class BadHrefException extends RuntimeException { private static final long serialVersionUID = 410319402417607912L; } - private class BadLabelException extends RuntimeException { + private static class BadLabelException extends RuntimeException { private static final long serialVersionUID = -4581518572807575035L; } diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ContextLinkSorter.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ContextLinkSorter.java index 47952ac51..2d006bfd0 100644 --- a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ContextLinkSorter.java +++ b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/other/ContextLinkSorter.java @@ -23,7 +23,7 @@ import org.junit.Test; public class ContextLinkSorter { - private class TestResource implements IHelpResource { + private static class TestResource implements IHelpResource { private String category; private String href; @@ -51,7 +51,7 @@ public class ContextLinkSorter { } - private class TestContext implements IContext2 { + private static class TestContext implements IContext2 { @Override public String getCategory(IHelpResource topic) { diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/preferences/BookmarksTest.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/preferences/BookmarksTest.java index d19f4a984..bda72d891 100644 --- a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/preferences/BookmarksTest.java +++ b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/preferences/BookmarksTest.java @@ -40,7 +40,7 @@ public class BookmarksTest { private static final String BUGZILLA = "bugzilla"; private static final String HTTP_BUGZILLA = "https://bugs.eclipse.org/bugs/"; - private class BookmarkObserver implements Observer { + private static class BookmarkObserver implements Observer { public Object o; public Object arg; diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/toc/EnabledTopicTest.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/toc/EnabledTopicTest.java index 39de08579..7a514fd5f 100644 --- a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/toc/EnabledTopicTest.java +++ b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/toc/EnabledTopicTest.java @@ -30,7 +30,7 @@ import org.junit.Test; public class EnabledTopicTest { - private class ETopic implements ITopic { + private static class ETopic implements ITopic { private String label; private boolean isEnabled; @@ -72,7 +72,7 @@ public class EnabledTopicTest { } } - private class NoHrefTopic extends ETopic { + private static class NoHrefTopic extends ETopic { public NoHrefTopic(String label) { super(label, true); @@ -85,7 +85,7 @@ public class EnabledTopicTest { } - private class EIndexEntry extends UAElement implements IIndexEntry { + private static class EIndexEntry extends UAElement implements IIndexEntry { private String keyword; private List<ITopic> topics = new ArrayList<>(); diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/toc/TocSortingTest.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/toc/TocSortingTest.java index 03ce7cb34..a978110ac 100644 --- a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/toc/TocSortingTest.java +++ b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/toc/TocSortingTest.java @@ -46,7 +46,7 @@ public class TocSortingTest { private String helpDataPreference; private String baseTocsPreference; - private class Toc implements IToc { + private static class Toc implements IToc { private String label; @@ -86,7 +86,7 @@ public class TocSortingTest { } - private class TC implements ITocContribution { + private static class TC implements ITocContribution { private IToc toc; private String categoryId; diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webapp/HelpServerInterrupt.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webapp/HelpServerInterrupt.java index 9cff567b3..8a57de097 100644 --- a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webapp/HelpServerInterrupt.java +++ b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webapp/HelpServerInterrupt.java @@ -33,7 +33,7 @@ public class HelpServerInterrupt { private static boolean enableTimeout = true; private int iterations; private int sleepTime = 10; - private class ServerStarter extends Thread { + private static class ServerStarter extends Thread { private Exception exception = null; diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webapp/ParallelServerAccessTest.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webapp/ParallelServerAccessTest.java index 4c0fe904a..bc95f82be 100644 --- a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webapp/ParallelServerAccessTest.java +++ b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webapp/ParallelServerAccessTest.java @@ -98,7 +98,7 @@ public class ParallelServerAccessTest { } } - private class UnexpectedValueException extends Exception { + private static class UnexpectedValueException extends Exception { private static final long serialVersionUID = 1L; private long expected; private long actual; diff --git a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webextension/TitleSearchData.java b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webextension/TitleSearchData.java index ab8e0df3e..8cf7e7d5a 100644 --- a/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webextension/TitleSearchData.java +++ b/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webextension/TitleSearchData.java @@ -35,7 +35,7 @@ public TitleSearchData(ServletContext context, HttpServletRequest request, private List<SearchResult> results; private String searchTerm; -public class SearchResult { +public static class SearchResult { public String title; public String href; } |