Using indexOf char instead of indexOf StringY20190705-0620

See https://sourceforge.net/p/findbugs/feature-requests/300/#cb7f for a
performance related discussion

Change-Id: I7fac69e4be7517984a1533062df2d4c6b7061137
Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>

5 files changed, 11 insertions, 11 deletions

diff --git a/org.eclipse.help.base/src/org/eclipse/help/internal/protocols/HelpURLConnection.java b/org.eclipse.help.base/src/org/eclipse/help/internal/protocols/HelpURLConnection.java
index b4bcaa094..33bc5799c 100644
--- a/org.eclipse.help.base/src/org/eclipse/help/internal/protocols/HelpURLConnection.java
+++ b/org.eclipse.help.base/src/org/eclipse/help/internal/protocols/HelpURLConnection.java
@@ -98,7 +98,7 @@ public class HelpURLConnection extends URLConnection {
 		if (urlFile.startsWith("/")) //$NON-NLS-1$
 			urlFile = urlFile.substring(1);
 
-		int indx = urlFile.indexOf("?"); //$NON-NLS-1$
+		int indx = urlFile.indexOf('?');
 		if (indx != -1) {
 			query = urlFile.substring(indx + 1);
 			urlFile = urlFile.substring(0, indx);
@@ -179,7 +179,7 @@ public class HelpURLConnection extends URLConnection {
 		StringTokenizer stok = new StringTokenizer(query, "&"); //$NON-NLS-1$
 		while (stok.hasMoreTokens()) {
 			String aQuery = stok.nextToken();
-			int equalsPosition = aQuery.indexOf("="); //$NON-NLS-1$
+			int equalsPosition = aQuery.indexOf('=');
 			if (equalsPosition > -1) { // well formed name/value pair
 				String arg = aQuery.substring(0, equalsPosition);
 				String val = aQuery.substring(equalsPosition + 1);
@@ -294,11 +294,11 @@ public class HelpURLConnection extends URLConnection {
 	protected String getFile() {
 		if (file == null) {
 			// Strip the plugin id
-			int start = pluginAndFile.indexOf("/") + 1; //$NON-NLS-1$
+			int start = pluginAndFile.indexOf('/') + 1;
 			// Strip query string or anchor bookmark
-			int end = pluginAndFile.indexOf("?"); //$NON-NLS-1$
+			int end = pluginAndFile.indexOf('?');
 			if (end == -1)
-				end = pluginAndFile.indexOf("#"); //$NON-NLS-1$
+				end = pluginAndFile.indexOf('#');
 			if (end == -1)
 				end = pluginAndFile.length();
 			file = pluginAndFile.substring(start, end);
diff --git a/org.eclipse.help.base/src/org/eclipse/help/internal/validation/TocValidator.java b/org.eclipse.help.base/src/org/eclipse/help/internal/validation/TocValidator.java
index 339b5d7be..930b7a2d9 100644
--- a/org.eclipse.help.base/src/org/eclipse/help/internal/validation/TocValidator.java
+++ b/org.eclipse.help.base/src/org/eclipse/help/internal/validation/TocValidator.java
@@ -101,7 +101,7 @@ public class TocValidator {
 		String path;
 		if (href.startsWith("/")) { //$NON-NLS-1$
 			href = href.substring(1);
-			int index = href.indexOf("/"); //$NON-NLS-1$
+			int index = href.indexOf('/');
 			if (index == -1)
 				throw new IOException("Invalid parameters supplied to the validate method."); //$NON-NLS-1$
 			plugin = href.substring(0, index);
diff --git a/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/HighlightFilter.java b/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/HighlightFilter.java
index e1b5f09d1..5a0934079 100644
--- a/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/HighlightFilter.java
+++ b/org.eclipse.help.webapp/src/org/eclipse/help/internal/webapp/servlet/HighlightFilter.java
@@ -165,7 +165,7 @@ public class HighlightFilter implements IFilter {
 		Collection<String> resultPass1 = new ArrayList<>();
 		for (String word : col) {
 			int index;
-			while ((index = word.indexOf("*")) >= 0) { //$NON-NLS-1$
+			while ((index = word.indexOf('*')) >= 0) {
 				if (index > 0)
 					resultPass1.add(word.substring(0, index));
 				if (word.length() > index)
@@ -179,7 +179,7 @@ public class HighlightFilter implements IFilter {
 		Collection<String> resultPass2 = new ArrayList<>();
 		for (String word : resultPass1) {
 			int index;
-			while ((index = word.indexOf("?")) >= 0) { //$NON-NLS-1$
+			while ((index = word.indexOf('?')) >= 0) {
 				if (index > 0)
 					resultPass2.add(word.substring(0, index));
 				if (word.length() > index)
diff --git a/org.eclipse.tips.core/src/org/eclipse/tips/core/TipImage.java b/org.eclipse.tips.core/src/org/eclipse/tips/core/TipImage.java
index b34dd90f5..2e6e1e713 100644
--- a/org.eclipse.tips.core/src/org/eclipse/tips/core/TipImage.java
+++ b/org.eclipse.tips.core/src/org/eclipse/tips/core/TipImage.java
@@ -101,8 +101,8 @@ public class TipImage {
 		fURL = null;
 		if (base64Image.matches("^data:image\\/.*?;base64,.*$")) { //$NON-NLS-1$
 			fBase64Image = base64Image;
-			int from = base64Image.indexOf("/") + 1; //$NON-NLS-1$
-			int to = base64Image.indexOf(";"); //$NON-NLS-1$
+			int from = base64Image.indexOf('/') + 1; //$NON-NLS-1$
+			int to = base64Image.indexOf(';'); //$NON-NLS-1$
 			setExtension(base64Image.substring(from, to).trim());
 			setExtension(base64Image.substring(from, to).trim());
 		} else {
diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/IntroText.java b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/IntroText.java
index c3b68af90..46f0a37a0 100644
--- a/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/IntroText.java
+++ b/org.eclipse.ui.intro/src/org/eclipse/ui/internal/intro/impl/model/IntroText.java
@@ -67,7 +67,7 @@ public class IntroText extends AbstractBaseIntroElement {
 	public boolean checkIfFormatted() {
 		if (text == null)
 			return false;
-		int i = text.indexOf("<"); //$NON-NLS-1$
+		int i = text.indexOf('<');
 		return i == -1 ? false : true;
 	}