diff options
author | Sergey Fukanchik | 2018-09-25 18:04:18 +0000 |
---|---|---|
committer | Sergey Fukanchik | 2018-09-25 18:56:53 +0000 |
commit | aee3c57d6f6ae3058c14c28552684329e03676cc (patch) | |
tree | 2aded4d638b76ca7f73cd6ac3f94f75b17cc98b9 | |
parent | 79ee7628caeb864bccbb479a2c075750eef6928b (diff) | |
download | eclipse.platform.ua-aee3c57d6f6ae3058c14c28552684329e03676cc.tar.gz eclipse.platform.ua-aee3c57d6f6ae3058c14c28552684329e03676cc.tar.xz eclipse.platform.ua-aee3c57d6f6ae3058c14c28552684329e03676cc.zip |
Bug 539439 - checkbox label not clickableI20181002-0205I20181001-1800I20181001-0920I20181001-0235I20180930-1800I20180929-1800I20180928-1800I20180927-1800I20180927-0135I20180927-0040
Add <label for=""/> to enable clicks on the label as well.
Change-Id: Ica4e9e4804cd146e069c0887d44496714522d99d
Signed-off-by: Sergey Fukanchik <fukanchik@gmail.com>
-rw-r--r-- | org.eclipse.ui.intro/src/org/eclipse/ui/intro/contentproviders/AlwaysWelcomeCheckbox.java | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/org.eclipse.ui.intro/src/org/eclipse/ui/intro/contentproviders/AlwaysWelcomeCheckbox.java b/org.eclipse.ui.intro/src/org/eclipse/ui/intro/contentproviders/AlwaysWelcomeCheckbox.java index 6a7a334fb..997f59ae7 100644 --- a/org.eclipse.ui.intro/src/org/eclipse/ui/intro/contentproviders/AlwaysWelcomeCheckbox.java +++ b/org.eclipse.ui.intro/src/org/eclipse/ui/intro/contentproviders/AlwaysWelcomeCheckbox.java @@ -73,7 +73,7 @@ public class AlwaysWelcomeCheckbox implements IIntroContentProvider,IIntroAction // Use an IIntroAction url that points back to this class - // particularly invoking run(). // This url is 'activated' using the onClick event. - out.print("<div id=\""+id+"\"><input type=\"checkbox\" "+ //$NON-NLS-1$//$NON-NLS-2$ + out.print("<div id=\""+id+"\"><input id=\"run-action-" + id + "\" type=\"checkbox\" "+ //$NON-NLS-1$//$NON-NLS-2$//$NON-NLS-3$ "onClick=window.location="+ //$NON-NLS-1$ "\"http://org.eclipse.ui.intro/runAction?"+ //$NON-NLS-1$ "pluginId=org.eclipse.ui.intro&"+ //$NON-NLS-1$ @@ -87,7 +87,7 @@ public class AlwaysWelcomeCheckbox implements IIntroContentProvider,IIntroAction IWorkbenchPreferenceConstants.SHOW_INTRO, alwaysShowIntro); } - out.println("/>"+getText()+"</div>"); //$NON-NLS-1$//$NON-NLS-2$ + out.println("/><label for=\"run-action-" + id + "\">"+getText()+"</label></div>"); //$NON-NLS-1$//$NON-NLS-2$//$NON-NLS-3$ } |