From 9d72f98f58e0c5fff145461e9a8282f2f6f6c926 Mon Sep 17 00:00:00 2001 From: Jonas Hungershausen Date: Fri, 15 Jun 2018 10:07:05 +0200 Subject: [Sonar] Removes redundant null check of variable that can't be null see https://sonar.eclipse.org/drilldown/issues/33533?rids%5B%5D=175028&rule=findbugs%3ARCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE&rule_sev=CRITICAL&severity=CRITICAL Change-Id: I3b26095baa6f39647104f69d2974c0611171009b Signed-off-by: Jonas Hungershausen --- .../internal/genericeditor/hover/OrderedExtensionComparator.java | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) (limited to 'org.eclipse.ui.genericeditor') diff --git a/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/hover/OrderedExtensionComparator.java b/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/hover/OrderedExtensionComparator.java index 9cf32222951..84c3d51f91e 100644 --- a/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/hover/OrderedExtensionComparator.java +++ b/org.eclipse.ui.genericeditor/src/org/eclipse/ui/internal/genericeditor/hover/OrderedExtensionComparator.java @@ -22,7 +22,7 @@ import org.eclipse.ui.internal.genericeditor.hover.TextHoverRegistry.TextHoverEx /** * A comparator that allows to sort elements according to their relative * placement (isBefore and isAfter) - *TODO: generalizing to any kind of extension supporting isBefore and isAfter + * TODO: generalizing to any kind of extension supporting isBefore and isAfter */ class OrderedExtensionComparator implements Comparator { @@ -53,9 +53,6 @@ class OrderedExtensionComparator implements Comparator { return true; } String id1 = arg1.getId(); - if (id1 == null) { - return false; - } if (before0.equals(id1)) { return true; } @@ -75,9 +72,6 @@ class OrderedExtensionComparator implements Comparator { return true; } String id1 = arg1.getId(); - if (id1 == null) { - return false; - } if (after0.equals(id1)) { return true; } -- cgit v1.2.3