From c88654a1094f40f402575bfd0e258aade7dac74b Mon Sep 17 00:00:00 2001 From: Andrey Loskutov Date: Sun, 12 Mar 2017 00:15:33 +0100 Subject: Bug 513517 - printStackTrace() should not be used in production code Change-Id: I7b4a4d0a1af3979852269b1ee53fb9a8ba444e93 Signed-off-by: Andrey Loskutov --- .../org/eclipse/jface/internal/text/revisions/RevisionPainter.java | 1 - .../jface/text/contentassist/AsyncCompletionProposalPopup.java | 3 +-- .../src/org/eclipse/jface/text/source/ChangeRulerColumn.java | 1 - .../org/eclipse/jface/text/templates/persistence/TemplateStore.java | 2 +- .../src/org/eclipse/ui/texteditor/HippieProposalProcessor.java | 3 +-- .../org/eclipse/ui/texteditor/templates/AbstractTemplatesPage.java | 5 ++++- 6 files changed, 7 insertions(+), 8 deletions(-) diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/revisions/RevisionPainter.java b/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/revisions/RevisionPainter.java index af3863ab185..34cdcaaabb4 100644 --- a/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/revisions/RevisionPainter.java +++ b/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/revisions/RevisionPainter.java @@ -1029,7 +1029,6 @@ public final class RevisionPainter { widgetStartLine= Math.max(0, range.getStartLine() - visibleStartLine); widgetEndLine= Math.min(visibleEndLine, end(range) - 1); } catch (BadLocationException x) { - x.printStackTrace(); // ignore and return null } } diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/text/contentassist/AsyncCompletionProposalPopup.java b/org.eclipse.jface.text/src/org/eclipse/jface/text/contentassist/AsyncCompletionProposalPopup.java index efb19eb5c95..12a381ec1e4 100644 --- a/org.eclipse.jface.text/src/org/eclipse/jface/text/contentassist/AsyncCompletionProposalPopup.java +++ b/org.eclipse.jface.text/src/org/eclipse/jface/text/contentassist/AsyncCompletionProposalPopup.java @@ -228,8 +228,7 @@ class AsyncCompletionProposalPopup extends CompletionProposalPopup { try { processors= fContentAssistant.getContentAssistProcessors(getTokenContentType(invocationOffset)); } catch (BadLocationException e) { - // TODO Auto-generated catch block - e.printStackTrace(); + // ignore } if (processors == null) { return Collections.emptyList(); diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/text/source/ChangeRulerColumn.java b/org.eclipse.jface.text/src/org/eclipse/jface/text/source/ChangeRulerColumn.java index 940dfcb4518..0946f5d995f 100644 --- a/org.eclipse.jface.text/src/org/eclipse/jface/text/source/ChangeRulerColumn.java +++ b/org.eclipse.jface.text/src/org/eclipse/jface/text/source/ChangeRulerColumn.java @@ -492,7 +492,6 @@ public final class ChangeRulerColumn implements IChangeRulerColumn, IRevisionRul if (lastLine < bottomLine || bottomLine == -1) bottomLine= lastLine; } catch (BadLocationException x) { - x.printStackTrace(); return null; } diff --git a/org.eclipse.jface.text/src/org/eclipse/jface/text/templates/persistence/TemplateStore.java b/org.eclipse.jface.text/src/org/eclipse/jface/text/templates/persistence/TemplateStore.java index 0d76668a983..0e7889b069a 100644 --- a/org.eclipse.jface.text/src/org/eclipse/jface/text/templates/persistence/TemplateStore.java +++ b/org.eclipse.jface.text/src/org/eclipse/jface/text/templates/persistence/TemplateStore.java @@ -292,7 +292,7 @@ public class TemplateStore { load(); } catch (IOException x) { // can't log from jface-text - x.printStackTrace(); + handleException(x); } if (oldValue != null) { diff --git a/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/HippieProposalProcessor.java b/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/HippieProposalProcessor.java index a169e279ab2..b196c83ce69 100644 --- a/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/HippieProposalProcessor.java +++ b/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/HippieProposalProcessor.java @@ -107,8 +107,7 @@ public final class HippieProposalProcessor implements IContentAssistProcessor { String replacement= fString.substring(offset - fOffset); document.replace(offset, 0, replacement); } catch (BadLocationException x) { - // TODO Auto-generated catch block - x.printStackTrace(); + // ignore } } diff --git a/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/templates/AbstractTemplatesPage.java b/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/templates/AbstractTemplatesPage.java index f783dcfb705..04987fc3b24 100644 --- a/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/templates/AbstractTemplatesPage.java +++ b/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/templates/AbstractTemplatesPage.java @@ -48,6 +48,8 @@ import org.eclipse.swt.widgets.TreeColumn; import org.eclipse.swt.widgets.TreeItem; import org.eclipse.core.runtime.Assert; +import org.eclipse.core.runtime.IStatus; +import org.eclipse.core.runtime.Status; import org.eclipse.jface.action.Action; import org.eclipse.jface.action.IAction; @@ -1307,7 +1309,8 @@ public abstract class AbstractTemplatesPage extends Page implements ITemplatesPa try { getTemplateStore().save(); } catch (IOException e) { - e.printStackTrace(); + TextEditorPlugin.getDefault().getLog().log(new Status(IStatus.ERROR, TextEditorPlugin.PLUGIN_ID, + TemplatesMessages.TemplatesPage_save_error_message, e)); MessageDialog.openError(getShell(), TemplatesMessages.TemplatesPage_save_error_message, e.getMessage()); } -- cgit v1.2.3