Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-02-14Bug 558989 - jface text testI20200217-0600I20200216-1800I20200216-1145I20200215-1800I20200215-0600I20200214-1800Kalyan Prasad Tatavarthi1-1/+6
ContextInformationTest.testContextInfo_hide_focusOut fails in nightly builds Disabling the test on Mac Change-Id: I5ac89e171db8c8dda00d72c01a9395c9c956fb49 Signed-off-by: Kalyan Prasad Tatavarthi <kalyan_prasad@in.ibm.com>
2020-02-11Remove wrong and useless comments.Alexander Kurtakov1-2/+0
The Junit 3 AssertionFailedError is no longer thrown. The comment about JUnit 4 method name rule is useless at this place Change-Id: I780028e19cd48c4957e2abc8183f895343d4c706 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-01-22Bug 559251 - restored missing validate() events during async computationI20200123-0525I20200123-0430I20200122-1805Julian Honnen1-2/+66
Only clear the occurred document events when they were actually consumed by the filtering. While the async computation is running, filtering is postponed and events are left in the queue. This ensures that ICompletionProposalExtension2 can adapt their replacement length correctly. Replaced fIsFilterPending with an AtomicBoolean to avoid synchronization issues when accessed by computation thread. Change-Id: I92ec82eb43a52301aa0116f00e5d703840348187 Signed-off-by: Julian Honnen <julian.honnen@vector.com>
2020-01-13Bug 558921 - NPE in async content assist with insert common prefixMickael Istria1-0/+56
Change-Id: Ibcfea620c5c7c5a8cdad2d00322403523cad7201 Signed-off-by: Mickael Istria <mistria@redhat.com>
2020-01-10Removes unnecessary whitespace from text repositoryI20200113-0130I20200112-1800I20200111-1800Lars Vogel4-44/+44
Change-Id: Ie5da7fb237e8ae43d872c0cb77c6b87dd547e5ce Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-06Bug 94106: Fix hide/cleanup of content information popup stackY20200108-0435S4_15_0_M1I20200110-0905I20200110-0200I20200109-2350I20200108-2240I20200108-0600I20200108-0025I20200107-1800I20200107-0600I20200106-1805I20200106-0600Stephan Wahlbrink3-4/+140
Change-Id: Ia35c3c860918d2713e29b11b409d7cacfe726fe7 Signed-off-by: Stephan Wahlbrink <sw@wahlbrink.eu>
2020-01-06Bug 558781 - TextPresentation iterator catches wrong exceptionPaul Pazderski1-0/+25
Change-Id: Ie50c2216c58656079ad00fd8938d03818e5a385b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-05Bug 550987 - [tests] Increase test coverage of TextPresentationI20200105-1800I20200105-0955Paul Pazderski1-20/+666
and disposal of some, previous ignored, resources. Change-Id: I227b81264752e90f4557eee74e696d67fd639ba5 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-05[tests] Update code alignment in TextPresentationTestPaul Pazderski1-82/+82
Change-Id: I7bac348a24ec1042f2797eda16cc49af3977fe7b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-12-03Bug 553622: Add tests for context information to jface.text.testsStephan Wahlbrink5-0/+591
Change-Id: I35d5ee744a0df394dfa8288b40e6d5b8a3c633fb Signed-off-by: Stephan Wahlbrink <sw@wahlbrink.eu>
2019-11-22Bug 548250 - Javadoc problems in platform.textI20191125-1800I20191125-0600I20191124-1800I20191124-0600I20191123-1800I20191123-1115I20191123-0600I20191123-0100Paul Pazderski1-3/+2
Change-Id: I84f9f4c00e81494dc69134e660e261fcab1dc493 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-11-14Whitespace removal for test plug-ins platform.textI20191118-0600I20191117-1800I20191117-0600I20191116-1800I20191116-0600I20191115-1800I20191114-1800I20191114-0410Lars Vogel10-68/+68
Done via running the cleanup action on the code base Change-Id: I9a8d23d6d5e77fec0f845b60b99cac6bd1c2b429 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-11-07Bug 552811 - [TextViewer] shift left broken for mixed lines if emptyI20191111-1800I20191111-0920I20191111-0655I20191111-0435I20191111-0145I20191110-1800I20191109-1800I20191109-0650I20191109-0330I20191108-1800I20191107-1800Sebastian Ratz1-0/+49
prefix is allowed Empty strings are treated differently by MultiStringMatcher and TextUtilities.indexOf() and needs to be handled specially now. Fixup for c89b823822e2d73ba4996ad419475db34c916ed5. Change-Id: Ifdb5c495f5fc99d33da6d879f436a37063b93430
2019-10-11Remove not actually thrown exception.Alexander Kurtakov1-1/+1
Change-Id: I536f4f3546ff246a4c9845eba7dac170481db593 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-09-20Bug 550920 - Recompute proposals if some cannot be filtered outBoykoAlex2-0/+583
Change-Id: I51282e29252b8e27d318fceed7d9634cb708f2e0 Signed-off-by: BoykoAlex <aboyko@pivotal.io>
2019-09-17Bug 483846 - [typing] Spaces only mode: backspace key to remove manyI20190918-0300I20190917-1800Mateusz Matela3-3/+206
spaces Change-Id: I162b412281bc0028aba4e763a859410d86f34aa6 Signed-off-by: Mateusz Matela <mateusz.matela@gmail.com>
2019-09-16Remove unnecessary type specificationsCarsten Hammer1-1/+1
Since Java 7 the diamond operator can be used instead of explicit type parameters. Version bumps for 4.14 Change-Id: I911081e0d0d22f71e50c7e00ae6283b6ae0441ea Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de> Also-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-09-16Bug 547683 - Add non-UI Thread access to last known selectionMickael Istria1-1/+98
Adds ITextViewerExtension9.getLastKnownSelection() method that gives access to last known value for the selection without requiring UI Thread. The new Generic Editor test case shows how this can be leveraged in ContentAssistProcessors. Change-Id: I8a4831c08f7ff1ade07f2a12ad8d0d2c682a372c Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-07-18Revert "Bug 547532 - disable test fails due revert for bug 549110"Y20190722-0900I20190721-1800I20190720-1800I20190719-1800I20190718-1800Mickael Istria2-10/+10
This reverts commit 0bd3a714d8fc745e80c76e805bfee9fef8cd0491 Re-enables the tests since upstream is fixed Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-07-12Bug 547532 - fixed test compilation warningsY20190718-0450Y20190715-2335Y20190715-0900I20190717-1800I20190716-1800I20190715-1800I20190714-1800I20190713-1800I20190713-1105I20190713-0230I20190712-1800Andrey Loskutov2-10/+8
They were introduced after disabling test fails due revert for bug 549110 Change-Id: I171662075e5ef1ed9bbef23e2469b39884146989 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-07-11Bug 547532 - disable test fails due revert for bug 549110Y20190711-2335Y20190711-0900S4_13_0_M1I20190712-0625I20190711-1805I20190711-1120I20190711-0825Andrey Loskutov2-2/+4
Change-Id: Ibf7ad453a934b333b7a2b9c04321eb24f68408cb Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-07-05Using indexOf char instead of indexOf StringY20190708-0900I20190710-1800I20190710-0610I20190709-1800I20190709-0610I20190708-1800I20190708-1035I20190708-0800I20190707-1800I20190707-0110I20190706-1800I20190705-1800Lars Vogel1-4/+4
See https://sourceforge.net/p/findbugs/feature-requests/300/#cb7f for a performance related discussion Change-Id: If69738a092217087471d6013669c26e1854231d4 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-07-02Bug 548732 - Fix LineContentBoundsDrawingTestI20190702-1800I20190702-0930Mickael Istria1-1/+1
On Windows and Mac, there are shadows or borders printed on the widget, so try to exclude them from the scanned area when looking for a color. Change-Id: Icf445c775435fd5a1152b106de6ad247958f4926 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-06-27Bug 547519 - [code mining] Fix apply on tabulationI20190627-1800Mickael Istria4-7/+105
With patch for SWT bug 547519, it's not possible to draw annotations at the right of a tabulation, just by fixing the char width. Change-Id: I1432a40f6bd2c25dfe4d11ba40ec278fbd448fa8 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-06-26Bug 547519 - [code mining] Don't apply on tabY20190627-0630Y20190627-0200Y20190627-0045I20190627-0135I20190626-1800Mickael Istria3-18/+169
This is more a workaround as the solution is not optimal at usage (caret not properly placed), but the proposed state is still better than current one. This prevents from making a '\t' character "host" the annotation as it comes with a bunch of issues in the DrawingStrategy (that fails at properly computing the width of a tab) and in SWT (bug 547532). Change-Id: I897da06cd57aef80a862ba28dc75887c212d234a Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-06-17StringBuilder instead of StringBufferLars Vogel1-1/+1
Change-Id: Iefefe2b40d406a866e0ce9b7b420b3b74880d536 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-13Use jdk 5 for-each loopI20190614-0330I20190613-1800Carsten Hammer1-6/+7
Replace simple uses of Iterator with a corresponding for-each loop. Also add missing braces on loops as necessary. Change-Id: Ibde37d56a7962f432ed771f4a215f5903161bde0 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-06-11Use StringBuilder instead of StringBuffer where possible.Carsten Hammer1-1/+1
Change-Id: Ifee0c0b2ecbdaad31ea628c4fbe87cec89897012 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-05-19Bug 547304 - [cleanup] Fix wrong space/tab indentationS4_12_0_RC2S4_12_0_RC1aS4_12_0_RC1S4_12_0_M3R4_12I20190605-1800I20190605-0600I20190604-1800I20190604-0600I20190603-1800I20190603-0600I20190602-1800I20190602-0600I20190601-1800I20190531-1800I20190531-0245I20190529-2005I20190529-1800I20190529-0600I20190528-1800I20190528-0915I20190528-0850I20190528-0600I20190527-1805I20190527-0600I20190526-1800I20190526-0600I20190525-1800I20190525-0600I20190524-1800I20190524-0135I20190522-1800I20190522-0600I20190521-1800I20190521-0600I20190520-1805I20190520-0600R4_12_maintenancePaul Pazderski3-4/+4
This change fixes space or mixed tab/space indentations in all Java files. This also includes two or three space indentations and even fix most stray single spaces in indentations. The change includes only whitespace formatting and no code changes. Change-Id: I3e7b6abb69a1894c402f9123417346a44fc0992a
2019-04-30Fixed compile warning introduced by bug 546706I20190501-1800I20190501-0525I20190430-1800Dani Megert1-2/+0
2019-04-29Bug 546706 - multi-line code minings rendered erroneouslyI20190429-1800Mickael Istria2-0/+71
Change-Id: I1a89962176d2583551e4fcd28b2511a69b62aa23 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-04-22Remove redundant implements.Alexander Kurtakov1-2/+1
Extended class already implements this interface. Change-Id: I6157205224c2cdf7d7d2f8f54c1c3cf63d4c244e Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-04-01Bug 546020 - [code mining] "Index out of Bounds" when inline w/ foldingI20190407-1800I20190406-1800I20190405-1800I20190404-1800I20190403-1800I20190402-1800Mickael Istria6-4/+203
Change-Id: I7b10e2d8122372bec5452225313142cf6ec58f3c Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-03-19Bug 545530 - Test for TextViewer's default IDocumentAdapterPaul Pazderski1-6/+67
Test cases derived from IDocumentAdapter JavaDoc to check if TextViewer's default implementation of IDocumentAdapter adhere to its interface. Change-Id: I03d122e608662b6b65528c479910c797cf2397b1 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-03-05Bug 545006 - Reuse existing API for screenshots during testsI20190306-0600I20190305-1800I20190305-0600Mickael Istria3-39/+8
This should allow screenshots to be found more easily in official tests and allow to more easily spot tests disabled on Mac. Change-Id: I7d57891ef83976401d5fdf165f7655b6f783f6fe Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-03-05Bug 540143 - StackOverflowError with async content-assistMickael Istria5-0/+256
A long running failing completion proposal cause StackOverflowError because it's completion state isn't retrieved correctly so the ContentAssistant assume it's not done. Instead, detect the error case and return future normally (error will be logged in console). Change-Id: I82dc511fdcbc7c61f1e575f975ef221e5d0ac160 Signed-off-by: Mickael Istria <mistria@redhat.com> Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-03-03Bug 541415 - disable tests on MacI20190304-1800I20190304-0600I20190303-1800Andrey Loskutov2-0/+20
Change-Id: Iafd6875fe46e2ad8ebbb3aab8141925b5dab5fd8 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-03-02Bug 541415 - fixed testsI20190303-0600Andrey Loskutov2-15/+24
Change-Id: I3d5a21c60e5f83ddcb061a781a1f2b558d3f11b3 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-02-28Bug 541415 - [Test] Use MOD1 instead of CONTROLMickael Istria1-2/+2
So it should also work on Mac. Change-Id: Ic725f485d6d52f867005964edde1211a1ab87645 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-02-27Bug 541415 - [Test] Add test for code mining Ctrl+Home/EndY20190227-2200I20190228-0300I20190227-1800Mickael Istria5-3/+384
Change-Id: Id50805fd1e5b6f91de27d573a2b6c1850902931f Signed-off-by: Mickael Istria <mistria@redhat.com>
2018-09-23Bug 535964 - Move some non UI classes from jface.text to o.e.text.I20180923-1800Sebastian Ratz1-8/+20
Another update to the #equals() implementation. bb4abd131785dc66b2a4da321ded042fd4e37db1 broke equals() in other scenarios. A = org.eclipse.text.templates.TemplatePersistenceData B = org.eclipse.jface.text.templates.persistence.TemplatePersistenceData Properly implement equals() in the super class (A) and in the deprecated subclass (B), such that the symmetric property of equals holds: A.equals(B) B.equals(A) This is ensured by always using B as a dummy and delegating via "ref". In the super type A introduce a new dummy UUID just for equals. This simulates the previous object identity semantics for equals (there can exist multiple *different* templates with identical values). Change-Id: Ia34e7019a54464b6f4d95521eddea8e682e87bf1 Signed-off-by: Sebastian Ratz <sebastian.ratz@sap.com>
2018-09-21Bug 535964 - Move some non UI classes from jface.text to o.e.text.I20180922-1800I20180922-0245I20180922-0005I20180921-1800Sebastian Ratz2-1/+50
Fix TemplatePersistenceData#equals implementation. Change-Id: Ie742ce68e685642d81f83bc9eb53a6b72e2a5516 Signed-off-by: Sebastian Ratz <sebastian.ratz@sap.com>
2018-08-21Bug 530393 - EPL 2.0 update for platform.text test bundlesLars Vogel20-60/+120
Update all sources files except .exsd files, Java pref files and pom files Regex used: git checkout master git reset --hard origin/master git pull find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i 's/Eclipse Public License v1.0/Eclipse Public License 2.0/g' {} + find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)http:\/\/www.eclipse.org\/legal\/epl-v10.html/\1\2https:\/\/www.eclipse.org\/legal\/epl-2.0\/\ \1\ \1\2SPDX-License-Identifier: EPL-2.0/' {} + # Get rid of the All rights reserved find . -type f ! -name "*.exsd" ! -name "org.eclipse.jdt.ui.prefs" ! -name "pom.xml" -exec sed -i -E 's/([[:blank:]]*[^[:blank:]])*([[:blank:]]*)(All rights reserved. )/\1\n\1\2/' {} + Change-Id: Ib0696b0bfadec3d64cdc0064d35fb952e3953055 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2018-07-18Sanitize org.eclipse.text.tests.Y20180720-0300Y20180718-2200I20180722-2000I20180721-1500I20180720-2000I20180719-2000I20180718-2000Alexander Kurtakov1-20/+12
Use proper asserts and expected exceptions. Change-Id: Ic3bbc0a8221d40b57e4698f2ed40f0806daa3194 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-06-11[Sonar] Remove dead stored variablesJonas Hungershausen1-2/+1
see https://sonar.eclipse.org/drilldown/issues/33533?rids%5B%5D=33537&rule=findbugs%3ADLS_DEAD_LOCAL_STORE&rule_sev=CRITICAL&severity=CRITICAL and https://sonar.eclipse.org/drilldown/issues/33533?rids%5B%5D=33535&rule=findbugs%3ADLS_DEAD_LOCAL_STORE&rule_sev=CRITICAL&severity=CRITICAL Change-Id: Ie17acc3f3eefb50f7fba564585f3e41947722168 Signed-off-by: Jonas Hungershausen <jonas.hungershausen@vogella.com>
2017-03-08Bug 511101: [Generic Editor] misses quick fix on error markersMarkus Keller1-0/+581
- improved HoverTest (no endless loop, better logging) - removed dependency on platform.ui test bundle - improved ScreenshotTest
2017-01-17Bug 509032 - Support for em, strong, s, strike in HTML2TextRendererI20170117-2000Mickael Istria1-1/+27
Change-Id: I1d09f85107a3137af081200803f5c08d50eecb01 Signed-off-by: Mickael Istria <mistria@redhat.com>
2016-11-07Clean up after bug 506427I20161108-1015I20161108-0800Dani Megert2-2/+6
2016-11-05Bug 506427 - Insufficient is-disposed check in LineNumberRulerColumn::redrawRĂ¼diger Herrmann2-0/+49
Signed-off-by: RĂ¼diger Herrmann <ruediger.herrmann@gmx.de> Change-Id: I0ef8ae88f5612cb0c7302bbe37df9836f5f22d27
2016-04-04Bug 487095: Move test bundles to JUnit 4Y20160407-1000I20160405-0800Markus Keller2-17/+19
- implement JUnitSourceSetup as ExternalResource - clean up test suites - update manifests - use @Rule TestName to access test method names FindReplaceDialogTest: - fix test order - fix wrong @Before tearDown() Change-Id: Ibae60f592ea81dbbf2fab0db8daf64f92301dcdd

Back to the top