Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-09-22Bug 575893 - [performance] improve file search: avoid synchronizationI20210924-0200I20210923-1800I20210922-1800Joerg Kubitz3-56/+50
FileSearchQuery did spend the most time in waiting for synchronization. By using a ConcurrentHashMap the lock congestion can be avoided Requires flushMatches AFTER searching a file (i.e of the single current file of the thread) - not at start (i.e. of all other files which are handled in parallel). Change-Id: If412e738dcf3a36034836c9a2f0a2af1af839ddd Signed-off-by: Joerg Kubitz <jkubitz-eclipse@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185196 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-09-22Bug 575893 - [performance] improve file search: cache CharSequenceJoerg Kubitz1-1/+16
Use up to 2MB temporary memory to improve the pattern match. During file search a custom CharSequence with a complicated charAt() is passed. (with a blocked buffer, which needs too switch blocks if position falls out of block range.) The charAt() is the hotspot during pattern matching. By converting the sequence once (linary) into a String the String.charAt() nicely inlines (with well known constant time behaviour for String.charAt()). Change-Id: I123732a6052ee536a0f968432b5c5fc7bdf7e4ad Signed-off-by: Joerg Kubitz <jkubitz-eclipse@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185195 Tested-by: Platform Bot <platform-bot@eclipse.org> Tested-by: Lars Vogel <Lars.Vogel@vogella.com> Reviewed-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-09-21Bug 575608 - Double click beyond EOL should select last wordI20210921-1800Thomas Wolf2-3/+17
Change-Id: Icc7996eb5baee6cbb6c9e0340f5989353c8a5762 Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/184385 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-09-20Bug 575872 - Paste is brokenI20210920-1800Mickael Istria2-3/+14
Change-Id: I509a09555789b634e956b81e89ceb1150f45af6a Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185587 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-09-15Static inner class for SpellingReconcileStrategyI20210919-1800I20210919-0120I20210918-1800I20210917-1800I20210917-0000I20210916-2150I20210916-1800I20210915-1800I20210915-0700I20210915-0510Lars Vogel1-1/+1
Using JDT clean-up to convert to inner class. Change-Id: I422d9cbf44d0a428cf616f3c0242406d00ffabc0 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185448 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-09-15Static inner class for AdditionalInfoControllerLars Vogel1-1/+1
Using JDT clean-up to convert to inner class. Change-Id: I84d8931a24edeccc9c99c589a8078b3bd4018f4f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185447 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-09-15Bug 575893 - [performance] improve Search result speedI20210915-0150Joerg Kubitz1-1/+18
Avoid to query all Line Results of the file for every Line again. Now query every files Result only once. Change-Id: I1b73e4b4a9c00ff065ce86cfdc91b027569117ae Signed-off-by: Joerg Kubitz <jkubitz-eclipse@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185270 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-09-14Bug 575893 - avoid synchronization between UI and search workersI20210914-1800Joerg Kubitz2-14/+24
The search worker thread did synchronize with the UI Thread. Now the search does not need to wait for updating the UI anymore. The workers called postUpdate() while the UI was drawing in runBatchedUpdates()/elementsChanged(). By using a concurrent Datastructure the synchronisation can be avoided. Change-Id: I64248a05ef2f4d4d9960e90b7be3628e0360bfa0 Signed-off-by: Joerg Kubitz <jkubitz-eclipse@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185271 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-09-14Bug 575893 - [performance] improve file search: unordered resultJoerg Kubitz5-117/+91
AbstractTextSearchResult did spend the most time in waiting for synchronization. By using concurrent datastructures the lock congestion can be avoided. Also the binary search can be avoided until the result is needed. Requires to sort the result when optaining it. If the sort order is not needed it is avoided. The order of reported matches found (with equal offset and length) is not preserved (Does not make sense during parallel search anyway). Previously the order of a single threaded search had been preserved (which was a overshoot - Bug 58417 only requested to have the offset ordered) Change-Id: I6e3134fada904faf32352d5c71035e7881cf49db Signed-off-by: Joerg Kubitz <jkubitz-eclipse@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185198 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-09-14Bug 287827 - MarkerHighlighter can block the UI threadSimeon Andreev1-5/+118
This change moves marker related resources API calls in MarkerHighlighter to dedicated jobs, to avoid running the respective code in the UI thread. Change-Id: I8328c3cdabba0bcdb36b85043942ca4c6b4a7207 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185105 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
2021-09-14Bug 575520 - Fix CodeFormatterTest testsMickael Istria2-233/+256
Change-Id: I259ed992d4754a7eb72fe9216270ad1d214cd27d Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185400 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-09-13Bug 575942 - "Home" & "End" don't work anymore in text editorsI20210913-2050Mickael Istria3-8/+39
Change-Id: I7facc9f20f0b66c16983ec1d2d516271af5323b3 Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185367 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-09-13Bug 575641 - restore silence on error in readDocument()Andrey Loskutov1-2/+0
That produces lot of irrelevant log entries with async editor diff operations on quickly changing resources. Change-Id: I7eee3163df092256f367c48400df453525e6f868 Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185357 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-09-10Bug 575893 - [performance] improve file search: non-regexpI20210911-1800I20210910-1800Joerg Kubitz2-30/+66
Use Pattern.quote for non-wildcards in non-regexp search instead of escaping each single character. Change-Id: I061506448cdde5ab17ad1b9c551111472acf47eb Signed-off-by: Joerg Kubitz <jkubitz-eclipse@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185193 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-09-10Static inner class for IndentFolderingStrategyLars Vogel1-1/+1
Using JDT clean-up to convert to inner class. Change-Id: I7b0b707b27f9e7d53a2a9f0c74681275bbde1178 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185281 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-09-104.22 update of org.eclipse.ui.genericeditorLars Vogel1-1/+1
For https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185281 Change-Id: I57ea5746d29a05f6ac06788e0b6d089dfc3e97c3 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185294 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-09-10Bug 575909 - AIOOBE in StyledText.setSelection viaMickael Istria2-1/+13
StructuredTextViewer.handleDispose Change-Id: Ie3c704137368372a720abab4ff49710e29844d3b Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185296 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-09-09Bug 575900 - Line selection brokenI20210909-1800Mickael Istria5-6/+105
Change-Id: I8300bf2635f6527bed0300f09feea48221553f7c Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185268 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-09-09Bug 575641 - Text editor fails to open for very large text filesSimeon Andreev5-13/+36
This change adds a catch for OutOfMemoryError to setDocumentContent() in ResourceTextFileBuffer, FileStoreTextFileBuffer and LastSaveReferenceProvider. The OOM is wrapped in an IOException and is rethrown as a CoreException, relying on the CoreException handling further up in the call stack trace. Change-Id: I1ad32be1c1733106c3516c5914ab7784fcc57972 Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/184513 Tested-by: Andrey Loskutov <loskutov@gmx.de> Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Jörg Kubitz <jkubitz-eclipse@gmx.de> Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
2021-09-09Bug 575893 - fixed CharSequence.toString contractsJoerg Kubitz3-0/+17
An implementation of CharSequence has to fullfill the CharSequence.toString contract. Change-Id: I23022218dba00c1e7c0ad32cfbfe358981481371 Signed-off-by: Joerg Kubitz <jkubitz-eclipse@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185262 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-09-09Bug 575641 - bump versions for 4.22Andrey Loskutov2-2/+2
Change-Id: If5fade133d3d07e236553afca0ddb843d597f3d9 Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185260 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-09-09Version update of org.eclipse.search.tests for 4.22Joerg Kubitz2-2/+2
for Bug 575893 - [performance] improve file search Change-Id: I399a5d4a8a8d33290cbaddf502c75104ffe81026 Signed-off-by: Joerg Kubitz <jkubitz-eclipse@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185242 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-09-09Bug 575893 - [performance] improve file search: file sortJoerg Kubitz1-18/+21
Avoid file.getLocation() during sort: only calculate location once. Change-Id: Ic0953c430385c74d4b879347ac1699f38c9099d5 Signed-off-by: Joerg Kubitz <jkubitz-eclipse@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185194 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-09-094.22 version increase for org.eclipse.searchJoerg Kubitz1-1/+1
for Bug 575893 - [performance] improve file search Change-Id: I4b86c7fca41b491a64fda80cb77445965dbf1edf Signed-off-by: Joerg Kubitz <jkubitz-eclipse@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185201 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-09-09Bug 466532 - Fix warning in I-buildAlexander Kurtakov1-2/+1
Change-Id: I8cdfae6c522a5677b4a07498fc5b7815a3d5566d Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185191 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-09-09Bug 575872 - Paste is brokenMickael Istria2-1/+15
Change-Id: I88d659da7acce06359040cfc3f5537a5e85d70a7 Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185178 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-09-07Bug 466532 -Support multipleI20210908-1800I20210907-1800Mickael Istria16-321/+1044
carets/cursors/selections for text manipulation + Made line & word start/end commands capable of multi-carets + Support pasting multiple tokens + Added command to turn block selection into multi selection Change-Id: Ibb0c1819a197ca409fadfe2a0b8ce133762f6d9e Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/153689 Reviewed-by: Mickael Istria <mistria@redhat.com> Tested-by: Mickael Istria <mistria@redhat.com>
2021-09-06Bug 575782 - POM and product version change for 4.22 releaseI20210906-1800I20210906-1000I20210906-0820I20210906-0610Kit Lo11-11/+11
Change-Id: If49af82d9baa582b52a89a73e6b74f355e935904 Signed-off-by: Kit Lo <kitlo@us.ibm.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/185016 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2021-08-20Bug 575509 - IllegalArgumentException in OverviewRuler.doPaintY20210914-1140Y20210914-1110Y20210914-0800Y20210913-0800Y20210912-0800Y20210911-0800Y20210910-0800Y20210909-0800Y20210908-0800Y20210907-0830Y20210907-0800Y20210906-0920Y20210904-0800Y20210903-0800Y20210902-0850Y20210902-0350Y20210901-0420Y20210831-0840Y20210826-0800Y20210824-0940Y20210824-0840Y20210822-0440S4_21_0_RC2aS4_21_0_RC2S4_21_0_RC1aS4_21_0_RC1R4_21I20210906-0500I20210901-1800I20210901-0600I20210831-1800I20210831-0600I20210830-1800I20210830-0600I20210829-1800I20210829-0600I20210828-1800I20210828-0600I20210827-1800I20210825-1800I20210825-0600I20210824-1800I20210824-0600I20210823-1800I20210823-0600I20210822-1800I20210822-0600I20210821-1800I20210821-0600I20210820-1800R4_21_maintenanceAndrey Loskutov1-1/+3
Change-Id: Ic75b78a48eb00576ef5f30df9c659fbdb7c3a1b2 Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/184239 Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-08-12Bug 575375 - Update scm links in pom files to use https protocolY20210820-0230Y20210819-0800Y20210819-0340Y20210818-0520Y20210817-1030Y20210817-0500Y20210813-0710Y20210812-0800S4_21_0_M3I20210818-1800I20210818-1250I20210818-0600I20210817-1840I20210817-0600I20210816-1800I20210816-0600I20210815-1800I20210815-0600I20210814-1800I20210814-0600I20210813-1800I20210812-1800Sravan Kumar Lakkimsetti1-1/+1
Change-Id: Ifef9c1ad149358aaae55cb4e5e26940190b07758 Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/183942 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-08-06Bug 575242 - improved isMatchToBeIncluded() check complexityY20210810-0820Y20210810-0500I20210811-1800I20210810-1800I20210809-1800I20210808-1800I20210807-1800I20210806-1800Andrey Loskutov1-7/+8
isMatchToBeIncluded() iterated over every element of the already processed matches map to check if file matches are equal according to URIUtil criteria. However, that is only needed if same file match is not yet in the map - so for every match on same file we iterated through all map keys, instead of immediate map lookup & return. That greatly speeds up initial text replace preparation on search with few matches per file and many files. Change-Id: Id620232098142e27f823344501630c891ad16afc Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/183748 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2021-08-06Bug 575242 - fixed progress reporting and cancellation on replaceAndrey Loskutov1-9/+26
For many elements to be changed, initial preparation phase caused UI to hang without any progress and any chance to cancel the long running operation. Added progress monitors checks and reporting through the relevant parts of code, so that operation is not blocking anymore and shows some decent progress. Change-Id: Icb5c8beb59ddeea39c59901b655fea59997dbde6 Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/183747 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2021-08-06Bug 575242 - fix elementsChanged() to not refresh viewer too muchAndrey Loskutov1-17/+25
Don't refresh viewer on every changed element, that makes UI completely unresponsible if there are too many search matches. Instead, refresh viewer only once - either if only one element changed, on concrete element, or after all elements are updated in elementsChanged(). That reduces ~10 minutes wait time to a second. Change-Id: I04e6c64cc3319cd5416f4b512d983e76cb081946 Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/183701 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
2021-07-24Bug 567321 - "Go to last edit location" doesn't work after closingY20210805-0800Y20210804-1030Y20210730-0530Y20210729-0800Y20210727-0800I20210805-1800I20210804-1800I20210804-0930I20210730-1800I20210729-1800I20210729-0050I20210728-1800I20210727-1800I20210726-1800I20210725-1800I20210724-1800Andrey Loskutov4-12/+65
editors Don't browse backwards in history on closing or changing editor input. Change-Id: I14353a7b494bddd84ef5177b8801f208d27a1fd1 Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/183341 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-07-21Bug 574939 - Move to Tycho 2.4.0Y20210722-0800I20210723-1800I20210722-1800I20210721-1800I20210721-0530Sravan Kumar Lakkimsetti1-1/+1
Change-Id: Ica984332c19a47074d683ffbb37cacb05d840845 Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/183221 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-07-16Bug 537415 Fix npe in ContentAssistant.showY20210720-0800Y20210719-0550I20210720-1800I20210719-1800I20210718-1800I20210717-1800I20210716-1800Christian Dietrich1-0/+2
Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de> Change-Id: I036cd02358c48e7e94871d4397cfacecbda63e5f Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/183111 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Andrey Loskutov <loskutov@gmx.de>
2021-07-13Bug 574667 - Use Jenkins multibranch pipeline based onY20210715-1150Y20210715-1000Y20210715-0820Y20210713-0800I20210716-0020I20210715-2200I20210715-1800I20210714-1800I20210713-1800Mickael Istria1-0/+70
Jenkinsfile+Gerrit Change-Id: I3f83202ca22241e3e0408ff7140240b11d3dad94 Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/182860 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-06-29[dogfooding][cleanup] Use static inner class clean up forY20210708-0800Y20210706-1050Y20210706-0800Y20210701-0800Y20210630-0410Y20210630-0230S4_21_0_M1I20210712-1800I20210712-0340I20210712-0240I20210711-1800I20210710-1800I20210710-0000I20210709-0030I20210707-1800I20210707-0600I20210706-1800I20210706-0600I20210705-1800I20210705-0600I20210704-1800I20210704-0600I20210703-1800I20210703-0600I20210702-1800I20210701-1800I20210630-1800I20210629-1800Lars Vogel5-5/+5
test code Using this cleanup brings: - It reviews the feature - For optimization: small memory usage reduction as the outer pointer is removed Change-Id: Id3b4fcee22e52183fd8f00740e0ba4d152954e1c Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/179071 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-06-294.21. update org.eclipse.ui.editors.testsLars Vogel2-2/+2
For https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/179071 Change-Id: I6bf3168c1add01b07525f2bfe66dd66634636eb9 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/182599 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-06-294.21. update text.testsLars Vogel2-2/+2
For https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/179071 Change-Id: I961fdfa67522bcb8a3f5e4b929276e952db9befb Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/182588 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-06-22Use JDT static inner class clean up forY20210629-0800Y20210623-0320Y20210622-1150I20210629-0210I20210628-1800I20210627-1800I20210626-1800I20210625-1800I20210624-1800I20210624-1210I20210622-1800Lars Vogel3-3/+3
ui.editors This ticket uses and tests the "Use static inner class" cleanup feature: - It reviews the feature - It reduces the memory consumption as it avoids the pointer to the outer class Example: Before: public class Outer { public class InnerClass { int i; public boolean anotherMethod() { return true; } } } After: public class Outer { public static class InnerClass { int i; public boolean anotherMethod() { return true; } } } Change-Id: Id13454b3c8e1e8ca6628d4f15cc6f0aec37cd62a Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/181573 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-06-174.20 update of org.eclipse.ui.workbench.texteditor.testsI20210621-1800I20210620-1800I20210619-1800I20210618-1920I20210618-1800I20210617-1800Lars Vogel2-2/+2
Required for https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/179071 Change-Id: I784bc7c189a93086e0c0efe8b75d9e0ee2e960f5 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/180764 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
2021-06-16Use JDT static inner class clean up for search plug-insI20210616-1800Lars Vogel2-2/+2
This ticket uses and tests the "Use static inner class" cleanup feature: - It reviews the feature - It reduces the memory consumption as it avoids the pointer to the outer class Example: Before: public class Outer { public class InnerClass { int i; public boolean anotherMethod() { return true; } } } After: public class Outer { public static class InnerClass { int i; public boolean anotherMethod() { return true; } } } Change-Id: If2fd5457666e4161e3eafa25893b0ec38d8eb36a Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/181576 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
2021-06-164.21 update of org.eclipse.text.quicksearchLars Vogel1-1/+1
For https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/181576/ Change-Id: I51fe4547d011d2631b98abb9290b0e3e28fea9ab Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/181856 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-06-15Bug 574216 - IOOBE in CompletionProposalPopup.selectProposalI20210615-1800Andrey Loskutov1-10/+15
Guard from direct access on ever changing fFilteredProposals refrence and check for index inside fFilteredProposals bounds. Change-Id: I1946c255b54c87724624d5a29cf9b44fc3911b7d Signed-off-by: Andrey Loskutov <loskutov@gmx.de> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/182010 Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-06-124.21 update of org.eclipse.searchY20210615-0910Y20210615-0900Y20210614-0420I20210614-1800I20210613-1800I20210612-1800Lars Vogel1-1/+1
For https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/181576 Change-Id: Ic2d1bcc24527b6c9ee684151bbd2b82daac82f8d Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/181855 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Lars Vogel <Lars.Vogel@vogella.com>
2021-06-11Bug 574139 - URLHyperlinkDetector: scheme:// is not a hyperlinkY20210611-0900I20210611-2000Thomas Wolf2-1/+8
Make the behavior more consistent between handling quoted and unquoted URLs: https:// would not give a hyperlink, but "https://" or "https:// " would. Change the code to not produce hyperlinks for the latter two. Change-Id: I17f6c16fd96ada810bfc4f635e9d03e8cf5f596b Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/181809 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-06-10Bug 558656 - URLHyperlinkDetector: exclude trailing periodsI20210610-1850Thomas Wolf2-4/+17
While technically allowed, URLs in practice don't end with periods. Exclude them from the match; this gives better results in plain text when a URL occurs at a sentence end. Only periods are excluded; other punctuation is not handled. Change-Id: I290d6b951c1ab196dd3420719653c76527a032ed Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/181769 Reviewed-by: Mickael Istria <mistria@redhat.com> Tested-by: Platform Bot <platform-bot@eclipse.org>
2021-06-10Bug 483858 - Handle URL prefixes in URLHyperlinkDetectorThomas Wolf2-1/+16
Detect quotes around URLs with prefixes to make sure we don't include the closing quote in the link. Change-Id: I565dfb54ac9e7017b8f5fc2a841f2b5a3c5a4905 Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/181768 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>
2021-06-10Bug 574120 - URLHyperlinkDetector: detect leading stop charactersThomas Wolf2-10/+66
If a scheme is followed immediately by stop characters after "://", URLHyperlinkDetector wrongly computed hyperlink regions. Handle this case. Change-Id: I8e1f9b8103627008eb2fd2a46d5612f09c5b801b Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch> Reviewed-on: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/181767 Tested-by: Platform Bot <platform-bot@eclipse.org> Reviewed-by: Mickael Istria <mistria@redhat.com>

Back to the top