Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-12-16Bug 569739 - Fix duplicate handlerY20210108-1200Y20210105-1200Y20210101-1200Y20201229-1200Y20201229-0040Y20201225-1200Y20201222-1200Y20201218-1200S4_19_0_M1I20210108-1800I20210108-0220I20210106-1800I20210106-0600I20210105-1800I20210105-0600I20210104-1800I20210104-0600I20210103-1800I20210103-0600I20210102-1800I20210102-0600I20210101-1800I20210101-0720I20201231-1800I20201230-2150I20201230-1800I20201229-1800I20201228-1800I20201227-1800I20201226-1800I20201226-0940I20201225-1800I20201225-0450I20201225-0130I20201224-1800I20201223-1800I20201222-1800I20201221-1800I20201220-1800I20201219-1800I20201218-1800I20201217-1800I20201216-2110Mickael Istria1-2/+2
Change-Id: I40d408f48b9c23800d5061344c6fbc79bcbd0ad7 Signed-off-by: Mickael Istria <mistria@redhat.com>
2020-12-15Bug 569701 - Generic Editor misses collapse/expandI20201215-1800Mickael Istria10-7/+246
This change adds a generic handlers bound to various folding commands. This handler is enabled whenever activePart adapts to ITextOperationTarget, so it enables folding commands on most views and editors that leverage folding. Change-Id: I0c054a66b93a45f34497a6dd4f488f650d9de0db Signed-off-by: Mickael Istria <mistria@redhat.com>
2020-12-15Added icons for collapseAll/expandAllY20201215-1200Mickael Istria12-11/+45
Icons taken for platform.ui, used also for collapse/expand all in tree. + Move to Java 11 as BREE Change-Id: I7862f1ce917a242e88a7e4e770164b8c605535ef Signed-off-by: Mickael Istria <mistria@redhat.com>
2020-12-14Bug 564723 - Test showcasing new line indent issue is not in PlatformI20201214-1800Mickael Istria6-12/+80
Test passes with Platform only; same test with TM4E would fail. Move BREE to Java 11 by the way to get rid of some warning. Change-Id: Ie050022aae375b15e9249ea69508237601a72fa2 Signed-off-by: Mickael Istria <mistria@redhat.com>
2020-12-12Bug 569641 - LineNumberRulerColumn sometimes wrongI20201213-1800I20201212-1800Mickael Istria2-29/+24
Prior to this patch, the LineNumberRulerColumn was only looking at the "bounds" of the visible area to decide whether to redraw lines or not. We now look at the line position and size as there can be some changes (code mining added and removed) which do not affect bounds but should affect line numbers rules. Change-Id: I913b6ccaefb7ba78c65daef1d85f9294b9163d92 Signed-off-by: Mickael Istria <mistria@redhat.com>
2020-12-11Bug 45017 - Widen key bindings to In WindowsY20201211-1200I20201211-1800Christian Gabrisch2-3/+1
Widen key bindings for Find next, Find previous to context In Windows. Then, console can provide implementations without redefining key shortcuts. Change-Id: I1e87e3c11bec855a93ba4d556544cffceb626143 Signed-off-by: Christian Gabrisch <eclipse@cgabrisch.de>
2020-12-01Bug 569318 - POM and product version change for 4.19 releaseY20201209-0750Y20201208-1200Y20201204-1200I20201210-1800I20201209-1800I20201208-2310I20201208-1800I20201208-0300I20201207-1800I20201206-1800I20201205-1800I20201204-1800I20201204-0830I20201204-0610I20201204-0340Sravan Kumar Lakkimsetti11-11/+11
Change-Id: I7b5dbb4e9c7b595150fed8e21d6db92d0ac98aa7 Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2020-11-16Bug 568863 - MultiPageMinimapPage is not disposed correctlyY20201201-1200Y20201127-1200Y20201124-1200Y20201120-1200S4_18_0_RC2S4_18_0_RC1R4_18I20210122-0800I20210122-0630I20210122-0420I20201202-1800I20201202-0600I20201201-1800I20201201-0600I20201130-1800I20201130-0600I20201129-1800I20201129-0600I20201128-1800I20201128-0600I20201128-0300I20201127-1800I20201127-1010I20201127-0630I20201125-1800I20201125-0600I20201124-1800I20201124-0600I20201123-1800I20201123-0600I20201122-1800I20201122-0600I20201121-1800I20201121-0600I20201120-1800R4_18_maintenanceSebastian Ratz1-11/+20
Change-Id: I883eb63870feee859364ab38f03d602a8c2f00cc Signed-off-by: Sebastian Ratz <sebastian.ratz@sap.com>
2020-11-16Search dialog should remember last tab used by defaultY20201117-1200S4_18_0_M3I20201120-0320I20201119-0730I20201118-1800I20201118-0600I20201117-1800I20201117-0600I20201116-1800I20201116-0600Chenhui Xu1-1/+1
Enable the remember last used page as default. User can change that via the preferences. bug: 13129 Change-Id: I4a353cbabe3400e5ee705abb2279ccf5a5ddd35f Signed-off-by: Chenhui Xu <chenhuixu1999@gmail.com>
2020-11-16Move rememberLastUsedPage button to SearchPreferencePageChenhui Xu4-21/+16
To make the setting intuitive, this change moves the rememberLastUsedPage button from Customize area to search preference page. User can go to system preference to decide if the last used page of search should be remembered. Bug: 568786 Change-Id: Id6cdbba9b36cdf6eeba839b67d5beb1fa952a58b Signed-off-by: Chenhui Xu <chenhui.xu@vogella.com>
2020-11-12Bug 567618 - NPE in AdditionalInfoController.computeInformationY20201113-1200I20201115-1800I20201115-0600I20201114-1800I20201114-0740I20201114-0600I20201113-1800I20201112-1800Andrey Loskutov1-29/+54
Either subclasses manage to change values on callbacks between we access fields, or the code can be executed in parallel. I believe latter is the case. I didn't found a way to reproduce access from multiple threads, and do not see that from code inspection, but the sporadicity of this issue is most likely caused by MT access. So changed affected fileds to volatile & reduced access to them to single reads. No locks introduced, because without further information how this bug could happen, this would be too dangerous. Change-Id: Ifdaf2bea160eb314578529ccc6290b259dd18872 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-10-30Bug 568402 - Build with Tycho 2.1.0 releaseY20201111-0210Y20201110-1200Y20201109-1200Y20201109-0220Y20201108-1200Y20201107-1200Y20201106-1200Y20201105-1200Y20201104-1200Y20201103-1200Y20201102-1200Y20201101-1200Y20201031-1200I20201111-1800I20201110-1800I20201109-1800I20201108-1800I20201107-1800I20201107-0750I20201106-1800I20201106-0710I20201105-1800I20201105-0230I20201104-1800I20201103-1800I20201103-0030I20201102-1910I20201101-1800I20201031-1800I20201030-1800Alexander Kurtakov1-1/+1
Change-Id: I637577386750fd55fe3a3f87497755bd1cf57608 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-10-29Bug 568328 - Change org.eclipse.core.filebuffers to use an util classY20201030-1200Y20201029-1200I20201029-1800Lars Vogel8-48/+15
instead of an activator As other plug-ins may also access the string constant the name FileBuffersPlugin is left as is. The logging via the activator has been replaced by standard platform logging. Also the access to the ITextFileBufferManager has been moved to a static method and field, so the activator is not required anymore. Change-Id: I394e121d7a65f82788231bb6b59287d6438cdb7a Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-10-28Update of org.eclipse.core.filebuffersY20201028-1200I20201028-1800I20201028-0800Lars Vogel1-1/+1
Required for https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/171390 Change-Id: Ib2339b44bf91b89ff03887754f6495e0552c761b Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-10-26Bug 568231 - Quick Search file pattern match doesn't work as expectedI20201028-0610I20201028-0130I20201028-0020I20201027-2350I20201027-1800Paul Pazderski5-11/+57
QuickSearch use the right text box to enter filename/path patterns to limit the files to search in. It allows a comma separated list to include multiple patterns. Before this change it works only reasonable without spaces around the separating commas. Possible spaces where not removed from the separated pattern and a pattern with leading or trailing spaces rarely matches anything. (that's why a single pattern is already trimmed) Change-Id: I36ac86ede8ebec790c79a493dad517369f3ea72b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-10-02Bug 567543 - Replace usage of Platform.getAdapterManager().getAdapter()Y20201027-1200Y20201026-1200Y20201025-1200Y20201024-1200Y20201023-1200Y20201021-1200Y20201020-1200Y20201019-1200Y20201018-1200Y20201017-1200Y20201016-1200Y20201015-1200Y20201014-1200Y20201013-1200Y20201012-1200Y20201011-1200Y20201010-1200Y20201009-1200Y20201008-1200Y20201006-1200Y20201002-1200S4_18_0_M1aS4_18_0_M1I20201026-1850I20201026-0840I20201026-0650I20201025-1800I20201025-0040I20201024-1800I20201023-1800I20201023-0250I20201021-1800I20201021-0200I20201020-1800I20201020-0240I20201019-1800I20201018-1800I20201017-1800I20201016-1800I20201016-0000I20201015-1800I20201014-1800I20201013-1800I20201012-1800I20201012-0750I20201012-0320I20201011-1800I20201010-1800I20201009-1800I20201009-0800I20201009-0430I20201007-1800I20201007-1320I20201007-0600I20201006-1800I20201006-0840I20201006-0600I20201005-1800I20201005-0600I20201004-1800I20201004-0600I20201003-1800I20201003-0600I20201002-1800Lars Vogel1-2/+2
with Adapters Change-Id: I86f00a7bea1be7d40a2c52011222160362466b74 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-09-25Removes unnecessary Color#dispose calls TextPresentationTestY20201001-1200Y20200930-1200Y20200929-1200Y20200929-0550Y20200928-1200Y20200928-0700Y20200928-0600I20201001-1800I20200930-1800I20200929-1800I20200928-1800I20200927-1800I20200926-1800I20200925-1800Lars Vogel1-5/+0
Change-Id: If23d801d5c144420f9b9ec349d78f3c166acde3a Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-09-254.18 update for org.eclipse.jface.text.testsLars Vogel2-2/+2
For pending Gerrits Change-Id: If787bd7007869aaa8e6651bc69656cd98c02360c
2020-09-25Improve TextEditorPluginTestAlexander Kurtakov1-20/+20
* Use assertEquals instead of assertTrue for better error messages in case of failure * Fix some warning about boxing operations. Change-Id: Ie1969f516f5590dae9ed17c4d9e648dc56a6fcef Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-09-25Version bumps for 4.18.Alexander Kurtakov2-2/+2
Change-Id: I4515960224a8838dcfd042b22b4dfdbadd256722 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-09-25Remove no longer needed api problem filtersAlexander Kurtakov3-33/+0
Change-Id: Ie646dbf92b9ca150317744ae38ecfdbc033e38ea Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-09-25Version bump for 4.18Alexander Kurtakov1-1/+1
Needed by https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/169876 Change-Id: I1e7a78471815a59eb3ac130d20ff228a86a5b192 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-09-25Removes unnecessary Color#dispose calls from SearchResultViewerLars Vogel1-2/+0
Change-Id: I9570b569dd4db1b973e7abf108276a4b6e25b6e4 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-09-25Version bump for 4.18Alexander Kurtakov1-1/+1
Needed by https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/169738 Change-Id: Ied74cf1206c2560820cf379c6ca624f9d5cf260c Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-09-23Removes dispose call for color in TextEditorDefaultsPreferencePageI20200924-1800I20200924-0430I20200924-0340Lars Vogel1-1/+0
Change-Id: I597bb277e6acc66d3c01f9cab32e0746a196f175
2020-09-23Bug 528012 - setRules method in RuleBasedScanner should use vargsLars Vogel2-2/+2
Updated Author as Ivo does not have a valid licence agreement anymore. Change-Id: I83b4f6eaa2cc29ab985a558397d6220611d21ee4 Signed-off-by: Ivo Gosemann <ivo.gosemann@sap.com>
2020-09-15Bug 566317 - Replace Helper with JFace Util.isValid in content assistsI20200922-1800I20200921-1800I20200920-1800I20200919-1800I20200918-1800I20200917-1800I20200916-1800I20200916-0410I20200915-1800Lars Vogel12-181/+133
Change-Id: Iede1dcb37b946485cd981a80dd796e5b14d4027e Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-09-144.18 update for org.eclipse.jface.textI20200914-1800Lars Vogel1-1/+1
Required for https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/169275 Change-Id: Ibe4f9327377b549b2be90811212533de080f1caf Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-09-10Bug 566872 - Generic Editor adds UNDEFINED_VARIABLE for enabledWhenI20200913-1800I20200912-1800I20200912-0010I20200911-1800I20200910-1800Mickael Istria4-99/+126
This allows to use variables in any case, without receiving an ExpressionException if undefined Change-Id: I506d7f6f233a068f266868133c500240bf83d1ab Signed-off-by: Mickael Istria <mistria@redhat.com>
2020-09-10Bug 566757 - Remove encoding migration inLars Vogel3-38/+2
FileDocumentProvider#getPersistedEncoding from 2004 (Bug 54058) Change-Id: Ia38c21a513b19b981dfc867a80cb0ec6ffe55971 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-09-10Bug 566848 - Shorter the file has been deleted textLars Vogel1-1/+1
Change-Id: I991de9c5e029131733402d7423d17a376bc3c2c0 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-09-104.18 update of org.eclipse.ui.workbench.texteditorLars Vogel1-1/+1
Require to update some text to a shorter form in Bug 566848 Change-Id: I7b1d3b81750cae39b7212c2dd5a963cd1894c236
2020-09-07Bug 566667 - Remove migration code for Bug 82987 (Eclipse 3.1)I20200910-0100I20200909-1800I20200908-1800I20200908-0440Lars Vogel1-21/+0
Change-Id: If8cb62efd415333f91a02a3eb6c16cb50a63741a Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-09-074.18 update of org.eclipse.ui.editorsLars Vogel1-1/+1
Requires for https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/168802 Change-Id: I5d071d6f5c4259ccc19b22f06976f07b3c097306
2020-09-03Bug 566356 - POM and product version change for 4.18 releaseI20200904-0540I20200904-0210Alexander Kurtakov11-13/+11
Change-Id: Ied35e159e9e535c7d193b0594bc548fc3dbf3583 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-08-28Bug 566471 - I20200828-0150 - Comparator Errors FoundY20200915-2240Y20200915-0150Y20200914-1200Y20200913-1200Y20200912-1200Y20200911-1200Y20200910-1200Y20200909-1200Y20200908-1200Y20200907-1200Y20200903-2210Y20200901-1200S4_17_0_RC2R4_17I20200902-1800I20200902-0600I20200901-1800I20200901-0600I20200831-1800I20200831-0600I20200830-1800I20200830-0600I20200829-1800I20200829-0600I20200828-1800R4_17_maintenanceSravan Kumar Lakkimsetti8-5/+11
Change-Id: Iaf7e3f15913440ffd0ad8c29b21bf75c43f4c0a4 Signed-off-by: Sravan Kumar Lakkimsetti <sravankumarl@in.ibm.com>
2020-08-12Bug 565954: rename Last Edit Location to Previous Edit LocationY20200825-1200Y20200824-1310Y20200823-1200Y20200822-1200Y20200821-1200Y20200820-1200Y20200819-1200Y20200818-1200Y20200817-1210Y20200817-0450Y20200816-1200Y20200815-1200Y20200814-1200Y20200814-0650Y20200814-0630Y20200813-1200S4_17_0_RC1S4_17_0_M3I20200828-0150I20200826-1800I20200826-0600I20200825-1800I20200825-0600I20200824-1900I20200824-0600I20200823-1800I20200823-0600I20200822-1800I20200822-0600I20200821-1800I20200821-0440I20200820-0230I20200819-1800I20200819-0600I20200818-1800I20200818-0900I20200818-0600I20200818-0340I20200817-1800I20200817-0920I20200817-0600I20200817-0450I20200816-1800I20200816-0600I20200815-1800I20200815-0600I20200814-1800I20200814-1040I20200814-0640I20200814-0330I20200813-1800Ari Kast6-25/+25
Change-Id: I0baeef3d4eae193cf9af2c1c18854eb1839d9b4f
2020-08-12Bug 72773: store and navigate multiple edit history locationsY20200812-1200I20200812-1800I20200812-0710Ari Kast6-20/+34
update key mapping Change-Id: Icbe3e8a2c37b71028afc401b297b9c6d244e5129
2020-08-11Bug 565991 - Build with Tycho 2.0.0I20200811-1800Alexander Kurtakov1-1/+1
Change-Id: Ifdfa7d4a00d324e921cfd4bb76b71557c716f7b7 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-08-10Bug 564929 - Delete line shortcut does not delete last editor lineY20200811-1200Y20200810-1200I20200810-1800Pierre-Yves Bigourdan2-2/+110
Add unit tests for TextViewerDeleteLineTarget. Change-Id: Ic382d1010ad88fddfb61ccd679d55f9401df5fb2 Signed-off-by: Pierre-Yves Bigourdan <PyvesDev@gmail.com>
2020-08-08Bug 552683 - refurbish IProgressMonitor by merge withY20200809-1200Y20200808-1200I20200809-1800I20200808-1800Alexander Kurtakov4-6/+2
IProgressMonitorWithBlocking Adapt platform.text tests as they will not receive the old deprecated class anymore. Change-Id: I561a9ff039461dc43bf33fd76b1af6d4dde25bbc Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-08-07Bug 564891 - Delete org.eclipse.jface.util.Assert andY20200807-1200I20200808-0230I20200807-1800Lars Vogel3-196/+25
org.eclipse.jface.text.Assert as announced via Bug 528191 Change-Id: I1edff700fc9283c48ba66f3a52fa2dcabcfb72cc Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-08-07Bug 72773: store and navigate multiple edit history locationsAri Kast21-89/+1252
This expands existing "last edit location" navigation to now store an ordered queue of multiple last edit locations. The size of the list is configurable (currently set at 15). Once the list is filled, each new location insertion evicts the oldest location to make room for the new. Thus only the last 15 edit locations are ever stored. To avoid wasting list space on multiple similar locations in close proximity to each other, similar edit locations (as determined by a parameterized proximity function) are merged to a single location. Ctrl+Q key mapping still navigates to the last edit location same as before. However, now continuing to hold ctrl and then pressing Q again begins the traversal thru history of prior edit locations. Once traversal stops, future Ctrl+Q actions are now temporarily anchored to this older historical location. M3+Ctrl+Q conversely moves the anchor forward thru edit history, so after traversing backward with Ctrl+Q, you can go forward again by repeatedly pressing Alt/Opt+Ctrl+Q. New edit locations are always inserted at the end of the queue, so that insertion order is always maintained. Insertion of a new edit location also resets the last location "anchor" back to the most recent edit, so that pressing Ctrl+Q once again brings you to the most recent edit rather than a historical one. Change-Id: I885e209b9d9300f8e6226e6cdf64616751ead944
2020-08-06Update the Eclipse formatter to latest version inY20200806-1200I20200806-1800Lars Vogel2-6/+95
org.eclipse.ui.workbench.texteditor Change-Id: I1271afec729e6aff6dd34215d4d908b8d31ae08d Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-08-06Bug 565208: Remove calls to Color.disposeLars Vogel1-10/+0
Change-Id: Ib76ba1c77774832f4ef1303d29dd3cdee56fb27e Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-08-06Use assertThrows rather than ExpectedException.Alexander Kurtakov1-10/+4
Which is deprecated. Change-Id: I75b27bc0ca5c93effedf5a68d6297ff81a00cf1b Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-08-06Use jdk 5 for-each loopCarsten Hammer14-81/+60
Replace simple uses of Iterator with a corresponding for-loop. Change-Id: I786236ff2c37a6455015a5b8fab866f1165531c4 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2020-08-06Remove no longer needed API filters.Alexander Kurtakov3-82/+0
Change-Id: I0634e6c56c058c23b0807caa00bf0d93adc6d110 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-08-06Version bump for 4.17 streamAlexander Kurtakov2-2/+2
Needed by https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/166460 Change-Id: I8c2fe9633213fd28faedb581d1804ebc5132d63f Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-08-03Bug 564863 - Add cause to thrown IAEY20200805-1200Y20200804-1200I20200805-1800I20200805-0750I20200805-0630I20200804-1800I20200803-1800Karsten Thoms1-2/+2
4.17 version update for org.eclipse.jface.text Change-Id: I410a18ff93ccb72608cfca089129b0d7f60dd99f Signed-off-by: Karsten Thoms <karsten.thoms@karakun.com>

Back to the top