Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2020-03-28Bug 561534 - NPE in AdditionalInfoController.computeInformationS4_16_0_M1I20200409-0200I20200408-1800I20200408-0600I20200407-1800I20200407-1210I20200407-0120I20200406-1800I20200406-0600I20200406-0350I20200406-0120I20200405-1800I20200405-0600I20200404-1800I20200404-1220I20200404-0600I20200404-0330I20200403-1800I20200402-2250I20200402-1800I20200402-0850I20200402-0410I20200401-1800I20200331-1800I20200330-1800I20200329-1800I20200328-1800Andrey Loskutov1-0/+4
The code is executed asynchronously, it may happen that the proposal shell is already dismissed by user, so we simply don't need to do anything. Change-Id: I718bda2e8ff7f73830c037c875cbc37328ceaa7d Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-03-21Improved code mining annotation flickeringI20200327-1800I20200326-1800I20200325-1800I20200324-1800I20200323-1800I20200322-1800I20200322-1150I20200322-0300I20200321-1800Niko Stotz2-5/+27
Change-Id: I6a665e89814ff4403474428e3142e8e50b173f30 Signed-off-by: Niko Stotz <eclipse@nikostotz.de>
2020-03-20Removes unnecessary whitespace from text.tests and activate save actionsI20200321-0440I20200320-1800Lars Vogel3-13/+80
Change-Id: Ie6a3345689fa65269437e2aecde6b76648b15338 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-03-204.16 for org.eclipse.jface.text.testsLars Vogel2-2/+2
Change-Id: I5d46028a7468461f3e10a7869b60d600493523bb Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-03-20Push down negation in Range.javaLars Vogel1-4/+4
Using the new JDT refactoring uses < instead of ! and >= which is easier to read Change-Id: Ie1579e5a989fcd0c2f5372491f292bbcb619dc40 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-03-19Bug 401391 - ConcurrentModificationException in AnnotationModelI20200319-1800Sebastian Zarnekow5-6/+172
Use a ConcurrentHashMap for the AnnotationModel attachments to avoid a concurrent modification when the AnnotationIterator is created Change-Id: I3ceeebea8cd7c894fe70adae2378db59c2ac1f1b Signed-off-by: Sebastian Zarnekow <sebastian.zarnekow@gmail.com>
2020-03-194.16 update of org.eclipse.jface.textLars Vogel1-1/+1
Change-Id: I4fd81311077df2cd6c9a2f9e1ccea0091db68e22 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-03-16Use lambdas in CompletionProposalPopupI20200319-0550I20200318-1800I20200318-1400I20200318-1100I20200317-1800I20200316-1800Lars Vogel1-24/+8
Change-Id: I104e2e18b80396bcea9758d83b3fc44127d8979e Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-03-15Bug 560539 - Shorter File changed dialogLars Vogel1-1/+1
Change-Id: If45dcad8af59c8c4714ad57137993f4ab1e0c339 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-03-154.16 update for org.eclipse.ui.workbench.texteditorLars Vogel1-1/+1
Required for https://git.eclipse.org/r/#/c/158395/ Change-Id: Idf3dcbabd13bef643fd104a6d0894ef094021885 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-03-06Bug 560872 - POM and product version change for 4.16 releaseY20200309-1300Y20200308-0700Y20200308-0520X20200313-0410X20200312-1900X20200312-1530X20200312-1210X20200312-0700X20200311-2150X20200311-1900X20200311-0820X20200306-1900I20200315-2240I20200315-1800I20200314-1800I20200313-1800I20200313-0810I20200312-1835I20200312-1800I20200311-1800I20200310-1800I20200310-0810I20200309-1800I20200309-0810I20200308-1800I20200307-1800I20200307-1145Mat Booth11-13/+13
Change-Id: Idc6390c2c7573e553d6b757732cdb21aec0bec9e Signed-off-by: Mat Booth <mat.booth@redhat.com>
2020-02-18Bug 560207 - String concatenation issue in quick search panelY20200409-0600Y20200407-0925Y20200407-0635Y20200407-0550Y20200318-0540Y20200317-0225Y20200316-1300Y20200316-0820Y20200314-1405Y20200313-1100Y20200311-0915Y20200310-0525Y20200305-0600Y20200225-1040X20200306-0700X20200305-1900X20200305-0700X20200304-1900X20200304-0700X20200303-1900X20200303-0700X20200302-1900X20200302-0930X20200302-0700X20200301-1900X20200301-0700X20200229-1900X20200229-0700X20200228-1900X20200228-0700X20200228-0520X20200227-1900X20200227-0700X20200227-0130X20200226-0700X20200225-1900X20200225-0700X20200224-1900X20200224-0700X20200223-1900X20200223-0700X20200223-0250X20200222-0700S4_15_0_RC2S4_15_0_RC1R4_15I20200305-0155I20200304-1800I20200304-0600I20200303-1800I20200303-0600I20200302-1800I20200302-0600I20200301-2310I20200301-1800I20200301-0600I20200301-0030I20200229-1800I20200229-0600I20200228-1800I20200226-1800I20200226-0600I20200225-1800I20200225-0600I20200224-1800I20200224-0600I20200223-2335I20200223-1800I20200223-0600I20200222-1800I20200222-0600R4_15_maintenanceKalyan Prasad Tatavarthi3-8/+4
Changed to separate strings and remove concatenation. Change-Id: Ibf2d3c566434b86c2116299403926a79619c562f Signed-off-by: Kalyan Prasad Tatavarthi <kalyan_prasad@in.ibm.com>
2020-02-18Bug 560259 - NPE inY20200219-1055Y20200219-0850Y20200218-1420Y20200218-1210X20200221-1130X20200221-0700X20200221-0440X20200221-0310X20200221-0050X20200220-1900X20200220-0700X20200219-1900X20200219-0700X20200219-0500S4_15_0_M3I20200221-1800I20200219-1800I20200219-0600I20200218-1800Andrey Loskutov1-0/+3
InlinedAnnotationSupport$UpdateStylesWidth.applyTextPresentation Added null check for ISourceViewer.getAnnotationModel() return value that allowed to be null. Change-Id: Ib0ffbbd3cdec18dc24a0c9de4a8c32ab8f24abe7 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-02-17Bug 560210 - Multiple compilation errors in IDE about unused importsY20200218-0315Y20200218-0120X20200218-0510X20200217-1120I20200218-0600I20200217-1800Andrey Loskutov1-3/+0
Change-Id: I18d6a56ab8832a19b4e4d21d7c096bc7dc9c67bf Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-02-14Bug 558989 - jface text testI20200217-0600I20200216-1800I20200216-1145I20200215-1800I20200215-0600I20200214-1800Kalyan Prasad Tatavarthi1-1/+6
ContextInformationTest.testContextInfo_hide_focusOut fails in nightly builds Disabling the test on Mac Change-Id: I5ac89e171db8c8dda00d72c01a9395c9c956fb49 Signed-off-by: Kalyan Prasad Tatavarthi <kalyan_prasad@in.ibm.com>
2020-02-12Bug 129554 - [preferences] Edit Template: Rename Yes/No buttons andI20200214-0620I20200213-1800I20200213-1520I20200213-1210I20200213-1100I20200213-0640I20200212-1810I20200212-1800Gautier de Saint Martin Lacaze3-4/+15
dialog text Change-Id: I6e336627810b695d77349d21aeceb609e5b8ed70 Signed-off-by: Gautier de Saint Martin Lacaze <gautier.desaintmartinlacaze@gmail.com>
2020-02-11Use map method directly if possibleI20200212-1420I20200212-0910I20200211-1800Lars Vogel5-5/+5
JDT provides a new cleanup which allows to transform code to call methods directly on map instead of accessing the values or the keys before calling the same method. Saves code which we have to read and might be slightly faster. Change-Id: I3673494ffa912c591e617672e254d29885f29772 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-02-11Remove wrong and useless comments.Alexander Kurtakov2-11/+0
The Junit 3 AssertionFailedError is no longer thrown. The comment about JUnit 4 method name rule is useless at this place Change-Id: I780028e19cd48c4957e2abc8183f895343d4c706 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-02-114.15 update for org.eclipse.ui.genericeditor.examplesLars Vogel1-1/+1
Required for https://git.eclipse.org/r/157337 Change-Id: I32fab7bca8626b288f8a0a4f8a112837e1f47c57 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-02-10Convert JUnit 3.x style tests to 4.xAlexander Kurtakov3-213/+181
Change-Id: Id92946c5fc43ce53ebf362ee986fa986543686fc Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-02-10Convert quicksearch.tests to JUnit 4.xI20200210-1800Alexander Kurtakov3-12/+15
Change-Id: Ie68384f883c0dcd94994e3df6f2883ac2b8397dc Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-01-30Bug 559714: No enabledWhen necessary for AnnotationCodeMiningProviderY20200204-0035I20200209-1800I20200208-1800I20200207-1800I20200206-1805I20200205-1800I20200205-0030I20200204-1800I20200203-1800I20200202-1800I20200201-1800I20200131-1800Matthias Becker1-8/+0
Change-Id: Ic4278ffbdc1010c9cbac64f5223df0e4437cee77
2020-01-30Bug 559712: CodeMiningProvider should not enforce enabledWhenI20200130-1800Matthias Becker1-3/+4
Change-Id: Iafb17b750e9baaaa8073ec267e6aca9438743917
2020-01-29Bug 559665: Remove workaround for bug 552760Y20200130-0045I20200129-1800Matthias Becker1-7/+1
Bug 552760 is fixed in the meantime. In addition just catching NPEs hides other bugs. Change-Id: I64446ff9b212bc1f619250ae8033deb3385b57c7 Signed-off-by: Matthias Becker <ma.becker@sap.com>
2020-01-24Bug 559508: Annotations Code Mining shouldn't check content typeI20200129-0935Matthias Becker1-5/+0
Change-Id: Ibc8ca36b66e0f410b1ff47e9bf6aff0955d2cd6f Signed-off-by: Matthias Becker <ma.becker@sap.com>
2020-01-24Use method reference instead of lambdas in SourceViewerDecorationSupportY20200127-1055Y20200126-2245I20200129-0100I20200128-1805I20200127-1800I20200126-1800I20200126-0250I20200125-1805I20200124-1800Lars Vogel1-1/+1
Method references are slightly faster than lambdas and better readable. Change-Id: I905142784bf92dce38491d360fb5ff7354483281 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-23Optimize lambdasI20200123-1800Lars Vogel26-34/+32
Uses method references if possible Removes unnecessary brackets Using the upcoming JDT cleanup from https://git.eclipse.org/r/#/c/148248/ Method references are faster in execution and shorter. Change-Id: I4b8edca1ad34eb1c8788e6729c9bb76f1eefb335 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-22Bug 559251 - restored missing validate() events during async computationI20200123-0525I20200123-0430I20200122-1805Julian Honnen2-10/+72
Only clear the occurred document events when they were actually consumed by the filtering. While the async computation is running, filtering is postponed and events are left in the queue. This ensures that ICompletionProposalExtension2 can adapt their replacement length correctly. Replaced fIsFilterPending with an AtomicBoolean to avoid synchronization issues when accessed by computation thread. Change-Id: I92ec82eb43a52301aa0116f00e5d703840348187 Signed-off-by: Julian Honnen <julian.honnen@vector.com>
2020-01-22Bug 559298 - skipAPIAnalysis is enabled for some platform bundlesAndrey Loskutov1-1/+0
Change-Id: I0082aec37f9e8a4acd7b5c2fd3c5b3323792f282 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2020-01-20Bug 558382 - Build with tycho 1.6.0Y20200121-0055Y20200120-2315I20200121-2225I20200121-1805I20200120-1800Alexander Kurtakov1-1/+1
Switch tycho pomless version. Change-Id: I2f1e7ba4db14914028401e8de7572e79076d64ca Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2020-01-19Bug 559093 - [JFace] Completion proposal popup foreground color can beI20200120-0715I20200120-0530Ralf Heydenreich2-2/+2
wrong - fixed method calls Change-Id: Ic7882b0afb61ac4404555d3d70f094c6731ec4fe Signed-off-by: Ralf Heydenreich <rheydenr@justmail.de>
2020-01-17Use lambdas where possibleY20200120-0020I20200120-0445I20200120-0355I20200120-0115I20200119-2330I20200119-1800I20200118-1800I20200117-1800Lars Vogel54-800/+358
Using the batch cleanup operation via Source -> Cleanup -> "Use lambdas where possible" from standard JDT. Change-Id: I609127e1d7267230c8741a155b81e4b004d7ee15 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-174.15 update for org.eclipse.ui.genericeditorLars Vogel1-1/+1
Required for https://git.eclipse.org/r/154824 Change-Id: I64fbf47fe18e8b9eb53337fda6a44b0bef3b42e2 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-164.15 update for org.eclipse.text.testsI20200116-1800Lars Vogel2-2/+2
Required for https://git.eclipse.org/r/#/c/154804/ Change-Id: I794b6cb24d13d3c61200cc8398c0aaa482dde780 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-15Remove unnecessary array creation for varargs in bundlesI20200116-0930I20200116-0330I20200116-0310I20200115-1800Lars Vogel19-30/+35
Using the batch cleanup operation via Source -> Cleanup -> "Remove unnecessary array creation for varargs " from standard JDT. See also https://bugs.eclipse.org/bugs/show_bug.cgi?id=559175 applying this cleanup to LinkedModeConfigurationBlock results in a syntax error Change-Id: I097502952bbb3263c8b3253efff95a0d1981acf2 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-14Use Integer.parseInt to avoid wrapper creation with Integer.valueOf inI20200114-1805Lars Vogel1-1/+1
QuickSearchDialog Change-Id: Ifb6c65ffcc49776d8d3548da40bec2c3b648ddf0 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-134.15 update for org.eclipse.ui.editors.testsY20200114-0045I20200113-1800Lars Vogel2-2/+2
Required for https://git.eclipse.org/r/154824 Change-Id: I45409c81371967f92d7985dbf91f3ee766d1a3fe Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-13Use System.lineSeparator()Lars Vogel7-7/+7
Benefit of this way rather than System.getProperty("line.separator") is that there are no security checks. Change-Id: I3ff085c291a6c279f3a434134c3bfdd6ffea0353 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-13Removes unnecessary NLS statementsLars Vogel1-2/+2
Change-Id: I51195e83551fe7251fb4d0dbd4904bbabc5789bb Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-134.15 update for org.eclipse.search.testsLars Vogel2-2/+2
Required for https://git.eclipse.org/r/155709 Change-Id: I08576968d05f3f28c3fe73484bd3826294e50929 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-13Bug 558921 - NPE in async content assist with insert common prefixMickael Istria2-2/+58
Change-Id: Ibcfea620c5c7c5a8cdad2d00322403523cad7201 Signed-off-by: Mickael Istria <mistria@redhat.com>
2020-01-134.15 update for org.eclipse.core.filebuffersLars Vogel1-1/+1
Required for https://git.eclipse.org/r/154803 Change-Id: Ibc280bff17dc608aabbeed711286698519427e97 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-10Removes unnecessary whitespace from text repositoryI20200113-0130I20200112-1800I20200111-1800Lars Vogel12-72/+72
Change-Id: Ie5da7fb237e8ae43d872c0cb77c6b87dd547e5ce Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-074.15 update for org.eclipse.ui.workbench.texteditor.testsI20200111-0325I20200111-0230I20200110-1805Lars Vogel2-2/+2
Required for https://git.eclipse.org/r/155312 Change-Id: Icaefdb8a10491881bb49f200300b101faae21768 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2020-01-06Bug 94106: Fix hide/cleanup of content information popup stackY20200108-0435S4_15_0_M1I20200110-0905I20200110-0200I20200109-2350I20200108-2240I20200108-0600I20200108-0025I20200107-1800I20200107-0600I20200106-1805I20200106-0600Stephan Wahlbrink4-13/+150
Change-Id: Ia35c3c860918d2713e29b11b409d7cacfe726fe7 Signed-off-by: Stephan Wahlbrink <sw@wahlbrink.eu>
2020-01-06Bug 558781 - TextPresentation iterator catches wrong exceptionPaul Pazderski2-19/+31
Change-Id: Ie50c2216c58656079ad00fd8938d03818e5a385b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-05Bug 550987 - [tests] Increase test coverage of TextPresentationI20200105-1800I20200105-0955Paul Pazderski1-20/+666
and disposal of some, previous ignored, resources. Change-Id: I227b81264752e90f4557eee74e696d67fd639ba5 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-05[tests] Update code alignment in TextPresentationTestPaul Pazderski1-82/+82
Change-Id: I7bac348a24ec1042f2797eda16cc49af3977fe7b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-054.15 update for org.eclipse.text.testsPaul Pazderski2-2/+2
Change-Id: I112b19038210a5bef60bb9cf7216dfc036f02275 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2020-01-03Bug 558510 partially revert: TextviewerY20200103-2350I20200105-0600I20200104-1800I20200104-0625I20200104-0600I20200103-1800Carsten Hammer1-6/+13
revert https://git.eclipse.org/r/#/c/152786/ Change-Id: I5cea88489165cc8741bd55efb05b5e9993fac355 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>

Back to the top