Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-08-22Bug 550327 - Move "Quick Search" pref page under "Preferences > General"I20190823-0840I20190823-0530Mickael Istria1-3/+5
Change-Id: I4e7a1c0caa83e41c8ce344a0c5aa4e4116478759 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-08-19Bug 545252 - Improve IDocumentAdapterExtension in DefaultDocumentAdapterY20190822-0900Y20190819-0900S4_13_0_M3I20190821-1800I20190821-0600I20190820-1800I20190820-0855I20190820-0600I20190819-2355I20190819-0600Paul Pazderski2-47/+46
with copy-on-write approach For the old implementation when change forwarding is disabled the whole document content is copied and the line tracking information rebuild even if the document is not changed but only read. The new approach only copies the document if a change happens. Change-Id: I396a142d70268e33017117e9e99535ae37463b72 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-08-18Bug 550101 - [Quicksearch] Strings not externalizedI20190818-1800Mickael Istria16-94/+223
Change-Id: I6dc5042b7b5a59a53114935642cffb2fa6e5dad6 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-08-18Bug 550058 - [Quicksearch] Name mismatch in UI and N&NMichael Keppler2-6/+6
Change the dialog title to "Quick Search", such that the same label is used everywhere. Use an ellipsis in the menu item to indicate a following input dialog. Also remove unwanted text parts from the command, command category and actionset labels, and fix capitalization and grammar. Change-Id: I9886c9f39c9e1ffdf79478fdbdefb4696a5c8214 Signed-off-by: Michael Keppler <michael.keppler@gmx.de>
2019-08-15Bug 549663 - Quick search preview dialog mixed line offset and lineI20190817-1800I20190816-1800I20190816-0155Paul Pazderski1-1/+3
index Change-Id: I969063920308526e237347d8fb6b276215a87cf0 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-08-15Bug 550042 - Compare ignored file extensions case insensitiveY20190815-0900Michael Keppler1-7/+6
Use case insensitive comparison for ignored file extensions in quicksearch. Remove the duplications from the default extensions and sort them for easier reading. Also add some more extensions (.bmp, .com, .jpeg). Change-Id: Idc1855921167ed3d1635ba0cae4b66444c76b1cf Signed-off-by: Michael Keppler <michael.keppler@gmx.de>
2019-08-15Bug 550020 - quick search preview area too smallMichael Keppler1-1/+1
Use more weight in the sash weight distribution for the preview area. You must use a new workspace to see the result of this change. On my system this produces about 2.5 lines of preview text now instead of a single line. Change-Id: I840b535d079dcceedecc94bb0642a5cc39c3eb3a Signed-off-by: Michael Keppler <michael.keppler@gmx.de>
2019-08-15Bug 550031 - Remove superfluous slash from quicksearch pathsMichael Keppler1-1/+4
The results of the quicksearch dialog have a path column. All the paths displayed there started with a slash, which can be removed, since it adds no value. Change-Id: I4d21038e9343c4feff7137a0ba4ab6064a05eedf Signed-off-by: Michael Keppler <michael.keppler@gmx.de>
2019-08-15Fix layout of quicksearch preference pageMichael Keppler3-30/+38
The multi-line preferences for ignored names/prefixes/extensions do not resize and therefore have a different size than the maxLineLength preference at the top of the page. Remove the character width limitation, and set a layout data width instead. This makes the field editors resize as expected, such that all field editors have the same size. Change-Id: I8e5c7b186e7058e14949ee528f336011953a786d Signed-off-by: Michael Keppler <michael.keppler@gmx.de>
2019-08-14Use StringBuilder in ProjectionDocumentTestI20190814-1800Lars Vogel1-20/+20
Change-Id: I8f6b8ba5d7417b8513541ba1ee95976f0952ce0b Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-08-14Fix alignment of Refresh button in QuickSearch dialogMichael Keppler1-1/+2
The row with the "Matching items" label and the Refresh button has only 2 columns, not 3. The additional empty column lead to empty space right of the Refresh button. Also fix a reuse of layout data in the same method. Layout data shall not be reused for multiple widgets according to the documentation. Change-Id: Ic0d1e1b9016fb4e40fbceae9c7548f1d70d9bc6a Signed-off-by: Michael Keppler <michael.keppler@gmx.de>
2019-08-14Bug 550021 - Wrong tooltips in quicksearch preferencesMichael Keppler1-3/+3
Change-Id: Ia800ef9f083f5010b49ac3181e7f9dd469315ffb Signed-off-by: Michael Keppler <michael.keppler@gmx.de>
2019-08-13Bug 549858 - Use PlatformUI.getWorkbench instead ofLars Vogel4-5/+9
AbstractUIPlugin.getWorkbench Change-Id: I68790f93741cc134199976229b1b6f4688c53a0f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-08-12Bug 549961 - Progress view flickers when search is in progress usingI20190813-1800I20190812-1800Paul Pazderski1-0/+1
Quick Search Dialog Change-Id: I9c1893c57b0e78fa8c1d80f38348c7dfe60c37fb Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-08-09Bug 513034 - Fix org.eclipse.ui.genericeditor/icon ext-point exampleY20190812-0900I20190811-1800I20190810-1800I20190809-1800Mickael Istria1-2/+2
Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-08-08Bug 548679 - Tooltips convert `&` into underlineI20190808-1800Andrew Obuchowicz1-1/+3
Disable mnemonics for LSP-based tooltips/markers Change-Id: I983ee28d37fd035796198ec0bd1b69c42efb42ac Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2019-08-06Bug 549665 - [generic editor] Package Explorer should supportY20190808-0900I20190807-1800I20190806-1800Lakshminarayana Nekkanti5-14/+28
content-type specific icons for generic editor Change-Id: Iaa9702e4503183981d64b2b4553b01178818ceb8 Signed-off-by: Lakshminarayana Nekkanti <narayana.nekkanti@gmail.com>
2019-08-05Bug 513034 - Fix ext.point schema locationI20190805-1800Mickael Istria1-1/+1
Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-08-05Bug 513034 - Improvement to extension pointMickael Istria6-161/+152
* Rename extension point to simpler "icons" * Rename contentTypeId to just contentType (like other extensions) * Rename class to convention Change-Id: I57d69658cbf8998e16c3ccb7b1d6430f8e5d01e8 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-08-05Bug 549665 - [generic editor] Package Explorer should supportY20190805-0900Lakshminarayana Nekkanti3-0/+147
content-type specific icons for generic editor (edit) Change-Id: I51760d6d50729d4d159c18059f1dc67caf937d5b Signed-off-by: Lakshminarayana Nekkanti <narayana.nekkanti@gmail.com>
2019-08-05Bug 549755 - Use DocumentRewriteSession for undo/redo with many changesPaul Pazderski1-2/+27
Change-Id: Iac91b58513b265b43be3bb988a78684b140cc10e Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-08-05Bug 548518 - Improve QuickSearchDialogAlexander Kurtakov5-21/+23
Fix warnings and use standard header. Change-Id: I9ac64e4947071f773a2c313c3b12b764566e0ad9 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-08-02Bug 548518 - Improve QuickSearchDialogI20190804-1800I20190803-1800I20190802-1800Mickael Istria4-31/+47
* externalize strings * Relabel Go! to Open * Make Open button default * Moved refresh button closer to request part * Remove some listeners (leverage JFace API) Change-Id: Ie7850c8277a8a4c7aa5790e3f3d7990f26e90e62 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-07-30Bug 549604 - Text editor status line should show caret offset andY20190801-0900I20190801-1800I20190801-0600I20190731-1800I20190730-1800Andrey Loskutov12-13/+119
selection The status line of the test editors before this change shows line:column information only. This change introduces additionally current cursor offset, or, if the editor has selection, count of selected characters. If the editor has no selection, line:column:caret offset is shown. If the editor has some selection, line:column[selected characters count] is shown. Both additions to the status line are enabled by default but can be turned off on the General -> Editors -> Test Editors preference page. Change-Id: I9e06f48f29987ac4eb21bfe0e818166bcbc61dbe Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-07-29Bug 548446 - inline annotations + "Folding>Collapse All" can cause NPEY20190730-0135Y20190730-0055I20190729-1800Mickael Istria2-1/+8
Change-Id: If94b0e49bfeb53fc38644e8950df4e7d141c1d16 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-07-29Bug 548518: STS Quicksearch ContributionY20190729-0900Kris De Volder47-0/+5271
Make copy of STS quicksearch code from https://github.com/spring-projects/eclipse-integration-commons/ Changes from original code: - plugin ids changed to org.eclipse.text.quicksearch and org.eclipse.text.quicksearch.tests - command and action set ids renamed to org.eclipse.text.quicksearch.* - about.html changed based on example from other platform bundles - packages renamed to org.eclipse.text.* - Preference page reimplemented using jface FieldEditors. - EPL license headers v1.0 => v2.0 - Add some missing license headers - Externalize strings from preferences page UI - Various small code style improvements from feedback in gerrit - Keybinding changed to CTRL+ALT+SHIFT+L - add '.internal' to package names - use 'x-internal=true' on all packages - export all packages - bundle and package version constraints - trailing whitespace cleanups - configure save actions to remove trailing whitespace in the future - remove jgit dependency - adopt ant 'TokenizedPattern' as replacement for jgit in ResourceMatcher - add some basic regression tests for ResourceMatcher - add 'Automatic-Module-Name' headers to plugin manifests Change-Id: Id2c1e0fbd75e7635656e3801cf31af09e71858d5 Signed-off-by: Kris De Volder <kdevolder@pivotal.io>
2019-07-26Bug 549560 - Improve image creation in DefaultRangeIndicatorI20190728-1800I20190727-1800I20190726-1800Paul Pazderski1-4/+4
Change-Id: Iaf89dc5da8c03c0fba50599d79438082ca1b933f Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-07-25Bug 549502 - Add system default colors in Appearance Color Options tableI20190725-1800Andrew Obuchowicz1-14/+38
Added use of SWT.COLOR_... to reliably obtain the system default colors for the color previews in the appearance color table. Change-Id: I256652d342383c0e50f794d8b04d26f699cea097 Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2019-07-25Bug 17805 - [painting] Print margin drawn on top of textY20190725-0900Paul Pazderski1-2/+2
MarginPainter is not respecting margin of the text widget. Change-Id: Ia3782e249f66b1d0880f6e68868451f3d5402e10 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-07-24Bug 549415 - Remove useless fieldI20190724-1800Mickael Istria1-4/+1
previousColor is not necessary any more as it's the value that's in the preferenceStore already. Change-Id: Ia40d18b8dc3adec4354d682045601d72ed02dc79 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-07-23Bug 549496 - VisibleLinesTracker is activated twice inI20190723-1800Paul Pazderski2-13/+6
LineNumberRulerColumn Tracker is activated enabled twice but only deactivated once. At the same time the Tracker should use ListenerList for its listeners. Change-Id: I310dc8cfc5068e329d81e7bd668b9f0646d2873b Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-07-23Bug 549415 - Improve colorpicker enablement in TextEditor pref pageMickael Istria1-49/+23
Never disable button, so it shows the actual system color and can save a click when trying to select a new color and current is system Change-Id: I720180d4b456705b51947759fc7043e3136e4221 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-07-22Bug 548057 Add color preview in "Appearance Color Options" tableI20190722-1800Andrew Obuchowicz1-71/+160
Change-Id: I45a454912d14169e166a26fad8d09014b0e5a3b6 Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2019-07-18Revert "Bug 547532 - disable test fails due revert for bug 549110"Y20190722-0900I20190721-1800I20190720-1800I20190719-1800I20190718-1800Mickael Istria2-10/+10
This reverts commit 0bd3a714d8fc745e80c76e805bfee9fef8cd0491 Re-enables the tests since upstream is fixed Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-07-18Bug 513034 - [generic editor] Provide a way for generic editor to useLakshminarayana Nekkanti13-4/+397
different icon based on content-type Change-Id: I669c1a8df2918cdecea5e12d71059e34cb2f1c3f Signed-off-by: Lakshminarayana Nekkanti <narayana.nekkanti@gmail.com>
2019-07-18Bug 548799 - Replace usage of AbstractUIPlugin#imageDescriptorFromPluginY20190718-0905Alexander Fedorov2-7/+8
Use ResourceLocator#imageDescriptorFromBundle Change-Id: Ia98ce7df28405d4691ea33ea9d3a03b97b9ec827 Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2019-07-12Bug 547532 - fixed test compilation warningsY20190718-0450Y20190715-2335Y20190715-0900I20190717-1800I20190716-1800I20190715-1800I20190714-1800I20190713-1800I20190713-1105I20190713-0230I20190712-1800Andrey Loskutov2-10/+8
They were introduced after disabling test fails due revert for bug 549110 Change-Id: I171662075e5ef1ed9bbef23e2469b39884146989 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-07-11Bug 547532 - disable test fails due revert for bug 549110Y20190711-2335Y20190711-0900S4_13_0_M1I20190712-0625I20190711-1805I20190711-1120I20190711-0825Andrey Loskutov2-2/+4
Change-Id: Ibf7ad453a934b333b7a2b9c04321eb24f68408cb Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-07-05Using indexOf char instead of indexOf StringY20190708-0900I20190710-1800I20190710-0610I20190709-1800I20190709-0610I20190708-1800I20190708-1035I20190708-0800I20190707-1800I20190707-0110I20190706-1800I20190705-1800Lars Vogel2-7/+7
See https://sourceforge.net/p/findbugs/feature-requests/300/#cb7f for a performance related discussion Change-Id: If69738a092217087471d6013669c26e1854231d4 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-07-05Removes unnecessary toString calls and uses append inLars Vogel1-7/+7
FileBufferFunctions Change-Id: I66831de205c78fc4234d9a05e643d55e1cb9989d Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-07-03Bug 121634 - [find/replace] status bar must show the string beingY20190705-0620Y20190704-0900I20190704-1800I20190704-0245I20190703-1800Pierre-Yves B.4-20/+31
searched when "String Not Found" Change-Id: I13fbad199668fd86691456616e4b20eeedba2443 Signed-off-by: Pierre-Yves B. <PyvesDev@gmail.com>
2019-07-03Bug 547519 - Workaround bug 548866I20190703-0640Mickael Istria1-1/+2
Change-Id: I9446a114f469993f18c30d6d3ea01500ba00747f Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-07-02Bug 548732 - Fix LineContentBoundsDrawingTestI20190702-1800I20190702-0930Mickael Istria1-1/+1
On Windows and Mac, there are shadows or borders printed on the widget, so try to exclude them from the scanned area when looking for a color. Change-Id: Icf445c775435fd5a1152b106de6ad247958f4926 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-06-28Bug 517681 - 'No suggestions available' always visible in quick fixY20190701-0635Y20190628-1440I20190702-0610I20190701-1805I20190630-1800I20190629-1800I20190628-1800Lakshminarayana Nekkanti1-3/+1
Remove SpellingCorrectionProcessor from Generic Editor as it's not desired in it. Signed-off-by: Lakshminarayana Nekkanti <narayana.nekkanti@gmail.com>
2019-06-27Bug 547519 - [code mining] Fix apply on tabulationI20190627-1800Mickael Istria6-12/+109
With patch for SWT bug 547519, it's not possible to draw annotations at the right of a tabulation, just by fixing the char width. Change-Id: I1432a40f6bd2c25dfe4d11ba40ec278fbd448fa8 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-06-26Bug 547519 - [code mining] Don't apply on tabY20190627-0630Y20190627-0200Y20190627-0045I20190627-0135I20190626-1800Mickael Istria5-19/+173
This is more a workaround as the solution is not optimal at usage (caret not properly placed), but the proposed state is still better than current one. This prevents from making a '\t' character "host" the annotation as it comes with a bunch of issues in the DrawingStrategy (that fails at properly computing the width of a tab) and in SWT (bug 547532). Change-Id: I897da06cd57aef80a862ba28dc75887c212d234a Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-06-24Bug 474156 - Run API Tools builder in the Gerrit verification buildI20190626-0720I20190625-1800I20190625-0535I20190624-1800Mickael Istria2-0/+7
Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-06-18Use addAll, deleteAll instead of looping through a collectionI20190623-1800I20190621-1800I20190620-1800I20190620-0130I20190619-1820I20190619-1800Lars Vogel7-25/+16
Change-Id: I35edd6a934a0f65f357a54e710c77c190706bb45 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-17Removes redundant semicolonsI20190618-1805I20190618-0225I20190617-1800Lars Vogel1-3/+3
Change-Id: I41a105681a1e1578278ca64cc409913283c9cdac Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-17StringBuilder instead of StringBufferLars Vogel2-2/+2
Change-Id: Iefefe2b40d406a866e0ce9b7b420b3b74880d536 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>

Back to the top