Skip to main content
aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-06-24Bug 474156 - Run API Tools builder in the Gerrit verification buildI20190626-0720I20190625-1800I20190625-0535I20190624-1800Mickael Istria2-0/+7
Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-06-18Use addAll, deleteAll instead of looping through a collectionI20190623-1800I20190621-1800I20190620-1800I20190620-0130I20190619-1820I20190619-1800Lars Vogel7-25/+16
Change-Id: I35edd6a934a0f65f357a54e710c77c190706bb45 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-17Removes redundant semicolonsI20190618-1805I20190618-0225I20190617-1800Lars Vogel1-3/+3
Change-Id: I41a105681a1e1578278ca64cc409913283c9cdac Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-17StringBuilder instead of StringBufferLars Vogel2-2/+2
Change-Id: Iefefe2b40d406a866e0ce9b7b420b3b74880d536 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-17Use String.contains instead of indexOfLars Vogel1-1/+1
Change-Id: I8e30423f946361f2d743f051bfbb6dbff796e86b Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-17Remove redundant blockLars Vogel6-103/+83
Change-Id: I01d785405a51605a19429bcd9560232530fc51c1 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-16Bug 548060 - Improve positioning of widgets on Annotations pageI20190616-1800Andrew Obuchowicz1-4/+0
Patch Ready For Review Change-Id: I9c2df01a49d90d2517a44eccb6842ed55fec5ee9 Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
2019-06-16Bug 548109 - TemplatesView should adapt to IContributedContentsViewRolf Theunissen1-0/+9
Change-Id: I58840cd108dba78a42027ba46ee94bf982b004de Signed-off-by: Rolf Theunissen <rolf.theunissen@gmail.com>
2019-06-14Use isEmpty() instead of length() to check if collection is emptyI20190615-1800I20190614-1800Lars Vogel82-175/+175
Change-Id: I0106dd0c2ddfa318375877d4562068d82aa9ac5f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-13Use jdk 5 for-each loopI20190614-0330I20190613-1800Carsten Hammer85-442/+431
Replace simple uses of Iterator with a corresponding for-each loop. Also add missing braces on loops as necessary. Change-Id: Ibde37d56a7962f432ed771f4a215f5903161bde0 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-06-12Use isEmpty() instead of size()==0 where possibleI20190613-0210I20190612-1800Carsten Hammer25-33/+33
Change-Id: Ib6c59f4c9cea396c98196d23ff9ea917e2ef4114 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-06-12Activate save actions and Eclipse formatter on org.eclipse.text.testsLars Vogel2-18/+154
Change-Id: Iff7a0b84529df39d32ef73ec2f5a4adc2c0d6798 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-124.13 version updateKarsten Thoms12-12/+12
Version bumps for https://git.eclipse.org/r/#/c/142828/ - org.eclipse.core.filebuffers - org.eclipse.search - org.eclipse.text - org.eclipse.ui.genericeditor - org.eclipse.ui.genericeditor.examples - org.eclipse.ui.workbench.texteditor Change-Id: I22121e709aa405ad9479934d511a34ef206f8361 Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2019-06-11Removes trailing whitespace from org.eclipse.text.testsI20190612-0115Lars Vogel22-311/+311
Change-Id: Ieb237a6c49182be02a6d722189deddafe93e069f Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-11String.indexOf can be replaced with String.containsCarsten Hammer4-4/+4
Change-Id: I4fa6df22b0e8c3bd3d59c9f98ca417899366ae03 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-06-114.13 version of org.eclipse.ui.editorsLars Vogel2-2/+2
Change-Id: I3b9598f99481b1972792e66759720443b5113594 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-114.13 version update of org.eclipse.jface.textLars Vogel2-2/+2
Required for https://git.eclipse.org/r/142761 Change-Id: I6dba625b49c0dfdf2d401c9fa078b7b797426a94 Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-11Use StringBuilder instead of StringBuffer where possible.Carsten Hammer10-50/+50
Change-Id: Ifee0c0b2ecbdaad31ea628c4fbe87cec89897012 Signed-off-by: Carsten Hammer <carsten.hammer@t-online.de>
2019-06-114.13 version update for org.eclipse.ui.examples.javaeditorLars Vogel2-2/+2
Required for https://git.eclipse.org/r/#/c/142752/ Change-Id: Ic1fc8641826197b2a8f393f46bc7877c63070d8b Signed-off-by: Lars Vogel <Lars.Vogel@vogella.com>
2019-06-11Bug 546826: "To uppercase" and "to lowercase" commands should have iconMatthias Becker11-2/+12
Change-Id: I315a8c5b1a6d2fdda584ee01ce43a0cfa4d71903 Signed-off-by: Matthias Becker <ma.becker@sap.com>
2019-06-10Bug 547928 - Version bumps for 4.13 streamI20190610-1800I20190610-0135Sarika Sinha14-21/+21
Change-Id: Ic98f1d62749421775c99b5d92e709c596f41ce28 Signed-off-by: Sarika Sinha <sarika.sinha@in.ibm.com>
2019-06-07Bug 547907 (Part2)- POM and product version change for 4.13 releaseI20190608-0140I20190607-1345I20190607-1000I20190607-0725Niraj Modi7-7/+7
- Fixing JUnit version back to 4.12 from 4.13 Change-Id: If8d2799b15e6a5a9e5779a64cb1e89c6c40ebb02 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2019-06-07Bug 547907 - POM and product version change for 4.13 releaseNiraj Modi26-28/+28
Change-Id: I16ed9807c1390ccba626efaa09cfa80308667a26 Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2019-05-19Bug 547304 - [cleanup] Fix wrong space/tab indentationS4_12_0_RC2S4_12_0_RC1aS4_12_0_RC1S4_12_0_M3R4_12I20190605-1800I20190605-0600I20190604-1800I20190604-0600I20190603-1800I20190603-0600I20190602-1800I20190602-0600I20190601-1800I20190531-1800I20190531-0245I20190529-2005I20190529-1800I20190529-0600I20190528-1800I20190528-0915I20190528-0850I20190528-0600I20190527-1805I20190527-0600I20190526-1800I20190526-0600I20190525-1800I20190525-0600I20190524-1800I20190524-0135I20190522-1800I20190522-0600I20190521-1800I20190521-0600I20190520-1805I20190520-0600R4_12_maintenancePaul Pazderski131-1406/+1406
This change fixes space or mixed tab/space indentations in all Java files. This also includes two or three space indentations and even fix most stray single spaces in indentations. The change includes only whitespace formatting and no code changes. Change-Id: I3e7b6abb69a1894c402f9123417346a44fc0992a
2019-05-18Bug 547304 - [cleanup] Fix wrong line delimitersPaul Pazderski30-2906/+2906
This updates all Java files with wrong or mixed line delimiters to use Unix style delimiters. The change includes only whitespace formatting and no code changes. Change-Id: I970d212a3e4edb8a85c58901336551190dfd2164
2019-05-09Bug 547053 - [block selection] Default font is still "Monaco" on macOSI20190519-1800I20190518-1800I20190517-1800I20190516-1800I20190516-1405I20190516-1335I20190516-1250I20190516-1200I20190516-1055I20190515-1800I20190515-0205I20190513-1800I20190512-1800I20190511-1800I20190510-1800I20190509-1800Pierre-Yves B.1-1/+1
Change-Id: Ib328e9f3407db5ed0ea27f31044055585deb3cb6 Signed-off-by: Pierre-Yves B. <PyvesDev@gmail.com>
2019-05-02Bug 546920 - FileDocumentProvider.createElementInfo(Object) should notI20190508-1800I20190508-0450I20190508-0150I20190507-1800I20190507-0155I20190506-1800I20190505-1800I20190504-1800I20190503-1800I20190502-1800Andrey Loskutov1-4/+9
refresh unconditionally An attempt to call refreshFile() while workspace is locked results in a blocking progress dialog. This is not needed if the file is not out-of-sync, which can be tested via *non-blocking* file.isSynchronized() API. This patch does exact that. Change-Id: Ia1b0b7ba250f92e49bbe4343ba542a5d5c4e752b Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-05-02Bug 546828 - Editors based on FileDocumentProvider /Andrey Loskutov9-11/+406
TextFileDocumentProvider lock UI on attempt to edit while build is running The change modifies FileDocumentProvider.getValidateStateRule() and DocumentProviderOperation created in TextFileDocumentProvider.validateState() to return non-null rule (referenced IFile) for IFileEditorInput's if the IResourceRuleFactory.validateEditRule() has no rule for us. This prevents UI freeze on attempt to modify a file while build is running. Instead of a freeze, we get a progress dialog with a possibility to cancel the (blocking) attempt to modify the file. Change-Id: I23a6ddab2ca8f31b5ba134301356c34250f5087c Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-05-02Bug 546910 - [code mining] Char drawn w/ wrong color when selectedMickael Istria1-24/+39
Change-Id: I8c8ca72c9c5d16ceee4cc7944018e24198a1fca0 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-04-30Fixed compile warning introduced by bug 546706I20190501-1800I20190501-0525I20190430-1800Dani Megert1-2/+0
2019-04-29Bug 546706 - multi-line code minings rendered erroneouslyI20190429-1800Mickael Istria5-7/+87
Change-Id: I1a89962176d2583551e4fcd28b2511a69b62aa23 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-04-23Bug 546594 - GUI freeze when using Compare Viewer with large filesI20190429-0240I20190428-1800I20190427-1800I20190426-1800I20190425-1800I20190425-0030I20190424-1800I20190423-1800zeljko.zurzic1-1/+13
Changes the line tracker used for DocumentClone. If the line delimiters are equal to the default ones, use the DefaultLineTracker instead of the ConfigurableLineTracker - for performance improvement Change-Id: I9b6b570d87eade205f4984f04001ec8170f09c3e Signed-off-by: zeljko.zurzic <zeljko.zurzic@amiq.com> Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-04-22Remove redundant implements.Alexander Kurtakov1-2/+1
Extended class already implements this interface. Change-Id: I6157205224c2cdf7d7d2f8f54c1c3cf63d4c244e Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2019-04-16Added API Tools filter for bug 515570 - [api] org.eclipse.ui.editorActions ↵I20190422-1800I20190421-1800I20190420-1800I20190419-1800I20190418-1800I20190417-1800I20190416-1800Dani Megert1-0/+8
should allow modifiers
2019-04-15Bug 515570 - [api] org.eclipse.ui.editorActions should allow modifiersI20190415-1800Sarika Sinha2-2/+2
as part of actionID Change-Id: I8be418aca1956d878c673f3d3ae42e58c128a54f Signed-off-by: Sarika Sinha <sarika.sinha@in.ibm.com>
2019-04-15Bug 515570 - [api] org.eclipse.ui.editorActions should allow modifiersI20190415-0300Sarika Sinha3-5/+23
as part of actionID
2019-04-08Bug 529011 - Remove garbage System.err lineS4_12_0_M1I20190414-1800I20190414-0210I20190413-1800I20190412-1800I20190412-0520I20190411-0625I20190410-1800I20190410-0600I20190409-1800I20190409-0600I20190408-1800Mickael Istria1-1/+0
This was introduced for debugging purpose and I forgot to remove it in previous patch. Change-Id: Ib3f5ec7fc72fd29fd7fb84953256ab7b8d1ef7f0 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-04-08Bug 529011 - Better handle folding when using TextPresentationI20190408-0600Mickael Istria4-16/+31
Some editors rely on TextPresentation, when those are combined with folding, code minings could draw spaces at wrong locations, because the widget coordinates (expected by widget) were not translated for usage in TextPresentation (which expects model coordinate). Change-Id: I6cb17b30b269ebd60eb0253987a99cd4c62e5624 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-04-01Bug 546020 - [code mining] "Index out of Bounds" when inline w/ foldingI20190407-1800I20190406-1800I20190405-1800I20190404-1800I20190403-1800I20190402-1800Mickael Istria11-24/+236
Change-Id: I7b10e2d8122372bec5452225313142cf6ec58f3c Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-03-25Bug 545531 - Define compare/merge viewer for Generic EditorI20190401-1800I20190331-1800I20190330-1800I20190329-1800I20190329-0120I20190328-1800I20190327-1800I20190326-2305I20190326-1800I20190325-1800Mickael Istria19-189/+265
Change-Id: Ia77dedcd18d38fed343817a3d003e83dd76fe9e0 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-03-21Bug 533194 - [Code mining] Cannot position the caret on 1st letterI20190325-0105I20190324-1800I20190323-1800I20190322-1800Mickael Istria5-39/+127
This change the drawing strategy to draw the code mining on the right of the previous character, so caret always is just before the next char. Change-Id: I3951a14faafebf3d947652e8dab2a8bdde27aa13 Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-03-20Bug 545565 - ListLineTracker returns wrong results after content set toI20190321-1800I20190321-0435I20190321-0245I20190320-1800Paul Pazderski4-4/+65
null If tracked text is set to null the tracked content length was not updated. Change-Id: I26ed7b21879ff77a1e3b7828a4e4a4d969608cb8 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-03-19Bug 545530 - Test for TextViewer's default IDocumentAdapterPaul Pazderski3-8/+69
Test cases derived from IDocumentAdapter JavaDoc to check if TextViewer's default implementation of IDocumentAdapter adhere to its interface. Change-Id: I03d122e608662b6b65528c479910c797cf2397b1 Signed-off-by: Paul Pazderski <paul-eclipse@ppazderski.de>
2019-03-11Revert "Revert "Bug 541404 - improve UndoableCompoundTextChange with single ↵I20190318-1800I20190314-1800I20190312-1800I20190312-0340I20190311-1800Mickael Istria3-40/+74
change"" This reverts commit b0d63d9ce8037c9f304ee2e669621266df54820c. Change-Id: I95250fbba8390e7cf01601272d21e8bc218aee75
2019-03-08Bug 545094 - POM and product version change for 4.12 releaseI20190311-0410I20190309-1830I20190308-1830I20190308-1525I20190308-1055I20190308-0740Niraj Modi19-21/+21
Change-Id: Ideffb628508e4505ec7b55afd5ba9f2c5fd75f3c Signed-off-by: Niraj Modi <niraj.modi@in.ibm.com>
2019-03-06Revert "Bug 541404 - improve UndoableCompoundTextChange with single change"Y20190320-2200Y20190319-2305Y20190316-1220Y20190313-2200Y20190313-0215Y20190308-0715Y20190307-1015Y20190306-2200S4_11_0_RC2R4_11I20190307-0500I20190306-2135I20190306-1800R4_11_maintenanceNoopur Gupta1-72/+38
This reverts commit dd94c4b6d3b87eb57d89f2afa3ef4dc7b96e8488. Change-Id: Ibee48390dd5f4c0a2b580972a4f7f1d2ccfdcd3f
2019-03-06Bug 541404 - improve UndoableCompoundTextChange with single changeMickael Istria1-38/+72
When the compound change has only 1 change, it can be processed as a basic change, using the "text change" strategy rather than the "text set". This goes into a simpler redraw loop, which prevent some issues with code minings. Change-Id: Ie54960195b89317e21b182e16704babd52d8d43b Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-03-05Bug 545006 - Reuse existing API for screenshots during testsI20190306-0600I20190305-1800I20190305-0600Mickael Istria4-40/+10
This should allow screenshots to be found more easily in official tests and allow to more easily spot tests disabled on Mac. Change-Id: I7d57891ef83976401d5fdf165f7655b6f783f6fe Signed-off-by: Mickael Istria <mistria@redhat.com>
2019-03-05Bug 540143 - StackOverflowError with async content-assistMickael Istria7-6/+269
A long running failing completion proposal cause StackOverflowError because it's completion state isn't retrieved correctly so the ContentAssistant assume it's not done. Instead, detect the error case and return future normally (error will be logged in console). Change-Id: I82dc511fdcbc7c61f1e575f975ef221e5d0ac160 Signed-off-by: Mickael Istria <mistria@redhat.com> Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
2019-03-03Bug 541415 - disable tests on MacI20190304-1800I20190304-0600I20190303-1800Andrey Loskutov2-0/+20
Change-Id: Iafd6875fe46e2ad8ebbb3aab8141925b5dab5fd8 Signed-off-by: Andrey Loskutov <loskutov@gmx.de>

Back to the top